Skip to content

Why we use magic number 2 at quic_transport_server.py #820

@18Fl

Description

@18Fl

Hello, everyone(maybe I should @vasilvv specially..), I read your demo code quic-transport.

But there are a little code makes me little confusion:

            if isinstance(event, StreamDataReceived) and event.stream_id == 2: // [+] @a
                self.client_indication_data += event.data
                if event.end_stream:
                    self.process_client_indication()
                    if self.is_closing_or_closed():
                        return
                    # Pass all buffered events into the handler now that it's
                    # available.
                    for e in self.pending_events:
                        self.handler.quic_event_received(e)
                    self.pending_events.clear()
            else:
                # We have received some application data before we have the
                # request URL available, which is possible since there is no
                # ordering guarantee on data between different QUIC streams.
                # Buffer the data for now.
                self.pending_events.append(event)

at @A, we use a magic number which is 2, I have 3 question about this:

  1. what does it means at here.
  2. Why we should use 2 instead of 3, 4, 5, etc...
  3. Which document or source code introduce this?

Thank u very much!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions