Skip to content

Usage of lodash instead of esm version lodash-es #16212

@ChristopherPHolder

Description

@ChristopherPHolder

Summary

In version 9.6.0 lighthouse changed the imports of lodash to reduce bundle size #13914

However since then lighthouse has migrated from CommonJS to use ESM. This means it is now able to use the esm version of lodash which is lodash-es.

I am not sure the benefit to bundle size is that large, however since it is already using esm is it not better to use the esm version of the library?

Additionally when bundle lighthouse code with esbuild i end up with this type of additional and unnecessary wrappers in the code.

image

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions