Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[visualizer] use a different color based on the type of an audio node. #8

Closed
hoch opened this issue Jun 28, 2016 · 4 comments
Closed

Comments

@hoch
Copy link
Member

hoch commented Jun 28, 2016

I implemented it like this:
https://github.com/hoch/canopy/blob/master/app/spiral-elements/spiral-audiograph/spiral-audiograph.html#L412

I wish there is a more structured way of doing this, but I don't think dagre supports it. Let's hack together. :)

@chihuahua
Copy link
Collaborator

Agreed. Passing style data like that sg. If only we could assign a CSS class to the node's SVG element.

@chihuahua
Copy link
Collaborator

chihuahua commented Jul 6, 2016

Hey, we can add a CSS class to the node's SVG element (say destNode, sourceNode or midNode) and then vary panel.css. That lets us decouple styling logic from the JS.

@hoch
Copy link
Member Author

hoch commented Jul 6, 2016

Sounds good. This didn't work for Canopy because the svg element was in the Polymer Shadow DOM - but I am sure this will work for the extension.

@chihuahua
Copy link
Collaborator

I think we can say 0774ba4 took care of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants