Fix #5: Download new databases in dbs-tmp instead of overwriting directly

Author: GitSquared

.gitignore

@@ -3,6 +3,7 @@ redist/*.mmdb
 
 # Downloaded databases
 dbs/
+dbs-tmp/
 
 # Logs
 logs

.npmignore

@@ -10,6 +10,7 @@ scripts/update-databases
 # ----
 # Downloaded databases
 dbs/
+dbs-tmp/
 
 # Logs
 logs

.travis.yml

@@ -1,7 +1,7 @@
 language: node_js
 node_js:
-  - 10
   - 12
+  - 13
 jobs:
   - include:
     - stage: update mirror

index.js

@@ -1,4 +1,5 @@
 const path = require('path');
+const fs = require('fs');
 const {EventEmitter} = require('events');
 
 const downloadHelper = require('./scripts/download-helper.js');
@@ -23,6 +24,11 @@ class UpdateSubscriber extends EventEmitter {
 		}, updateTimer);
 		this.checkUpdates();
 
+		// Clean up failed download files
+		fs.rmdir(downloadPath+'-tmp', { recursive: true }, e => {
+			// folder did not exist
+		});
+
 		return this;
 	}
 
@@ -48,14 +54,23 @@ class UpdateSubscriber extends EventEmitter {
 		this.downloading = true;
 		this.emit('downloading');
 
-		downloadHelper.fetchDatabases(downloadPath).then(() => {
-			return downloadHelper.verifyAllChecksums(downloadPath);
-		}).then(() => {
-			this.emit('update', downloadHelper.getEditions());
-		}).catch(error => {
-			console.warn('geolite2 self-update error:', error);
-		}).finally(() => {
-			this.downloading = false;
+		fs.mkdir(downloadPath+'-tmp', () => {
+			downloadHelper.fetchDatabases(downloadPath+'-tmp').then(() => {
+				return downloadHelper.verifyAllChecksums(downloadPath+'-tmp');
+			}).then(() => {
+				fs.rmdir(downloadPath, { recursive: true }, e => {
+					if (e) throw(e);
+					fs.rename(downloadPath+'-tmp', downloadPath, e => {
+						if (e) throw(e);
+						this.emit('update', downloadHelper.getEditions());
+					});
+				});
+			}).catch(error => {
+				console.warn('geolite2 self-update error:', error);
+				fs.rmdir(downloadPath+'-tmp', { recursive: true });
+			}).finally(() => {
+				this.downloading = false;
+			});
 		});
 	}
 

package.json

@@ -5,7 +5,7 @@
   "main": "index.js",
   "types": "index.d.ts",
   "engines": {
-    "node": ">= 10.18.1"
+    "node": ">= 12.10.0"
   },
   "keywords": [
     "maxmind",