FYI: operator == not working on some compilers

[MortenMacFly]

FYI: This code:

  #if (defined(__cplusplus) && (__cplusplus > 201703L)) // C++ > C++17 (MSVC requires <AdditionalOptions>/Zc:__cplusplus</AdditionalOptions>
    bool operator==(const mpFloatRect&) const = default;
  #else
    (...)

...is not working for me on quite a few compilers, incl. MinGW-WinLibs.
Maybe you should #define this such that it can be disabled even if potentially supported by the compiler version.

Other that that: All just fine! :-)

[GitHubLionel]

Ok
DRNadler introduce this type of code for "modern" compiler.
I would add a define if necessary.

[OskarWaldemarsson]

I had the same issue when compiling with mingw64 15.1 and c++23. For me it could be solved by removing the anonymous struct

struct { double Xmin; double Xmax; double Ymin; double Ymax; double Y2min; double Y2max; };

and making its members direct members of the mpFloatRect struct. Apperently c++23 does not seem to happy about defaulting == operator for anonymous structs. Thus just removing struct {}; (keeping the members) will solve this. I guess you could also name the struct, and add a == operator for it, but then you would need to add this name to all instances of where its members are used

[GitHubLionel]

In fact, I do not remember why we have this anonymous struct. I guess it was for eventually an union with an array of 6 double.
I think we can safely remove this struct.

[DRNadler]

I just made a pull request to fix this. No idea why the anonymous structure was ever there...

[OskarWaldemarsson]

Yes, I was also a bit confused about the purpose of this struct. Thanks for the quick support!