missing mouse event handler check in function: void mpWindow::OnShowPopupMenu(wxMouseEvent &event)

[asmwarrior]

Hi, when I try to implement my own mouse event handler, I see the config dialog always pop up when right mouse button get released.

Finally, I found this:

diff --git a/mathplot/mathplot.cpp b/mathplot/mathplot.cpp
index ef09aca..0235615 100644
--- a/mathplot/mathplot.cpp
+++ b/mathplot/mathplot.cpp
@@ -3376,6 +3376,9 @@ void mpWindow::LockAspect(bool enable)
 
 void mpWindow::OnShowPopupMenu(wxMouseEvent &event)
 {
+  if (CheckUserMouseAction(event))
+    return;
+
   // Only display menu if the user has not "dragged" the figure
   if (m_enableMouseNavigation)
   {

[GitHubLionel]

Ok, I add your fix.

[asmwarrior]

When I try to use the mouse button double click event handler in my client code, it just failed, I see that those event were not handled in wxMathPlot, so I added the two functions, do you think they should be added also?

---------------------------- mathplot/mathplot.cpp ----------------------------
index 0235615..232725c 100644
@@ -2657,6 +2657,8 @@ EVT_MOTION(mpWindow::OnMouseMove)// JLB
 EVT_LEAVE_WINDOW(mpWindow::OnMouseLeave)
 EVT_LEFT_DOWN(mpWindow::OnMouseLeftDown)
 EVT_LEFT_UP(mpWindow::OnMouseLeftRelease)
+EVT_LEFT_DCLICK(mpWindow::OnMouseLeftDoubleClick) // Left mouse double-click
+EVT_RIGHT_DCLICK(mpWindow::OnMouseRightDoubleClick) // Right mouse double-click
 
 EVT_MENU(mpID_CENTER, mpWindow::OnCenter)
 EVT_MENU(mpID_FIT, mpWindow::OnFit)
@@ -3010,6 +3012,20 @@ void mpWindow::OnMouseLeftRelease(wxMouseEvent &event)
   event.Skip();
 }
 
+void mpWindow::OnMouseLeftDoubleClick(wxMouseEvent& event)
+{
+    if(CheckUserMouseAction(event))
+        return;
+    event.Skip();
+}
+
+void mpWindow::OnMouseRightDoubleClick(wxMouseEvent& event)
+{
+    if(CheckUserMouseAction(event))
+        return;
+    event.Skip();
+}
+
 // Process mouse wheel events
 // JLB
 void mpWindow::OnMouseWheel(wxMouseEvent &event)

----------------------------- mathplot/mathplot.h -----------------------------
index 565973e..3518d72 100644
@@ -2941,6 +2941,8 @@ class WXDLLIMPEXP_MATHPLOT mpWindow: public wxWindow
     virtual void OnMouseMove(wxMouseEvent &event);                //!< Mouse handler for mouse motion (for pan)
     virtual void OnMouseLeftRelease(wxMouseEvent &event);         //!< Mouse left click (for rect zoom)
     virtual void OnMouseWheel(wxMouseEvent &event);               //!< Mouse handler for the wheel
+    virtual void OnMouseLeftDoubleClick(wxMouseEvent &event);     //!< Mouse handler for the left button double click
+    virtual void OnMouseRightDoubleClick(wxMouseEvent &event);    //!< Mouse handler for the right button double click
     virtual void OnMouseLeave(wxMouseEvent &event);               //!< Mouse handler for mouse motion (for pan)
     bool CheckUserMouseAction(wxMouseEvent &event);               //!< Check if a user mouse action is required
     virtual void OnScrollThumbTrack(wxScrollWinEvent &event);     //!< Scroll thumb on scroll bar moving

[GitHubLionel]

At first impression, I would say no because this events are specific to your project and have no utility in mathplot itself.
But I can add it if you want.

[DRNadler]

I agree with Lionel, let's not add it to MathPlot unless there's something MathPlot would do with the double-clicks. On the other hand, if we think MathPlot would use these in future, add them and the derived classes can call the (currently no-op) MathPlot function in case something is added in future??

[asmwarrior]

OK, I agree with you. So, no need to add those empty event handler. Thanks.

[asmwarrior]

For your information. I have create a gui tool, which can use the mouse to add arrows and labels for image annotation above an image.

See here: asmwarrior/image-label-gui: a gui tool to support Latex's tikz-imagelabels package, I use the wxMathPlot as the base components, and certainly I use a lot of mouse event hooks to draw and drag the mouse.

Happy coding.

[asmwarrior]

But I found an assert error here, see the image gif below:

You can see in this case, the code:

    // Recreate Bitmap if sizes have changed
    if (m_last_lx != m_scrX || m_last_ly != m_scrY)
    {
      DeleteAndNull(m_buff_bmp);
      m_buff_bmp = new wxBitmap(m_scrX, m_scrY, dc);
      m_last_lx = m_scrX;
      m_last_ly = m_scrY;
    }

The m_scrY is 0, which causes the assert error.

[GitHubLionel]

Well, m_scrX or m_scrY equal zero are pathological cases. In that cases, all the program is nonsense.
I think I can add this lines after dc.GetSize(&w, &h); :

  if (w == 0 || h == 0)
    return;

Could you test if that solve your problem ?
Very great your image label tool. It show that we can do lot of things with wxMathPlot.

[asmwarrior]

Well, m_scrX or m_scrY equal zero are pathological cases. In that cases, all the program is nonsense. I think I can add this lines after dc.GetSize(&w, &h); :

  if (w == 0 || h == 0)
    return;

Could you test if that solve your problem ?

Yes, I just added this testing code, and it really solved the assert issue. That great!

Very great your image label tool. It show that we can do lot of things with wxMathPlot.

Yes, I think wxMathPlot is a great component, and it can do a lot of 2D graph manipulation things, such as a complex vector graph editor by adding more and more mouse event handling methods.

Also, extending customized layer classes is very simple, it can be served as a highly customized graph canvas.

[GitHubLionel]

Ok, I push the correction on GitHub 👍

[asmwarrior]

Ok, I push the correction on GitHub 👍

OK, thanks!