AddData error due to that the line(layer) is not added to the plot

[asmwarrior]

/** Add data to the internal vector. This method DOES NOT refresh the mpWindow unless updatePlot = true;
 * Do it manually by calling UpdateAll() or just Fit() if we want to adjust plot
 * BEWARE : You can not call this function if mpFXYVector layer is not added to the mpWindow layers list.
 */
bool mpFXYVector::AddData(const double x, const double y, bool updatePlot)
{
  bool new_limit = false;
  const mpFloatRect* bbox = m_win->GetBoundingBox();

It will crash here, because the m_win is 0x0.

So that this code crashed:

            mpFXYVector* arrowLine = new mpFXYVector("Arrow");

            arrowLine->SetPen(wxPen(*wxBLACK, 2));

            arrowLine->AddData(plotStartX, plotStartY, false);
            arrowLine->AddData(plotEndX, plotEndY, false);

            plotWindow->AddLayer(arrowLine, true);
            plotWindow->Refresh();

Maybe, we have to add some error report or error check here inside the AddData()? function call.
Any ideas?
Thanks.

[GitHubLionel]

Hi,

I seem to remember that we already discuss this question and that's why we put a warning. In fact, it is logic that we can not add data before m_win will be known because we must be able to compute the bounds.
Add a test over m_win prevent the crash but anyway the program will be bad. So maybe crash is a good thing !

[DRNadler]

Hi Lionel - Perhaps an assert(m_win); with a comment explaining why this happens would be good?

[asmwarrior]

Oh, yes, we may discussed this before, but I can't find the discussion.
I think we need at least an assert(), or we may just exit the AddData() function, and do nothing.

[GitHubLionel]

Hi,

Yes assert() is a good idea but I found a workaround by changing the logic. Should be work now without crash.
But in all cases, the programmer should know what he is doing ! lol
In same time, I simplified the code.