When a reaction is added (tested using double tap to add, haven't validated for normal tap to add) it gets added to the end of list of reactions.
If I already have a reaction (e.g. ๐) and then add one (e.g. ๐) it will be ordered ๐ ๐ in GitHawk UI. If I leave the issue and then re-enter it, it gets ordered based on a hardcoded array so that it renders ๐ ๐ (this is the same as GitHub's UI).
It's a very minor bug but when we insert a new reaction, we should place it respecting the order of reactions as determined in this array:
|
private let reactions: [ReactionContent] = [ |
|
.thumbsUp, |
|
.hooray, |
|
.thumbsDown, |
|
.heart, |
|
.laugh, |
|
.confused |
|
] |
When a reaction is added (tested using double tap to add, haven't validated for normal tap to add) it gets added to the end of list of reactions.
If I already have a reaction (e.g. ๐) and then add one (e.g. ๐) it will be ordered ๐ ๐ in GitHawk UI. If I leave the issue and then re-enter it, it gets ordered based on a hardcoded array so that it renders ๐ ๐ (this is the same as GitHub's UI).
It's a very minor bug but when we insert a new reaction, we should place it respecting the order of reactions as determined in this array:
GitHawk/Classes/Issues/Comments/Reactions/ReactionsMenuViewController.swift
Lines 41 to 48 in e738618