Merge pull request #21 from GeneralsOnlineDevelopmentTeam/seer/fix/daily-stats-day-rollover

x64-dev · web-flow · commit bbd5876cd9e8 · 2026-06-05T17:30:44.000-04:00
fix(database): Prevent duplicate primary key on daily stats day rollover
diff --git a/GenOnlineService/Database/Database.DailyStats.cs b/GenOnlineService/Database/Database.DailyStats.cs
@@ -20,7 +20,6 @@
 using Microsoft.EntityFrameworkCore.Metadata.Builders;
 using System.Text.Json;
 
-// TODO_EFCORE: When updating this, make sure we preserve old ON DUPLICATE behavior, to overwrite the old data since day_of_year key will be re-used
 public class DailyStat
 {
 	public DailyStat()
@@ -101,6 +100,7 @@ public static async Task SaveToDB(AppDbContext db)
 			// Insert if new, otherwise update
 			if (entity == null)
 			{
+				g_StatsContainer = new DailyStat();
 				entity = g_StatsContainer;
 				db.DailyStats.Add(entity);
 			}

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@`
`20`	`20`	`using Microsoft.EntityFrameworkCore.Metadata.Builders;`
`21`	`21`	`using System.Text.Json;`
`22`	`22`
`23`		`-// TODO_EFCORE: When updating this, make sure we preserve old ON DUPLICATE behavior, to overwrite the old data since day_of_year key will be re-used`
`24`	`23`	`public class DailyStat`
`25`	`24`	`{`
`26`	`25`	`public DailyStat()`
`@@ -101,6 +100,7 @@ public static async Task SaveToDB(AppDbContext db)`
`101`	`100`	`// Insert if new, otherwise update`
`102`	`101`	`if (entity == null)`
`103`	`102`	`{`
	`103`	`+ g_StatsContainer = new DailyStat();`
`104`	`104`	`entity = g_StatsContainer;`
`105`	`105`	`db.DailyStats.Add(entity);`
`106`	`106`	`}`