Skip to content

Commit a246438

Browse files
planetchiliplanetchili
committed
cleaning up minor warnings and redundant build steps
1 parent 29fbda3 commit a246438

File tree

3 files changed

+2
-12
lines changed

3 files changed

+2
-12
lines changed

‎IntelPresentMon/CommonUtilities/win/Utilities.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ namespace pmon::util::win
144144
std::filesystem::path GetExecutableModulePath(HANDLE hProc)
145145
{
146146
char pathString[MAX_PATH];
147-
DWORD size = std::size(pathString);
147+
auto size = (DWORD)std::size(pathString);
148148
if (!QueryFullProcessImageNameA(hProc, 0, pathString, &size)) {
149149
throw Except<HrError>("failed to get module file name");
150150
}

‎IntelPresentMon/PresentMonService/ServiceMain.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ int CommonEntry(DWORD argc, LPTSTR* argv, bool asApp)
2929
// place middleware dll discovery path into registry
3030
if (!asApp) {
3131
char path[MAX_PATH];
32-
if (GetModuleFileNameA(nullptr, path, std::size(path)) == 0) {
32+
if (GetModuleFileNameA(nullptr, path, (DWORD)std::size(path)) == 0) {
3333
pmlog_error("Failure to get path to service executable").no_trace().hr();
3434
}
3535
else {

‎PresentMon.sln

-10
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,6 @@ Global
204204
{892028E5-32F6-45FC-8AB2-90FCBCAC4BF6}.Release-EDSS|x86.Build.0 = Release|Win32
205205
{892028E5-32F6-45FC-8AB2-90FCBCAC4BF6}.Release-EDSS-MSI|x64.ActiveCfg = Release|x64
206206
{892028E5-32F6-45FC-8AB2-90FCBCAC4BF6}.Release-EDSS-MSI|x86.ActiveCfg = Release|Win32
207-
{892028E5-32F6-45FC-8AB2-90FCBCAC4BF6}.Release-EDSS-MSI|x86.Build.0 = Release|Win32
208207
{808F5EA9-EA09-4D72-87B4-5397D43CBA54}.Debug|x64.ActiveCfg = Debug|x64
209208
{808F5EA9-EA09-4D72-87B4-5397D43CBA54}.Debug|x64.Build.0 = Debug|x64
210209
{808F5EA9-EA09-4D72-87B4-5397D43CBA54}.Debug|x86.ActiveCfg = Debug|x64
@@ -250,7 +249,6 @@ Global
250249
{4EB9794B-1F12-48CE-ADC1-917E9810F29E}.Release-EDSS|x86.Build.0 = Release|Win32
251250
{4EB9794B-1F12-48CE-ADC1-917E9810F29E}.Release-EDSS-MSI|x64.ActiveCfg = Release|x64
252251
{4EB9794B-1F12-48CE-ADC1-917E9810F29E}.Release-EDSS-MSI|x86.ActiveCfg = Release|Win32
253-
{4EB9794B-1F12-48CE-ADC1-917E9810F29E}.Release-EDSS-MSI|x86.Build.0 = Release|Win32
254252
{7A1C7F0B-ECB3-4C98-B74E-E5BBA63BA4A7}.Debug|x64.ActiveCfg = Debug|x64
255253
{7A1C7F0B-ECB3-4C98-B74E-E5BBA63BA4A7}.Debug|x64.Build.0 = Debug|x64
256254
{7A1C7F0B-ECB3-4C98-B74E-E5BBA63BA4A7}.Debug|x86.ActiveCfg = Debug|x64
@@ -273,7 +271,6 @@ Global
273271
{0F60DFD9-208E-443E-8D01-43C902B458A6}.Release-EDSS|x86.ActiveCfg = Release|Win32
274272
{0F60DFD9-208E-443E-8D01-43C902B458A6}.Release-EDSS-MSI|x64.ActiveCfg = Release|x64
275273
{0F60DFD9-208E-443E-8D01-43C902B458A6}.Release-EDSS-MSI|x86.ActiveCfg = Release|Win32
276-
{0F60DFD9-208E-443E-8D01-43C902B458A6}.Release-EDSS-MSI|x86.Build.0 = Release|Win32
277274
{F7D9E1CD-298D-465A-82D2-8778C860BC46}.Debug|x64.ActiveCfg = Debug|x64
278275
{F7D9E1CD-298D-465A-82D2-8778C860BC46}.Debug|x86.ActiveCfg = Debug|x64
279276
{F7D9E1CD-298D-465A-82D2-8778C860BC46}.Release|x64.ActiveCfg = Release|x64
@@ -300,7 +297,6 @@ Global
300297
{BE924A9E-AE24-42A6-9C7C-EABC506A33C9}.Release|x64.Build.0 = Release|x64
301298
{BE924A9E-AE24-42A6-9C7C-EABC506A33C9}.Release|x86.ActiveCfg = Release|x64
302299
{BE924A9E-AE24-42A6-9C7C-EABC506A33C9}.Release-EDSS|x64.ActiveCfg = Release|x64
303-
{BE924A9E-AE24-42A6-9C7C-EABC506A33C9}.Release-EDSS|x64.Build.0 = Release|x64
304300
{BE924A9E-AE24-42A6-9C7C-EABC506A33C9}.Release-EDSS|x86.ActiveCfg = Release|x64
305301
{BE924A9E-AE24-42A6-9C7C-EABC506A33C9}.Release-EDSS-MSI|x64.ActiveCfg = Release|x64
306302
{BE924A9E-AE24-42A6-9C7C-EABC506A33C9}.Release-EDSS-MSI|x86.ActiveCfg = Release|x64
@@ -362,7 +358,6 @@ Global
362358
{08A704D8-CA1C-45E9-8EDE-542A1A43B53E}.Release-EDSS|x86.Build.0 = Release|Win32
363359
{08A704D8-CA1C-45E9-8EDE-542A1A43B53E}.Release-EDSS-MSI|x64.ActiveCfg = Release|x64
364360
{08A704D8-CA1C-45E9-8EDE-542A1A43B53E}.Release-EDSS-MSI|x86.ActiveCfg = Release|Win32
365-
{08A704D8-CA1C-45E9-8EDE-542A1A43B53E}.Release-EDSS-MSI|x86.Build.0 = Release|Win32
366361
{807370FB-ADE0-403A-A278-DF50893E5F94}.Debug|x64.ActiveCfg = Debug|x64
367362
{807370FB-ADE0-403A-A278-DF50893E5F94}.Debug|x64.Build.0 = Debug|x64
368363
{807370FB-ADE0-403A-A278-DF50893E5F94}.Debug|x86.ActiveCfg = Debug|Win32
@@ -376,7 +371,6 @@ Global
376371
{807370FB-ADE0-403A-A278-DF50893E5F94}.Release-EDSS|x86.ActiveCfg = Release|Win32
377372
{807370FB-ADE0-403A-A278-DF50893E5F94}.Release-EDSS-MSI|x64.ActiveCfg = Release|x64
378373
{807370FB-ADE0-403A-A278-DF50893E5F94}.Release-EDSS-MSI|x86.ActiveCfg = Release|Win32
379-
{807370FB-ADE0-403A-A278-DF50893E5F94}.Release-EDSS-MSI|x86.Build.0 = Release|Win32
380374
{C73AA532-E532-4D93-9279-905444653C08}.Debug|x64.ActiveCfg = Debug|x64
381375
{C73AA532-E532-4D93-9279-905444653C08}.Debug|x64.Build.0 = Debug|x64
382376
{C73AA532-E532-4D93-9279-905444653C08}.Debug|x86.ActiveCfg = Debug|Win32
@@ -389,7 +383,6 @@ Global
389383
{C73AA532-E532-4D93-9279-905444653C08}.Release-EDSS|x86.ActiveCfg = Release|x64
390384
{C73AA532-E532-4D93-9279-905444653C08}.Release-EDSS-MSI|x64.ActiveCfg = Release|x64
391385
{C73AA532-E532-4D93-9279-905444653C08}.Release-EDSS-MSI|x86.ActiveCfg = Release|x64
392-
{C73AA532-E532-4D93-9279-905444653C08}.Release-EDSS-MSI|x86.Build.0 = Release|x64
393386
{5805A705-ADB3-4888-A244-4AAB86A1005D}.Debug|x64.ActiveCfg = Debug|Any CPU
394387
{5805A705-ADB3-4888-A244-4AAB86A1005D}.Debug|x86.ActiveCfg = Debug|Any CPU
395388
{5805A705-ADB3-4888-A244-4AAB86A1005D}.Release|x64.ActiveCfg = Release|Any CPU
@@ -405,7 +398,6 @@ Global
405398
{F9BD47F5-4AA3-4BA3-91F2-2AC7B270299C}.Release|x64.Build.0 = Release|x64
406399
{F9BD47F5-4AA3-4BA3-91F2-2AC7B270299C}.Release|x86.ActiveCfg = Release|x64
407400
{F9BD47F5-4AA3-4BA3-91F2-2AC7B270299C}.Release-EDSS|x64.ActiveCfg = Release|x64
408-
{F9BD47F5-4AA3-4BA3-91F2-2AC7B270299C}.Release-EDSS|x64.Build.0 = Release|x64
409401
{F9BD47F5-4AA3-4BA3-91F2-2AC7B270299C}.Release-EDSS|x86.ActiveCfg = Release|x64
410402
{F9BD47F5-4AA3-4BA3-91F2-2AC7B270299C}.Release-EDSS-MSI|x64.ActiveCfg = Release|x64
411403
{F9BD47F5-4AA3-4BA3-91F2-2AC7B270299C}.Release-EDSS-MSI|x86.ActiveCfg = Release|x64
@@ -433,7 +425,6 @@ Global
433425
{14903B1E-26A7-4B57-B67C-5AB5BB4C1598}.Release-EDSS|x86.ActiveCfg = Release|Win32
434426
{14903B1E-26A7-4B57-B67C-5AB5BB4C1598}.Release-EDSS-MSI|x64.ActiveCfg = Release|x64
435427
{14903B1E-26A7-4B57-B67C-5AB5BB4C1598}.Release-EDSS-MSI|x86.ActiveCfg = Release|Win32
436-
{14903B1E-26A7-4B57-B67C-5AB5BB4C1598}.Release-EDSS-MSI|x86.Build.0 = Release|Win32
437428
{2E571D96-1196-45D4-AE13-F05CEB1F23C8}.Debug|x64.ActiveCfg = Debug|x64
438429
{2E571D96-1196-45D4-AE13-F05CEB1F23C8}.Debug|x64.Build.0 = Debug|x64
439430
{2E571D96-1196-45D4-AE13-F05CEB1F23C8}.Debug|x86.ActiveCfg = Debug|Win32
@@ -447,7 +438,6 @@ Global
447438
{2E571D96-1196-45D4-AE13-F05CEB1F23C8}.Release-EDSS|x86.ActiveCfg = Release|Win32
448439
{2E571D96-1196-45D4-AE13-F05CEB1F23C8}.Release-EDSS-MSI|x64.ActiveCfg = Release|x64
449440
{2E571D96-1196-45D4-AE13-F05CEB1F23C8}.Release-EDSS-MSI|x86.ActiveCfg = Release|Win32
450-
{2E571D96-1196-45D4-AE13-F05CEB1F23C8}.Release-EDSS-MSI|x86.Build.0 = Release|Win32
451441
EndGlobalSection
452442
GlobalSection(SolutionProperties) = preSolution
453443
HideSolutionNode = FALSE

0 commit comments

Comments
 (0)