strcpy_s causes too many problems, use strncpy_s

Author: planetchili

IntelPresentMon/CommonUtilities/cli/CliFramework.cpp

@@ -56,7 +56,7 @@ namespace pmon::util::cli
 		for (auto pWideStr : std::span{ wargv, size_t(argc) }) {
 			const auto narrow = str::ToNarrow(pWideStr);
 			auto pNarrowStr = new char[narrow.size() + 1];
-			strcpy_s(pNarrowStr, narrow.size() + 1, narrow.c_str());
+			strncpy_s(pNarrowStr, narrow.size() + 1, narrow.c_str(), _TRUNCATE);
 			stringPointerArray.push_back(pNarrowStr);
 		}
 	}

IntelPresentMon/Interprocess/source/IntrospectionTransfer.h

@@ -51,7 +51,7 @@ namespace pmon::ipc::intro
 			const auto bufferSize = buffer_.size() + 1;
 			content.pData = charAlloc.allocate(bufferSize);
 			if (content.pData) {
-				strcpy_s(const_cast<char*>(content.pData), bufferSize, buffer_.c_str());
+				strncpy_s(const_cast<char*>(content.pData), bufferSize, buffer_.c_str(), _TRUNCATE);
 			}
 			// emplace to allocated self
 			if (pSelf) {

IntelPresentMon/PresentMonMiddleware/ConcreteMiddleware.cpp

@@ -899,7 +899,7 @@ static void ReportMetrics(
         {
         case PM_METRIC_CPU_NAME:
         {
-            strcpy_s(reinterpret_cast<char*>(&pBlob[blobOffset]), sizeInBytes, cachedCpuInfo[0].deviceName.c_str());
+            strncpy_s(reinterpret_cast<char*>(&pBlob[blobOffset]), sizeInBytes, cachedCpuInfo[0].deviceName.c_str(), _TRUNCATE);
         }
             break;
         case PM_METRIC_CPU_VENDOR:
@@ -919,7 +919,7 @@ static void ReportMetrics(
             auto index = GetCachedGpuInfoIndex(deviceId);
             if (index.has_value())
             {
-                strcpy_s(reinterpret_cast<char*>(&pBlob[blobOffset]), sizeInBytes, cachedGpuInfo[index.value()].deviceName.c_str());
+                strncpy_s(reinterpret_cast<char*>(&pBlob[blobOffset]), sizeInBytes, cachedGpuInfo[index.value()].deviceName.c_str(), _TRUNCATE);
             }
         }
             break;
@@ -1122,7 +1122,7 @@ static void ReportMetrics(
         switch (element.metric)
         {
         case PM_METRIC_APPLICATION:
-            strcpy_s(reinterpret_cast<char*>(&pBlob[element.dataOffset]), 260, swapChain.mLastPresent.application);
+            strncpy_s(reinterpret_cast<char*>(&pBlob[element.dataOffset]), 260, swapChain.mLastPresent.application, _TRUNCATE);
             break;
         case PM_METRIC_PRESENT_MODE:
             reinterpret_cast<PM_PRESENT_MODE&>(pBlob[element.dataOffset]) = (PM_PRESENT_MODE)swapChain.mLastPresent.PresentMode;

IntelPresentMon/PresentMonMiddleware/FrameEventQuery.cpp

@@ -85,7 +85,7 @@ namespace
 				if constexpr (std::is_same_v<std::remove_extent_t<Type>, char>) {
 					const auto val = (ctx.pSourceFrameData->*pSubstruct.*pMember)[inputIndex_];
 					// TODO: only getting first character of application name. Hmmm.
-					strcpy_s(reinterpret_cast<char*>(&pDestBlob[outputOffset_]), 260, &val);
+					strncpy_s(reinterpret_cast<char*>(&pDestBlob[outputOffset_]), 260, &val, _TRUNCATE);
 				}
 				else {
 					const auto val = (ctx.pSourceFrameData->*pSubstruct.*pMember)[inputIndex_];

IntelPresentMon/Streamer/StreamClient.cpp

@@ -318,12 +318,12 @@ void StreamClient::CopyFrameData(uint64_t start_qpc,
                        src_frame->present_event.last_present_qpc,
                    GetQpcFrequency());
 
-  strcpy_s(dst_frame->application, src_frame->present_event.application);
+  strncpy_s(dst_frame->application, src_frame->present_event.application, _TRUNCATE);
 
   dst_frame->process_id = src_frame->present_event.ProcessId;
   dst_frame->swap_chain_address = src_frame->present_event.SwapChainAddress;
-  strcpy_s(dst_frame->runtime,
-           RuntimeToString(src_frame->present_event.Runtime));
+  strncpy_s(dst_frame->runtime,
+           RuntimeToString(src_frame->present_event.Runtime), _TRUNCATE);
   dst_frame->sync_interval = src_frame->present_event.SyncInterval;
   dst_frame->present_flags = src_frame->present_event.PresentFlags;
 

IntelPresentMon/Versioning/PresentMonAPIVersion.cpp

@@ -12,7 +12,7 @@ namespace pmon::bid
 			.patch = 0,
 			.tag = "beta",
 		};
-		strcpy_s(ver.hash, BuildIdShortHash());
+		strncpy_s(ver.hash, BuildIdShortHash(), _TRUNCATE);
 		return ver;
 	}
 }