Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architectural decisions with new CSAF #130

Open
7 tasks
podhrmic opened this issue Oct 6, 2021 · 3 comments
Open
7 tasks

Architectural decisions with new CSAF #130

podhrmic opened this issue Oct 6, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@podhrmic
Copy link
Collaborator

podhrmic commented Oct 6, 2021

Features to import/discuss:

  • where should the examples live / repo structure
  • separate the scheduler and the communication mechanism.
  • RosMsgs
  • ZMQ
  • Compatibility with external hardware and software processes
  • Native support for C language executables
  • What should be cut/preserved from the image below?
    Screenshot from 2021-10-19 11-45-22
@podhrmic podhrmic added the enhancement New feature or request label Oct 6, 2021
@podhrmic podhrmic added this to the Final Project Closeout milestone Oct 6, 2021
@EthanJamesLew
Copy link

Some thoughts here:

What should be cut/preserved from the image below?

Nothing, all those pathways still apply

ZMQ

Nothing is interesting about zmq in and of itself. Having component accessible through networking would be the thing lost and we should regain. I would argue that the original CSAF did that so poorly it's something of a moot point.

update claims about using foreign (non-python) components, maybe provide an example

We had no examples previously, and so all of our previous claims were vague.

Native support for C language executables

I would love to see this

RosMsgs

We should go beyond just RosMsgs and go into full ROS components, launch descriptions, and bags. This oversight was caused by my not learning ROS appreciably before the initial implementation.

@zutshi
Copy link
Collaborator

zutshi commented Nov 1, 2021

I would re-state the features as requirements instead:

  • Compatibility with ROS Components: allowing import and export of components from and to the ROS v2 ecosystem.
  • Modular: We should separate the scheduler and the communication mechanism.
  • Platform agnostic vs Performance tradeoff
  • DevOps style structure: CI/CD

@podhrmic podhrmic changed the title Fully integrate new CSAF Architectural decisions with new CSAF Nov 2, 2021
@cslockett
Copy link
Collaborator

For Aditya to finalize these decisions

@cslockett cslockett removed this from the Final Project Closeout milestone Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants