Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop if trace is too short in time #18

Open
Axel-Reactor opened this issue Oct 24, 2024 · 0 comments
Open

Infinite loop if trace is too short in time #18

Axel-Reactor opened this issue Oct 24, 2024 · 0 comments

Comments

@Axel-Reactor
Copy link

Axel-Reactor commented Oct 24, 2024

For very short traces, TimelineModel::UpdateMemoryGraph sets bucket_step to <1:
double bucket_step = duration / (double)kNumBuckets;

This then gets cast into an uint64_t and truncated to just 0 when passed to RmtDataTimelineCreateHistogram which then asserts:
RMT_ASSERT_MESSAGE(bucket_width_in_rmt_cycles > 0, "Parameter bucketWidthInCycles must be larger than 0 cycles.");

And then later CreateHistogramJob just loops forever here:
for (int32_t current_series_index = 0; current_series_index < input_parameters->timeline->series_count; ++current_series_index)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant