Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for bufferDeviceAddressCaptureReplay feature of VK_KHR_buffer_device_address (for RenderDoc 1.36 raytracing capture support).. #390

Open
oscarbg opened this issue Dec 24, 2024 · 4 comments

Comments

@oscarbg
Copy link

oscarbg commented Dec 24, 2024

Hi,
new Renderdoc 1.36 adds support for "Raytracing capture" of both DX12 and Vulkan programs..
see "Raytracing capture" chapter in https://github.com/baldurk/renderdoc/releases/tag/v1.36 ..
I have been testing with both samples:

https://github.com/KhronosGroup/Vulkan-Samples/tree/main/samples/extensions/ray_tracing_basic
https://github.com/KhronosGroup/Vulkan-Samples/tree/main/samples/extensions/ray_queries

both samples run ok with AMDVLK 2024.q4.3:

./vulkan_samples sample raytracing_basic
./vulkan_samples sample ray_queries

but both fail to capture:
for example on Renderdoc 1.35 trying to capture "raytracing_basic" it failed with:

[error] [framework/core/device.cpp:155] Required device extension VK_KHR_deferred_host_operations not available, cannot run
[error] [framework/core/device.cpp:155] Required device extension VK_KHR_buffer_device_address not available, cannot run
[error] [framework/core/device.cpp:155] Required device extension VK_KHR_ray_tracing_pipeline not available, cannot run
[error] [framework/core/device.cpp:155] Required device extension VK_KHR_acceleration_structure not available, cannot run
[error] [framework/platform/platform.cpp:149] Error Message: Extensions not present : ERROR_EXTENSION_NOT_PRESENT
[error] [framework/platform/platform.cpp:150] Failed when running application raytracing_basic

with 1.36 fails with :

[error] [framework/core/device.cpp:155] Required device extension VK_KHR_buffer_device_address not available, cannot run
[error] [framework/platform/platform.cpp:149] Error Message: Extensions not present : ERROR_EXTENSION_NOT_PRESENT
[error] [framework/platform/platform.cpp:150] Failed when running application raytracing_basic

this is due to needing support from AMDVLK for "bufferDeviceAddressCaptureReplay" feature of VK_KHR_buffer_device_address..

@oscarbg
Copy link
Author

oscarbg commented Dec 24, 2024

this is my report showing no support for it:
https://vulkan.gpuinfo.org/displayreport.php?id=35585#features_extensions
Nvidia for example supports bufferDeviceAddressCaptureReplay..

@jinjianrong
Copy link
Member

@oscarbg what GPU are you using? bufferDeviceAddressCaptureReplay support is relying on gfxip:
https://github.com/GPUOpen-Drivers/xgl/blob/62710fd4e7ccc159a3609aa4c307a81ac0a8453c/icd/api/vk_physical_device.cpp#L5915

@oscarbg
Copy link
Author

oscarbg commented Dec 24, 2024

Gfx1036.. raphael.. zen4 igpu.. rdna2..
At least radv on this igpu exposes it..

@perlfu
Copy link
Collaborator

perlfu commented Jan 7, 2025

@jinjianrong - it's not really clear why supportCaptureReplay is disabled for GFX10 APU parts, perhaps it is to do with memory mappings on these ASICs, but I think we should probably confirm internally if it really does need to be disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants