Merge branch 'dev' into fix-2.5-rc-trezor-issues

* dev: (21 commits)
  feat(wallet-connect): impl BTC (UTxO) activation via WalletConnect (#2499)
  feat(utxo): add new fixed txfee option for DINGO-like coins (#2454)
  ci(pull-requests): review notification bot (#2468)
  improvement(walletconnect): return the `pairing_topic` in `new_connection` response (#2538)
  bless clippy (#2560)
  refactor(toolchain): use latest available stable compiler (#2557)
  feat(wallet): implement unified offline private key export API (#2542)
  improve note for docker test start failure (#2550)
  fix(DOCS): add note for macos to fix docker containers startup failure (#2544)
  refactor(toolchain): general stabilization for stable rust (#2528)
  fix(ci): adds nodejs 20 to ci-container (#2536)
  fix(WASM and Debian): fix build failures (#2534)
  improvement(event-streaming): impl DeriveStreamerId trait for all streamers (#2489)
  fix(eth): Propagate structured EIP-1559 fee errors (#2532)
  fix(eth): Correctly implement ETH max withdrawal logic (#2531)
  feat(use-clap-for-cli): use clap to parse CLI-Args #2215 (#2510)
  feat(orderbook): expirable maker orders (#2516)
  improvement(eth): drop parity support (#2527)
  chore(release): finalize changelog for v2.5.0-beta (#2524)
  chore(toolchain): upgrade toolchain to nightly 1.86.0 (#2444)
  ...

# Conflicts:
#	mm2src/coins/lp_coins.rs
#	mm2src/coins/rpc_command/get_new_address.rs
#	mm2src/trezor/src/eth/eth_command.rs

Author: dimxy

.cargo/config.toml

@@ -1,8 +1,25 @@
 [env]
+# Enables unstable features for specific crates to take advantage of useful
+# functionality not yet stabilized. Remove a crate from the list once all
+# required features are stabilized.
+#
+# # Core crates (used in production)
+#
+# - mm2_state_machine: Depends on `negative_impls` and `auto_traits`.
+# - mm2_err_handle: Depends on `negative_impls`, `auto_traits` and `allocator_api`.
+#
+# # Test crates (not leaked into the binary)
+#
+# - mocktopus: nightly only dependency.
+# - mocktopus_macros: nightly only dependency.
+# - docker_tests_main: Depends on `custom_test_frameworks` and `test`.
+# - docker_tests_sia_unique: Depends on `custom_test_frameworks` and `test`.
+RUSTC_BOOTSTRAP = "mm2_state_machine,mm2_err_handle,mocktopus,mocktopus_macros,docker_tests_main,docker_tests_sia_unique"
+
 JEMALLOC_SYS_WITH_MALLOC_CONF = "background_thread:true,narenas:1,tcache:false,dirty_decay_ms:0,muzzy_decay_ms:0,metadata_thp:auto"
 
 [target.'cfg(all())']
-rustflags = [ "-Zshare-generics=y", '--cfg=curve25519_dalek_backend="fiat"' ]
+rustflags = [ '--cfg=curve25519_dalek_backend="fiat"' ]
 
 # # Install lld using package manager
 # [target.x86_64-unknown-linux-gnu]

.docker/Dockerfile.ci-container

@@ -1,6 +1,6 @@
-FROM docker.io/debian:buster-slim
+FROM docker.io/debian:bullseye-slim
 
-MAINTAINER Onur Özkan <[email protected]>
+LABEL maintainer="Onur Özkan <[email protected]>"
 
 RUN apt-get update -y
 

.docker/Dockerfile.dev-release

@@ -1,6 +1,5 @@
 FROM docker.io/debian:stable-slim
 WORKDIR /kdf
 COPY target/release/kdf /usr/local/bin/kdf
-COPY target/release/mm2 /usr/local/bin/mm2
 EXPOSE 7783
 CMD ["kdf"]

.docker/Dockerfile.release

@@ -1,6 +1,5 @@
 FROM docker.io/debian:stable-slim
 WORKDIR /kdf
 COPY target/release/kdf /usr/local/bin/kdf
-COPY target/release/mm2 /usr/local/bin/mm2
 EXPOSE 7783
 CMD ["kdf"]

.github/actions/build-cache/action.yml

@@ -6,5 +6,10 @@ runs:
     - name: Checkout repository
       uses: actions/checkout@v3
 
+    - name: Set up Node.js
+      uses: actions/setup-node@v4
+      with:
+        node-version: '20'
+
     - name: Set up rust-cache
       uses: Swatinem/rust-cache@v2

.github/workflows/dev-build.yml

@@ -29,8 +29,8 @@ jobs:
 
       - name: Install toolchain
         run: |
-          rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal
-          rustup default nightly-2023-06-01
+          rustup toolchain install stable --no-self-update --profile=minimal
+          rustup default stable
 
       - name: Install build deps
         uses: ./.github/actions/deps-install
@@ -92,8 +92,8 @@ jobs:
       - uses: actions/checkout@v3
       - name: Install toolchain
         run: |
-          rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal
-          rustup default nightly-2023-06-01
+          rustup toolchain install stable --no-self-update --profile=minimal
+          rustup default stable
           rustup target add x86_64-apple-darwin
 
       - name: Install build deps
@@ -144,8 +144,8 @@ jobs:
       - uses: actions/checkout@v3
       - name: Install toolchain
         run: |
-          rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal
-          rustup default nightly-2023-06-01
+          rustup toolchain install stable --no-self-update --profile=minimal
+          rustup default stable
           rustup target add aarch64-apple-darwin
 
       - name: Install build deps
@@ -196,8 +196,8 @@ jobs:
       - uses: actions/checkout@v3
       - name: Install toolchain
         run: |
-          rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal
-          rustup default nightly-2023-06-01
+          rustup toolchain install stable --no-self-update --profile=minimal
+          rustup default stable
 
       - name: Install build deps
         uses: ./.github/actions/deps-install
@@ -247,8 +247,8 @@ jobs:
       - uses: actions/checkout@v3
       - name: Install toolchain
         run: |
-          rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal
-          rustup default nightly-2023-06-01
+          rustup toolchain install stable --no-self-update --profile=minimal
+          rustup default stable
           rustup target add x86_64-apple-darwin
 
       - name: Install build deps
@@ -314,8 +314,8 @@ jobs:
 
       - name: Install toolchain
         run: |
-          rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal
-          rustup default nightly-2023-06-01
+          rustup toolchain install stable --no-self-update --profile=minimal
+          rustup default stable
           rustup target add wasm32-unknown-unknown
 
       - name: Install wasm-pack
@@ -365,8 +365,8 @@ jobs:
       - uses: actions/checkout@v3
       - name: Install toolchain
         run: |
-          rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal
-          rustup default nightly-2023-06-01
+          rustup toolchain install stable --no-self-update --profile=minimal
+          rustup default stable
           rustup target add aarch64-apple-ios
 
       - name: Install build deps
@@ -427,8 +427,8 @@ jobs:
 
       - name: Install toolchain
         run: |
-          rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal
-          rustup default nightly-2023-06-01
+          rustup toolchain install stable --no-self-update --profile=minimal
+          rustup default stable
           rustup target add aarch64-linux-android
 
       - name: Install build deps
@@ -494,8 +494,8 @@ jobs:
 
       - name: Install toolchain
         run: |
-          rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal
-          rustup default nightly-2023-06-01
+          rustup toolchain install stable --no-self-update --profile=minimal
+          rustup default stable
           rustup target add armv7-linux-androideabi
 
       - name: Install build deps

.github/workflows/fmt-and-lint.yml

@@ -18,8 +18,8 @@ jobs:
 
       - name: Install toolchain
         run: |
-          rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal --component rustfmt,clippy
-          rustup default nightly-2023-06-01
+          rustup toolchain install stable --no-self-update --profile=minimal --component rustfmt,clippy
+          rustup default stable
 
       - name: Install build deps
         uses: ./.github/actions/deps-install
@@ -45,8 +45,8 @@ jobs:
       - uses: actions/checkout@v3
       - name: Install toolchain
         run: |
-          rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal --component clippy
-          rustup default nightly-2023-06-01
+          rustup toolchain install stable --no-self-update --profile=minimal --component clippy
+          rustup default stable
           rustup target add wasm32-unknown-unknown
 
       - name: Install build deps

.github/workflows/pr-lint.yml

@@ -44,13 +44,3 @@ jobs:
             echo "PR title is too long (greater than 85 characters)"
             exit 1
           fi
-
-      - name: Check PR labels
-        env:
-          LABEL_NAMES: ${{ toJson(github.event.pull_request.labels.*.name) }}
-        if: "!((contains(env.LABEL_NAMES, 'pending review') && !contains(env.LABEL_NAMES, 'in progress') && !contains(env.LABEL_NAMES, 'blocked'))
-          || (!contains(env.LABEL_NAMES, 'pending review') && contains(env.LABEL_NAMES, 'in progress') && !contains(env.LABEL_NAMES, 'blocked'))
-          || (!contains(env.LABEL_NAMES, 'pending review') && !contains(env.LABEL_NAMES, 'in progress') && contains(env.LABEL_NAMES, 'blocked')))"
-        run: |
-          echo "PR must have "exactly one" of these labels: ['status: pending review', 'status: in progress', 'status: blocked']."
-          exit 1

.github/workflows/pr-review-reminder.yml

@@ -0,0 +1,28 @@
+name: PR Review Reminder
+
+on:
+  schedule:
+    # Run at 12:00 PM everyday.
+    - cron: '0 12 * * *'
+
+jobs:
+  pr-review-reminder:
+    permissions:
+      contents: read
+      pull-requests: write
+
+    runs-on: ubuntu-latest
+    name: PR Review Reminder
+
+    steps:
+      - name: Run PR Review Reminder
+        uses: thundermiracle/review-reminder-action@224d83b90c76ac597776c79ba1f63539f0bc2795
+        with:
+          stale-days: 2
+          ignore-draft: true
+          # Don't ping people at weekends.
+          only-business-days: true
+          # 2 approvals are enough.
+          skip-approve-count: 2
+          token: "${{ secrets.GITHUB_TOKEN }}"
+          send-reminder-comment: true

.github/workflows/release-build.yml

@@ -29,8 +29,8 @@ jobs:
 
       - name: Install toolchain
         run: |
-          rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal
-          rustup default nightly-2023-06-01
+          rustup toolchain install stable --no-self-update --profile=minimal
+          rustup default stable
 
       - name: Install build deps
         uses: ./.github/actions/deps-install
@@ -87,8 +87,8 @@ jobs:
       - uses: actions/checkout@v3
       - name: Install toolchain
         run: |
-          rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal
-          rustup default nightly-2023-06-01
+          rustup toolchain install stable --no-self-update --profile=minimal
+          rustup default stable
 
       - name: Install build deps
         uses: ./.github/actions/deps-install
@@ -135,8 +135,8 @@ jobs:
       - uses: actions/checkout@v3
       - name: Install toolchain
         run: |
-          rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal
-          rustup default nightly-2023-06-01
+          rustup toolchain install stable --no-self-update --profile=minimal
+          rustup default stable
           rustup target add aarch64-apple-darwin
 
       - name: Install build deps
@@ -184,8 +184,8 @@ jobs:
       - uses: actions/checkout@v3
       - name: Install toolchain
         run: |
-          rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal
-          rustup default nightly-2023-06-01
+          rustup toolchain install stable --no-self-update --profile=minimal
+          rustup default stable
 
       - name: Install build deps
         uses: ./.github/actions/deps-install
@@ -232,8 +232,8 @@ jobs:
       - uses: actions/checkout@v3
       - name: Install toolchain
         run: |
-          rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal
-          rustup default nightly-2023-06-01
+          rustup toolchain install stable --no-self-update --profile=minimal
+          rustup default stable
           rustup target add x86_64-apple-darwin
 
       - name: Install build deps
@@ -296,8 +296,8 @@ jobs:
 
       - name: Install toolchain
         run: |
-          rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal
-          rustup default nightly-2023-06-01
+          rustup toolchain install stable --no-self-update --profile=minimal
+          rustup default stable
           rustup target add wasm32-unknown-unknown
 
       - name: Install wasm-pack
@@ -344,8 +344,8 @@ jobs:
       - uses: actions/checkout@v3
       - name: Install toolchain
         run: |
-          rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal
-          rustup default nightly-2023-06-01
+          rustup toolchain install stable --no-self-update --profile=minimal
+          rustup default stable
           rustup target add aarch64-apple-ios
 
       - name: Install build deps
@@ -403,8 +403,8 @@ jobs:
 
       - name: Install toolchain
         run: |
-          rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal
-          rustup default nightly-2023-06-01
+          rustup toolchain install stable --no-self-update --profile=minimal
+          rustup default stable
           rustup target add aarch64-linux-android
 
       - name: Install build deps
@@ -467,8 +467,8 @@ jobs:
 
       - name: Install toolchain
         run: |
-          rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal
-          rustup default nightly-2023-06-01
+          rustup toolchain install stable --no-self-update --profile=minimal
+          rustup default stable
           rustup target add armv7-linux-androideabi
 
       - name: Install build deps