Skip to content

Commit e16ef84

Browse files
authored
Merge pull request #207 from FullStackWithLawrence/next
docs cleanup
2 parents ca5b33a + 40d74d5 commit e16ef84

File tree

3 files changed

+21
-127
lines changed

3 files changed

+21
-127
lines changed

CONTRIBUTING.md

Lines changed: 0 additions & 86 deletions
This file was deleted.

SEMANTIC_VERSIONING.md

Lines changed: 0 additions & 34 deletions
This file was deleted.

doc/CONTRIBUTING.md

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
# Contributing - Developer Setup Guide
22

3-
This repository contains two distinct projects, respectively, written in
3+
This repository contains three distinct projects, respectively, written in
44

5+
- [ReactJS](#reactjs-setup)
56
- [Python](#python-setup)
67
- [Terraform](#terraform-setup)
78

@@ -15,7 +16,7 @@ As a 1-person operation this project depends heavily on GitHub Actions to automa
1516

1617
- Code linting checks, during both pre-commit as well as triggered on pushes to the main branch
1718
- Unit tests for Python, React and Terraform
18-
- Semantic releases
19+
- Semantic Version releases
1920
- version bumps from npm, PyPi and Terraform Registry
2021

2122
A typical pull request will look like the following:
@@ -26,11 +27,13 @@ A typical pull request will look like the following:
2627

2728
This project uses pre-commit as a first-pass automated code review / QC process. pre-commit runs a multitude of utilities and checks for code formatting, linting, syntax checking, and ensuring that you don't accidentally push something to GitHub which you'd later regret. Broadly speaking, these checks are aimed at minimizing the extent of commits that contain various kinds of defects and stylistic imperfections that don't belong on the main branch of the project.
2829

29-
Note that many of the pre-commit commands are actually executed by Python which in turn is calling pip-installed packages listed in requirements.txt located in the root of the repo. It therefore is important that you first create the Python virtual environment using `make init`. It also is a good idea to do a complete 'dry run' of pre-commit, to ensure that your developer environment is correctly setup:
30+
Note that many of the pre-commit commands are actually executed by Python which in turn is calling pip-installed packages listed in requirements.txt located in the root of the repo. It therefore is important that you first create the Python virtual environment using `make api-init`. It also is a good idea to do a complete 'dry run' of pre-commit, to ensure that your developer environment is correctly setup:
3031

3132
```console
3233
git pull
33-
make pre-commit
34+
make api-init
35+
pre-commit autoupdate
36+
pre-commit run --all-files
3437
```
3538

3639
Output should look similar to the following:
@@ -53,19 +56,30 @@ Note that this project leverages Dependabot for managing version numbers of all
5356

5457
```console
5558
git pull
56-
make init
59+
make api-init
5760
source venv/bin/activate
5861
```
5962

63+
## ReactJS Setup
64+
65+
Please refer to this detailed [ReactJS setup guide](./client/README.md) for how to use vite.js to initialize the ReactJS development environment.
66+
67+
Note that this project leverages Dependabot for managing version numbers of all NPM packages that are used in this project, regardless of where and how. Versions should always be up to date at the moment that you clone the repo. It therefore should never be necessary for you to manually bump package.json version numbers.
68+
69+
```console
70+
git pull
71+
make client-init
72+
```
73+
6074
## Terraform Setup
6175

62-
Please refer to this [Terraform setup guide](https://github.com/FullStackWithLawrence/aws-openai/blob/main/doc/img/TERRAFORM.md) for detailed instructions.
76+
Please refer to this [Terraform setup guide](../api/README.md) for detailed instructions.
6377

6478
Note that this project leverages Dependabot for managing version numbers of all Terraform modules that are used in this project. Versions should always be up to date at the moment that you clone the repo. It therefore should never be necessary for you to manually bump module version numbers.
6579

6680
```console
6781
git pull
68-
cd terraform
82+
cd api/terraform
6983
terraform init
7084
terraform plan
7185
terraform apply

0 commit comments

Comments
 (0)