Add type declarations to Tests (#665)

Author: GKFX

Tests/DependencyInjection/FOSOAuthServerExtensionTest.php

@@ -23,6 +23,9 @@
 
 class FOSOAuthServerExtensionTest extends \PHPUnit\Framework\TestCase
 {
+    /**
+     * @var ContainerBuilder
+     */
     private $container;
 
     public function setUp()

Tests/Form/Handler/AuthorizeFormHandlerTest.php

@@ -29,14 +29,25 @@
  */
 class AuthorizeFormHandlerTest extends \PHPUnit\Framework\TestCase
 {
+    /**
+     * @var FormInterface&\PHPUnit\Framework\MockObject\MockObject
+     */
     protected $form;
-
+    /**
+     * @var Request&\PHPUnit\Framework\MockObject\MockObject
+     */
     protected $request;
-
+    /**
+     * @var ParameterBag&\PHPUnit\Framework\MockObject\MockObject
+     */
     protected $requestQuery;
-
+    /**
+     * @var ParameterBag&\PHPUnit\Framework\MockObject\MockObject
+     */
     protected $requestRequest;
-
+    /**
+     * @var ContainerInterface&\PHPUnit\Framework\MockObject\MockObject
+     */
     protected $container;
 
     /**

Tests/Form/Type/AuthorizeFormTypeTest.php

@@ -100,6 +100,9 @@ public function testGetBlockPrefix()
         $this->assertSame('fos_oauth_server_authorize', $this->instance->getBlockPrefix());
     }
 
+    /**
+     * @return array<object>
+     */
     protected function getTypes()
     {
         return  [

Tests/Functional/AppKernel.php

@@ -41,7 +41,7 @@ public function getCacheDir()
         return sys_get_temp_dir().'/FOSOAuthServerBundle/';
     }
 
-    public function registerContainerConfiguration(LoaderInterface $loader)
+    public function registerContainerConfiguration(LoaderInterface $loader): void
     {
         $loader->load(__DIR__.'/config/config_'.$this->getEnvironment().'.yml');
     }

Tests/Functional/BootTest.php

@@ -33,6 +33,9 @@ public function testBoot($env)
         }
     }
 
+    /**
+     * @return array<mixed>
+     */
     public function getTestBootData()
     {
         return [

Tests/Functional/TestBundle/Entity/User.php

@@ -25,15 +25,19 @@ class User implements UserInterface
      * @ORM\Id
      * @ORM\Column(type="integer")
      * @ORM\GeneratedValue(strategy="AUTO")
+     *
+     * @var ?int
      */
     protected $id;
 
     /**
      * @ORM\Column(type="string")
+     *
+     * @var ?string
      */
     protected $password;
 
-    public function getId()
+    public function getId(): ?int
     {
         return $this->id;
     }
@@ -43,26 +47,27 @@ public function getRoles()
         return ['ROLE_USER'];
     }
 
-    public function getPassword()
+    public function getPassword(): ?string
     {
         return $this->password;
     }
 
-    public function setPassword($password)
+    public function setPassword(?string $password): void
     {
         $this->password = $password;
     }
 
     public function getSalt()
     {
+        return null;
     }
 
     public function getUsername()
     {
         return $this->getId();
     }
 
-    public function eraseCredentials()
+    public function eraseCredentials(): void
     {
     }
 }

Tests/Functional/TestCase.php

@@ -35,6 +35,9 @@ protected function tearDown(): void
         static::$kernel = null;
     }
 
+    /**
+     * @param array<mixed> $options
+     */
     protected static function createKernel(array $options = [])
     {
         $env = @$options['env'] ?: 'test';

Tests/Model/TokenTest.php

@@ -38,6 +38,9 @@ public function testHasExpired($expiresAt, $expect)
         $this->assertSame($expect, $token->hasExpired());
     }
 
+    /**
+     * @return array<mixed>
+     */
     public static function getTestHasExpiredData()
     {
         return [

Tests/Security/Authentification/Token/OAuthTokenTest.php

@@ -38,7 +38,7 @@ public function testSetTokenWillSetToken()
         ;
 
         $this->assertNull($this->instance->setToken($token));
-        $this->assertAttributeSame($token, 'token', $this->instance);
+        $this->assertSame($token, $this->instance->getToken());
     }
 
     public function testGetTokenWillReturnToken()

Tests/Security/Firewall/OAuthListenerTest.php

@@ -23,12 +23,24 @@
 
 class OAuthListenerTest extends TestCase
 {
+    /**
+     * @var OAuth2&\PHPUnit\Framework\MockObject\MockObject
+     */
     protected $serverService;
 
+    /**
+     * @var AuthenticationManagerInterface&\PHPUnit\Framework\MockObject\MockObject
+     */
     protected $authManager;
 
+    /**
+     * @var mixed&\PHPUnit\Framework\MockObject\MockObject
+     */
     protected $securityContext;
 
+    /**
+     * @var RequestEvent&\PHPUnit\Framework\MockObject\MockObject
+     */
     protected $event;
 
     public function setUp()