-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change text color #444 to #222 #58
Comments
Change default text color from #444 -> #222 per Issue #58
@DeniseColbert Change available for Review/QA at https://test2.freeukgenealogy.org.uk/ |
@DeniseColbert If the gamma settings on your monitor aren't properly set there may be no perceivable difference - given the scale and width of the font, true black would have the best readability. A Photoshop point sample (or right-click on paragraph and select "Inspect element" in Chrome) will confirm the change: |
Thanks for that Gray, I calibrated my colour settings and now I can see the difference (my laptop screen resolution isn't great so I should have checked on the desktop anyway). |
@DeniseColbert The imperceivable difference for non-calibrated monitors is going to remain a readability issue for (probably) most users who've historically had difficulty reading site text - shall we switch to true black? |
I agree, but I know that we've done a lot of work on the colours in light of our accessibility review by an external agency and so I think #222 will have been considered the colour to go for. I'm having a Meet with Alison tomorrow about other design stuff so I'll ask about this and let you know. |
True black is too stark and would cause problems for anyone using the websites for a length of time (e.g. project coordinators). #222 is the darkest we can have the text without having a detrimental effect on other things. @AlOneill did find an issue a while back with our font file and how browsers were interpreting it, so, maybe we could check that aspect? Another thing to consider might be changing the text on THIS site to true black since people don't spend very long on it, compared to the others, but it's important that the text is readable (especially the Donate pages). |
@DeniseColbert The font in use is Source Sans Pro (Light) - we could switch to Source Sans Regular for better visibility without significantly altering the aesthetics (given that we have a known usability issue affecting donors, I don't think there's an argument to be made for prioritizing aesthetics over usability). Edit: There are several fallback fonts specified so browsers which can't/won't display with the primary font should still render text - if @AlOneill could explain the display issue, that'd be preferable to re-investigating. |
I like the sound of that solution, I'll make a story on the Coordination board and get Pat's thoughts. |
@DeniseColbert OK - as we have confirmed that the change was implemented (even though it may not be perceptible in some cases) can we consider this change request approved for promotion to production? |
Yes, go ahead please, @arswright. I'll open another story if/when appropriate. |
Promoted to production - closing out. |
The text colour change is showing OK, but there is a narrow (#)444 rectangle at the top of the About page (at least) — seems to be body background colour set at line 9 of _main.scss |
High priority change per @DeniseColbert in FreeUKGen/Coordination/issues/1234
The text was updated successfully, but these errors were encountered: