Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change text color #444 to #222 #58

Closed
ghost opened this issue Jun 24, 2019 · 14 comments
Closed

Change text color #444 to #222 #58

ghost opened this issue Jun 24, 2019 · 14 comments

Comments

@ghost
Copy link

ghost commented Jun 24, 2019

High priority change per @DeniseColbert in FreeUKGen/Coordination/issues/1234

@ghost ghost self-assigned this Jun 24, 2019
ghost pushed a commit that referenced this issue Jun 24, 2019
Change default text color from #444 -> #222 per Issue #58
@ghost
Copy link
Author

ghost commented Jun 24, 2019

@DeniseColbert Change available for Review/QA at https://test2.freeukgenealogy.org.uk/

@DeniseColbert
Copy link
Collaborator

Not sure if this is my eyes but I can't see a difference:
image

Will try again after sleep!

@ghost
Copy link
Author

ghost commented Jun 24, 2019

@DeniseColbert If the gamma settings on your monitor aren't properly set there may be no perceivable difference - given the scale and width of the font, true black would have the best readability.

A Photoshop point sample (or right-click on paragraph and select "Inspect element" in Chrome) will confirm the change:

190624-222_vs_444

Screenshot from 2019-06-24 14-46-07

@DeniseColbert
Copy link
Collaborator

Thanks for that Gray, I calibrated my colour settings and now I can see the difference (my laptop screen resolution isn't great so I should have checked on the desktop anyway).

@ghost
Copy link
Author

ghost commented Jun 25, 2019

@DeniseColbert The imperceivable difference for non-calibrated monitors is going to remain a readability issue for (probably) most users who've historically had difficulty reading site text - shall we switch to true black?

@DeniseColbert
Copy link
Collaborator

I agree, but I know that we've done a lot of work on the colours in light of our accessibility review by an external agency and so I think #222 will have been considered the colour to go for. I'm having a Meet with Alison tomorrow about other design stuff so I'll ask about this and let you know.

@DeniseColbert
Copy link
Collaborator

True black is too stark and would cause problems for anyone using the websites for a length of time (e.g. project coordinators). #222 is the darkest we can have the text without having a detrimental effect on other things. @AlOneill did find an issue a while back with our font file and how browsers were interpreting it, so, maybe we could check that aspect?

Another thing to consider might be changing the text on THIS site to true black since people don't spend very long on it, compared to the others, but it's important that the text is readable (especially the Donate pages).

@ghost
Copy link
Author

ghost commented Jun 26, 2019

@DeniseColbert The font in use is Source Sans Pro (Light) - we could switch to Source Sans Regular for better visibility without significantly altering the aesthetics (given that we have a known usability issue affecting donors, I don't think there's an argument to be made for prioritizing aesthetics over usability).

Edit: There are several fallback fonts specified so browsers which can't/won't display with the primary font should still render text - if @AlOneill could explain the display issue, that'd be preferable to re-investigating.

@DeniseColbert
Copy link
Collaborator

I like the sound of that solution, I'll make a story on the Coordination board and get Pat's thoughts.

@ghost
Copy link
Author

ghost commented Jun 27, 2019

@DeniseColbert OK - as we have confirmed that the change was implemented (even though it may not be perceptible in some cases) can we consider this change request approved for promotion to production?

@DeniseColbert
Copy link
Collaborator

Yes, go ahead please, @arswright. I'll open another story if/when appropriate.

@ghost
Copy link
Author

ghost commented Jun 28, 2019

Promoted to production - closing out.

@ghost ghost closed this as completed Jun 28, 2019
@AlOneill AlOneill reopened this Jul 1, 2019
@AlOneill
Copy link
Collaborator

AlOneill commented Jul 1, 2019

The text colour change is showing OK, but there is a narrow (#)444 rectangle at the top of the About page (at least) — seems to be body background colour set at line 9 of _main.scss

@ghost
Copy link
Author

ghost commented Jul 1, 2019

@AlOneill Unrelated issue prioritized in #33

@ghost ghost closed this as completed Jul 1, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants