Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closing assignment does not free up images even if they were not transcribed #176

Open
dreams-togo opened this issue Jan 29, 2025 · 2 comments
Assignees
Labels
bug Something isn't working FreeREG stsccfr TEST

Comments

@dreams-togo
Copy link
Collaborator

dreams-togo commented Jan 29, 2025

Create an assignment and go to transcribe page, then without transcribing anything go back to the transcription home page. Close the transcription package. Then go back to manage assignments page and close the assignment. Then create a new assignment using Local PC images and select the same images. FreeComETT will show an error window saying the images are already part of the now-closed assignment and so will be removed from the current assignment.

@dreams-togo
Copy link
Collaborator Author

freeregdev said: In FreeCOMETT FreeREG there is a 1:1 connection between an Assignment and a Transcription Package (TP).
Closing a TP or an assignment is a soft close. The record still exists in the DB but it is marked as closed.
A closed assignment or TP can be reopened.

  1. when closing a TP, should the associated assignment be automatically closed? Yes
  2. same question if closing an assignment? Yes
  3. if no records have been transcribed, what are the actions to take?
    3a) close the TP and the assignment
    3b) remove any images that may exist against the assignment
    3c) rather than soft closing, should a hard delete be applied since no records have been transcribed. ie it is as if the assignment and TP never existed.
  4. if records have been transcribed but they have not been uploaded, what happens?
    4a) soft close only for both assignment and TP.
    4b) retention of detail records
    4c) retention of any images from which records have been transcribed (FreeComETT has no way of knowing whether all records from an image have been transcribed, only whether some records from the image have been transcribed.
    4d) deletion of any images that have not been transcribed.
    4e) or as per 3). ie get rid of everything.
  5. if records have been transcribed and uploaded? This is 'normal' behaviour. The assignment and TP can be reopened for corrections to be made and a new upload can be performed.
    5a) soft close only
    5b) all data retained.

@stsccfr
Copy link
Collaborator

stsccfr commented Jan 30, 2025

Although we have a 1:1 connection between Assignment and Transcription Package, the notion of a TP is foreign to FreeREG and there's a lot of bookkeeping associated with it, so the more the TP can be hidden from FreeREG users, the better. In FreeBMD an assignment appears to be quite formal, while in in FreeREG it's the CSV file that is the focus of attention. From a FreeREG perspective, what we are calling the Assignment Creation screen is really just the CSV header creation screen. With this in mind, and also keeping in mind the fact that having more than one assignment at any one time will be quite seldom, my responses to the questions posed above are:

  1. and 2) I agree that closing an assignment should close the TP, and closing the TP should close the assignment. But currently, if I close the TP and then go back to the Assignments page, the associated assignment is still listed, which is unexpected. If the TP can be hidden from me, then the only action I can take is to close the assignment and there's no confusion.

  2. Do a hard delete of the TP and the assignment record as if the assignment had never been created

  3. If records have been transcribed but not uploaded, issue a warning that this is the case, saying that these records will be lost if they are not uploaded. If the user confirms that they don't want to upload, then do a hard reset as in (3).

  4. [Editing what I had originally written here] For a recently created CSV that the user has just realised needs to have a few missed records added to it, it sounds OK to just reopen the assignment/TP. For CSVs whose assignments were closed long ago and which have now been changed outside of FreeComETT, I understand that FreeComETT will use the CSV as the source of truth. If reopening the old assignment/TP in order to edit the CSV isn't going to cause problems, then this is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FreeREG stsccfr TEST
Projects
None yet
Development

No branches or pull requests

2 participants