Specify C-ABI when packing

Clippy now warns about this:
error: item uses `packed` representation without ABI-qualification

Quote from clippy:

> repr(packed) by default implies repr(Rust, packed). However, this
> representation is not stable, which makes it less useful: the bulk of
> repr(packed) use cases are for interfacing with certain binary formats
> (where it needs to be repr(C, packed)) and for zero-copy deserialization
> (which needs to be stable). The best use case for repr(Rust, packed) is
> for reducing binary size

Signed-off-by: Daniel Schaefer <[email protected]>

Author: JohnAZoidberg

framework_lib/src/audio_card.rs

@@ -15,7 +15,7 @@ enum CapeCommand {
     GetVersion = 0x0103,
 }
 
-#[repr(packed)]
+#[repr(C, packed)]
 #[derive(Clone, Copy)]
 struct CapeMessage {
     _len: i16,
@@ -25,7 +25,7 @@ struct CapeMessage {
     data: [u32; CAPE_DATA_LEN],
 }
 
-#[repr(packed)]
+#[repr(C, packed)]
 #[derive(Clone, Copy)]
 struct HidCapeMessage {
     _report_id: u16,

framework_lib/src/ccgx/binary.rs

@@ -44,7 +44,7 @@ const FW_VERSION_OFFSET: usize = 0xE0;
 const SMALL_ROW: usize = 0x80;
 const LARGE_ROW: usize = 0x100;
 
-#[repr(packed)]
+#[repr(C, packed)]
 #[derive(Debug, Copy, Clone)]
 struct VersionInfo {
     base_version: u32,

framework_lib/src/ccgx/hid.rs

@@ -25,7 +25,7 @@ const FW2_START: usize = 0x0200;
 const FW1_METADATA: usize = 0x03FF;
 const FW2_METADATA: usize = 0x03FE;
 
-#[repr(packed)]
+#[repr(C, packed)]
 #[derive(Debug, Copy, Clone)]
 struct HidFirmwareInfo {
     report_id: u8,

framework_lib/src/ccgx/mod.rs

@@ -30,7 +30,7 @@ const CCG3_METADATA_OFFSET: usize = 0x40;
 const METADATA_MAGIC: u16 = u16::from_le_bytes([b'Y', b'C']); // CY (Cypress)
 const CCG8_METADATA_MAGIC: u16 = u16::from_le_bytes([b'F', b'I']); // IF (Infineon)
 
-#[repr(packed)]
+#[repr(C, packed)]
 #[derive(Debug, Copy, Clone)]
 struct CyAcdMetadata {
     /// Offset 00: Single Byte FW Checksum
@@ -64,7 +64,7 @@ struct CyAcdMetadata {
 }
 
 // TODO: Would be nice to check the checksums
-#[repr(packed)]
+#[repr(C, packed)]
 #[derive(Debug, Copy, Clone)]
 struct CyAcd2Metadata {
     /// Offset 00: App Firmware Start

framework_lib/src/esrt/mod.rs

@@ -144,7 +144,7 @@ pub fn match_guid_kind(guid: &Guid) -> FrameworkGuidKind {
     }
 }
 
-#[repr(packed)]
+#[repr(C, packed)]
 struct _Esrt {
     resource_count: u32,
     resource_count_max: u32,

framework_lib/src/smbios.rs

@@ -106,7 +106,7 @@ pub struct Smbios3 {
 }
 
 #[cfg(target_os = "freebsd")]
-#[repr(packed)]
+#[repr(C, packed)]
 pub struct Smbios {
     pub anchor: [u8; 4],
     pub checksum: u8,

framework_lib/src/uefi/mod.rs

@@ -99,7 +99,7 @@ pub fn enable_page_break() {
     }
 }
 
-#[repr(packed)]
+#[repr(C, packed)]
 pub struct Smbios {
     pub anchor: [u8; 4],
     pub checksum: u8,