Skip to content

Commit 1d66f52

Browse files
committed
refactor: update edge-to-edge implementation
1 parent 8450baa commit 1d66f52

File tree

7 files changed

+38
-33
lines changed

7 files changed

+38
-33
lines changed

app/src/main/kotlin/org/fossify/home/activities/HiddenIconsActivity.kt

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,19 +25,16 @@ class HiddenIconsActivity : SimpleActivity(), RefreshRecyclerViewListener {
2525
setContentView(binding.root)
2626
updateIcons()
2727

28-
updateEdgeToEdge(
29-
topAppBar = binding.manageHiddenIconsToolbar,
30-
scrollingView = binding.manageHiddenIconsList,
31-
)
32-
setupMaterialScrollListener(binding.manageHiddenIconsList, binding.manageHiddenIconsToolbar)
28+
setupEdgeToEdge(padBottomSystem = listOf(binding.manageHiddenIconsList))
29+
setupMaterialScrollListener(binding.manageHiddenIconsList, binding.manageHiddenIconsAppbar)
3330

3431
val layoutManager = binding.manageHiddenIconsList.layoutManager as MyGridLayoutManager
3532
layoutManager.spanCount = config.drawerColumnCount
3633
}
3734

3835
override fun onResume() {
3936
super.onResume()
40-
setupTopAppBar(binding.manageHiddenIconsToolbar, NavigationIcon.Arrow)
37+
setupTopAppBar(binding.manageHiddenIconsAppbar, NavigationIcon.Arrow)
4138
}
4239

4340
private fun updateIcons() {

app/src/main/kotlin/org/fossify/home/activities/MainActivity.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -206,13 +206,11 @@ class MainActivity : SimpleActivity(), FlingListener {
206206
override fun onResume() {
207207
super.onResume()
208208
wasJustPaused = false
209-
updateStatusbarColor(Color.TRANSPARENT)
210209

211210
with(binding.mainHolder) {
212211
onGlobalLayout {
213212
binding.allAppsFragment.root.setupViews()
214213
binding.widgetsFragment.root.setupViews()
215-
updateStatusbarColor(Color.TRANSPARENT)
216214
}
217215

218216
setOnApplyWindowInsetsListener { _, insets ->
@@ -328,7 +326,6 @@ class MainActivity : SimpleActivity(), FlingListener {
328326
super.onConfigurationChanged(newConfig)
329327
binding.allAppsFragment.root.onConfigurationChanged()
330328
binding.widgetsFragment.root.onConfigurationChanged()
331-
updateStatusbarColor(Color.TRANSPARENT)
332329
}
333330

334331
override fun onTouchEvent(event: MotionEvent?): Boolean {

app/src/main/kotlin/org/fossify/home/activities/SettingsActivity.kt

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,14 @@ class SettingsActivity : SimpleActivity() {
3434
super.onCreate(savedInstanceState)
3535
setContentView(binding.root)
3636

37-
updateEdgeToEdge(
38-
topAppBar = binding.settingsToolbar,
39-
scrollingView = binding.settingsNestedScrollview,
40-
)
41-
setupMaterialScrollListener(binding.settingsNestedScrollview, binding.settingsToolbar)
37+
setupEdgeToEdge(padBottomSystem = listOf(binding.settingsNestedScrollview))
38+
setupMaterialScrollListener(binding.settingsNestedScrollview, binding.settingsAppbar)
4239
setupOptionsMenu()
4340
}
4441

4542
override fun onResume() {
4643
super.onResume()
47-
setupTopAppBar(binding.settingsToolbar, NavigationIcon.Arrow)
44+
setupTopAppBar(binding.settingsAppbar, NavigationIcon.Arrow)
4845
refreshMenuItems()
4946

5047
setupCustomizeColors()

app/src/main/kotlin/org/fossify/home/fragments/AllAppsFragment.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ class AllAppsFragment(
235235
getAdapter()?.updateTextColor(context.getProperTextColor())
236236

237237
binding.searchBar.beVisibleIf(context.config.showSearchBar)
238-
binding.searchBar.getToolbar().beGone()
238+
binding.searchBar.requireToolbar().beGone()
239239
binding.searchBar.updateColors()
240240
binding.searchBar.setupMenu()
241241

app/src/main/res/layout/activity_hidden_icons.xml

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,26 @@
55
android:layout_width="match_parent"
66
android:layout_height="match_parent">
77

8-
<com.google.android.material.appbar.MaterialToolbar
9-
android:id="@+id/manage_hidden_icons_toolbar"
8+
<org.fossify.commons.views.MyAppBarLayout
9+
android:id="@+id/manage_hidden_icons_appbar"
1010
android:layout_width="match_parent"
11-
android:layout_height="?attr/actionBarSize"
12-
android:background="@color/color_primary"
13-
app:title="@string/hidden_icons"
14-
app:titleTextAppearance="@style/AppTheme.ActionBar.TitleTextStyle" />
11+
android:layout_height="wrap_content">
12+
13+
<com.google.android.material.appbar.MaterialToolbar
14+
android:id="@+id/manage_hidden_icons_toolbar"
15+
android:layout_width="match_parent"
16+
android:layout_height="?attr/actionBarSize"
17+
android:background="@color/color_primary"
18+
app:title="@string/hidden_icons"
19+
app:titleTextAppearance="@style/AppTheme.ActionBar.TitleTextStyle" />
20+
21+
</org.fossify.commons.views.MyAppBarLayout>
1522

1623
<RelativeLayout
1724
android:id="@+id/manage_hidden_icons_wrapper"
1825
android:layout_width="match_parent"
1926
android:layout_height="wrap_content"
20-
android:layout_marginTop="?attr/actionBarSize">
27+
app:layout_behavior="@string/appbar_scrolling_view_behavior">
2128

2229
<org.fossify.commons.views.MyRecyclerView
2330
android:id="@+id/manage_hidden_icons_list"

app/src/main/res/layout/activity_settings.xml

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,29 @@
66
android:layout_width="match_parent"
77
android:layout_height="match_parent">
88

9-
<com.google.android.material.appbar.MaterialToolbar
10-
android:id="@+id/settings_toolbar"
9+
<org.fossify.commons.views.MyAppBarLayout
10+
android:id="@+id/settings_appbar"
1111
android:layout_width="match_parent"
12-
android:layout_height="?attr/actionBarSize"
13-
android:background="@color/color_primary"
14-
app:menu="@menu/menu_settings"
15-
app:title="@string/settings"
16-
app:titleTextAppearance="@style/AppTheme.ActionBar.TitleTextStyle" />
12+
android:layout_height="wrap_content">
13+
14+
<com.google.android.material.appbar.MaterialToolbar
15+
android:id="@+id/settings_toolbar"
16+
android:layout_width="match_parent"
17+
android:layout_height="?attr/actionBarSize"
18+
android:background="@color/color_primary"
19+
app:menu="@menu/menu_settings"
20+
app:title="@string/settings"
21+
app:titleTextAppearance="@style/AppTheme.ActionBar.TitleTextStyle" />
22+
23+
</org.fossify.commons.views.MyAppBarLayout>
1724

1825
<androidx.core.widget.NestedScrollView
1926
android:id="@+id/settings_nested_scrollview"
2027
android:layout_width="match_parent"
2128
android:layout_height="wrap_content"
22-
android:layout_marginTop="?attr/actionBarSize"
2329
android:fillViewport="true"
24-
android:scrollbars="none">
30+
android:scrollbars="none"
31+
app:layout_behavior="@string/appbar_scrolling_view_behavior">
2532

2633
<LinearLayout
2734
android:id="@+id/settings_holder"

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ detektCompose = "0.4.27"
99
#Room
1010
room = "2.8.2"
1111
#Fossify
12-
commons = "5.4.0"
12+
commons = "6.0.0"
1313
#Gradle
1414
gradlePlugins-agp = "8.11.1"
1515
#build

0 commit comments

Comments
 (0)