Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail for Dolby vision videos not working #354

Closed
7 tasks done
eng3 opened this issue Nov 3, 2024 · 3 comments
Closed
7 tasks done

Thumbnail for Dolby vision videos not working #354

eng3 opened this issue Nov 3, 2024 · 3 comments
Labels
invalid This does not seem right

Comments

@eng3
Copy link

eng3 commented Nov 3, 2024

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.2.2

Affected Android/Custom ROM version

Android 14

Affected device model

Xiaomi 14 Ultra

How did you install the app?

GitHub releases

Steps to reproduce the bug

  1. Record video with Dolby vision enabled 2. Go-to gallery and view thumbnail

Expected behavior

See thumbnail

Actual behavior

Green thumbnail

Screenshots/Screen recordings

No response

Additional information

I suspect this is because dolby vision videos usually contain two video streams. One with the video and the other with the Dolby vision data which can be ignored is the player doesn't support Dolby vision. It must be reading the wrong stream? Though the Dolby vision stream is usually the second one. So I would expect that only the first one be read.

@eng3 eng3 added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Nov 3, 2024
@Aga-C
Copy link
Member

Aga-C commented Nov 3, 2024

  1. We don't have 1.2.2 version. Which version do you mean?
  2. Please attach a sample video file that doesn't work for you.

@Aga-C Aga-C added question Further information is requested waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. labels Nov 3, 2024
@eng3
Copy link
Author

eng3 commented Nov 3, 2024

Sorry, typo, 1.2.1
I'll work on getting a video sample for you

@github-actions github-actions bot removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Nov 3, 2024
@Aga-C Aga-C added the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Nov 3, 2024
@Aga-C Aga-C added invalid This does not seem right and removed bug Something is not working question Further information is requested waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. needs triage Issue is not yet ready for PR authors to take up labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This does not seem right
Projects
None yet
Development

No branches or pull requests

3 participants
@eng3 @Aga-C and others