update accessibility-role typechecking (#135)

Author: jpdriver

__tests__/src/rules/has-valid-accessibility-role-test.js

@@ -52,6 +52,13 @@ ruleTester.run('has-valid-accessibility-role', rule, {
     { code: '<TouchableOpacity accessibilityRole="text" />;' },
     { code: '<TouchableOpacity accessibilityRole="timer" />;' },
     { code: '<TouchableOpacity accessibilityRole="toolbar" />;' },
+    {
+      code: `<TouchableOpacity
+              {...restProps}
+              {...platformProps}
+              accessibilityRole={props.accessibilityRole ? 'switch' : undefined}
+            />`,
+    },
   ].map(parserOptionsMapper),
   invalid: [
     {

src/factory/valid-prop.js

@@ -35,22 +35,24 @@ const createValidPropRule = (
         if (!isExpression) {
           // ensure we are only checking literal prop values
           const attrValue = getLiteralPropValue(node);
-          let invalid = false;
+          if (attrValue !== null) {
+            let invalid = false;
 
-          if (Array.isArray(attrValue)) {
-            const validate = attrValue.map((strValue) =>
-              isOneOf(strValue, validValues)
-            );
-            invalid = validate.indexOf(false) > -1;
-          } else {
-            invalid = !isOneOf(attrValue, validValues);
-          }
+            if (Array.isArray(attrValue)) {
+              const validate = attrValue.map((strValue) =>
+                isOneOf(strValue, validValues)
+              );
+              invalid = validate.indexOf(false) > -1;
+            } else {
+              invalid = !isOneOf(attrValue, validValues);
+            }
 
-          if (invalid) {
-            context.report({
-              node,
-              message: errorMessage,
-            });
+            if (invalid) {
+              context.report({
+                node,
+                message: errorMessage,
+              });
+            }
           }
         }
       }

src/rules/has-valid-accessibility-role.js

@@ -13,6 +13,7 @@ import createValidPropRule from '../factory/valid-prop';
 const errorMessage = 'accessibilityRole must be one of defined values';
 
 const validValues = [
+  'togglebutton',
   'adjustable',
   'alert',
   'button',
@@ -36,9 +37,11 @@ const validValues = [
   'summary',
   'switch',
   'tab',
+  'tabbar',
   'tablist',
   'text',
   'timer',
+  'list',
   'toolbar',
 ];