Skip to content

Commit 5876557

Browse files
NovaBot13MrsTonedOne
authored and
FFMirrorBot
committed
[MIRROR] Disable rust version checking in tgs precompile.sh hook (#841)
* Disable rust version checking in tgs precompile.sh hook (#81319) Updates tgs/precompile.sh hook to match what is deployed on campbell. rust-lang/cargo#12654 has set a policy of setting this to be the latest version-2, which kills any kind of signal this could have ever had. cargo's subcrates like `home` are used in almost any complex rust package, so this basically sets the tone for all packages and all crates published after October 8th. A min compiler version should be based on an actual need to use a specific compiler version because of specific features that version has or bugs that version doesn't have. This is signal. Setting to some evergreen value as a matter of course is not signal, its noise. I will not subject myself nor our downstreams to such nonsense. * Disable rust version checking in tgs precompile.sh hook --------- Co-authored-by: Kyle Spier-Swenson <[email protected]>
1 parent 107a5d8 commit 5876557

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/tgs_scripts/PreCompile.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ fi
2828

2929
echo "Deploying rust-g..."
3030
git checkout "$RUST_G_VERSION"
31-
env PKG_CONFIG_ALLOW_CROSS=1 ~/.cargo/bin/cargo build --release --target=i686-unknown-linux-gnu
31+
env PKG_CONFIG_ALLOW_CROSS=1 ~/.cargo/bin/cargo build --ignore-rust-version --release --target=i686-unknown-linux-gnu
3232
mv target/i686-unknown-linux-gnu/release/librust_g.so "$1/librust_g.so"
3333
cd ..
3434

0 commit comments

Comments
 (0)