Skip to content

Fix: Add reset timeout option for MCP tool requests #5491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nzmarktaylor wants to merge 4 commits into
base: main
Choose a base branch
from
+13 −2
Open

Fix: Add reset timeout option for MCP tool requests #5491

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b646d8
Add reset timeout option for tool requests
nzmarktaylor Nov 18, 2025
cf039b1
Fix copy-paste error
nzmarktaylor Nov 18, 2025
3800a1d
Refactor timeout reset logic in MCPToolkit
nzmarktaylor Nov 18, 2025
fe917e2
Update packages/components/nodes/tools/MCP/core.ts
nzmarktaylor Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions packages/components/nodes/tools/MCP/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,15 @@ export class MCPToolkit extends BaseToolkit {
}

async initialize() {
if (this._tools === null) {
if (this. Tools_tools === null) {
this.client = await this.createClient()

this._tools = await this.client.request({ method: 'tools/list' }, ListToolsResultSchema)
// Check if we should reset timeout on progress (default: false to maintain existing behavior)
const resetTimeoutOnProgress = process.env.MCP_RESET_TIMEOUT_ON_PROGRESS === 'true'

this._tools = await this.client.request({ method: 'tools/list' }, ListToolsResultSchema, {
resetTimeoutOnProgress
})

this.tools = await this.get_tools()

Expand Down Expand Up @@ -138,8 +143,16 @@ export async function MCPTool({
const client = await toolkit.createClient()

try {
// Check if we should reset timeout on progress (default: false to maintain existing behavior)
const resetTimeoutOnProgress = process.env.MCP_RESET_TIMEOUT_ON_PROGRESS === 'true'

const req: CallToolRequest = { method: 'tools/call', params: { name: name, arguments: input as any } }
const res = await client.request(req, CallToolResultSchema)
const res = await client.request(req, CallToolResultSchema, {
resetTimeoutOnProgress,
// onprogress callback is required for the SDK to add progressToken to the request
// Without it, the server won't know what token to use in progress notifications
onprogress: resetTimeoutOnProgress ? () => {} : undefined
})
const content = res.content
const contentString = JSON.stringify(content)
return contentString
Expand Down