Skip to content

Updates to flx.py. #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FlixelCommunityBot opened this issue Sep 13, 2012 · 5 comments
Closed

Updates to flx.py. #42

FlixelCommunityBot opened this issue Sep 13, 2012 · 5 comments
Assignees
Labels
Milestone

Comments

@FlixelCommunityBot
Copy link

Issue #189 by: ivangonekrazy

Change to flx.py to make it more cross-platform compatible:

  • The script now generates proper file and directory paths
    for Windows, Mac, Linux.

Usability changes:

  • Print usage message if no project name is provided.
  • The project directory is created if it doesn't yet exist.
  • The comment generated in Default.css is now commented out.

Changes to make the script more "Pythonic":

  • String literals for the file templates are now just one string
    instead of a list of strings.
  • Variables in the templates are interpolated into the strings
    rather than concatenated.
@FlixelCommunityBot
Copy link
Author

#ivangonekrazy added a commit: AdamAtomic#189

@Dovyski
Copy link
Member

Dovyski commented Sep 15, 2012

I think we should get rid of flx.py.

It makes no sense to me. If we need to test something, we should have a samples or tests folder containing some code (just like Starling does), or we should have no sample/test folder at all (like FlashPunk and Away3D do, for instance).

@IQAndreas
Copy link
Member

I agree, along with build_docs.sh. They could definitely come in handy for the future, but perhaps don't belong in the main repository.

If we need to test something, we should have a samples or tests folder

I think you misunderstand. The script generates the Preloader class, the MenuState class, and the GameState class (and optionally a FlashBuilder CSS file), allowing you a quick way of starting up a new project; It may come in handy for some.

Should we:

  • Open a new FlixelCommunity repository named "FlixelUtils" or "FlixelScripts" were we can place all the helper scripts?
  • Move them to a separate folder ("utils" or "scripts")?
  • Move them to a different "unattached" branch?
  • Or leave them where they are?

@Dovyski
Copy link
Member

Dovyski commented Sep 16, 2012

Indeed I misunderstood. I thought it generated a testing code, not a project. I think we should move them to a separate folder ("utils" seems nice to me).

@ghost ghost assigned IQAndreas Sep 17, 2012
@moly
Copy link
Member

moly commented Sep 20, 2012

fixed in c71377b

@moly moly closed this as completed Sep 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants