chore: address PR review feedback from khvn26

- Rename `string_value` field to `value` in FeatureValueSerializer
- Remove "(V1)" from operation_summary (internal detail confusing to users)
- Remove redundant doc line "Feature must belong to environment's project"
- Simplify swagger tags to just "experimental"
- Update all tests to use new `value` field name

Author: gagantrivedi

api/features/feature_states/serializers.py

@@ -63,11 +63,11 @@ class FeatureValueSerializer(serializers.Serializer):  # type: ignore[type-arg]
     type = serializers.ChoiceField(
         choices=["integer", "string", "boolean"], required=True
     )
-    string_value = serializers.CharField(required=True, allow_blank=True)
+    value = serializers.CharField(required=True, allow_blank=True)
 
     def validate(self, data: dict) -> dict:  # type: ignore[type-arg]
         value_type = data["type"]
-        string_val = data["string_value"]
+        string_val = data["value"]
 
         if value_type == "integer":
             try:
@@ -104,7 +104,7 @@ def flag_change_set(self) -> FlagChangeSet:
 
         change_set = FlagChangeSet(
             enabled=validated_data["enabled"],
-            feature_state_value=value_data["string_value"],
+            feature_state_value=value_data["value"],
             type_=value_data["type"],
             segment_id=segment_data.get("id") if segment_data else None,
             segment_priority=segment_data.get("priority") if segment_data else None,
@@ -169,15 +169,15 @@ def change_set_v2(self) -> FlagChangeSetV2:
             segment_override = SegmentOverrideChangeSet(
                 segment_id=override_data["segment_id"],
                 enabled=override_data["enabled"],
-                feature_state_value=value_data["string_value"],
+                feature_state_value=value_data["value"],
                 type_=value_data["type"],
                 priority=override_data.get("priority"),
             )
             segment_overrides.append(segment_override)
 
         change_set = FlagChangeSetV2(
             environment_default_enabled=env_default["enabled"],
-            environment_default_value=env_value_data["string_value"],
+            environment_default_value=env_value_data["value"],
             environment_default_type=env_value_data["type"],
             segment_overrides=segment_overrides,
         )

api/features/feature_states/views.py

@@ -23,7 +23,7 @@ def _check_workflow_not_enabled(environment: Environment) -> None:
 
 @swagger_auto_schema(
     method="post",
-    operation_summary="Update single feature state (V1)",
+    operation_summary="Update single feature state",
     operation_description="""
     **EXPERIMENTAL ENDPOINT** - Subject to change without notice.
 
@@ -33,16 +33,15 @@ def _check_workflow_not_enabled(environment: Environment) -> None:
 
     **Feature Identification:**
     - Use `feature.name` OR `feature.id` (mutually exclusive)
-    - Feature must belong to the environment's project
 
     **Value Format:**
-    - Always use `string_value` field (value is always a string)
+    - The `value` field is always a string representation
     - The `type` field tells the server how to parse it
     - Available types: integer, string, boolean
     - Examples:
-      - `{"type": "integer", "string_value": "42"}`
-      - `{"type": "boolean", "string_value": "true"}`
-      - `{"type": "string", "string_value": "hello"}`
+      - `{"type": "integer", "value": "42"}`
+      - `{"type": "boolean", "value": "true"}`
+      - `{"type": "string", "value": "hello"}`
 
     **Segment Priority:**
     - Optional `segment.priority` field controls ordering
@@ -64,7 +63,7 @@ def _check_workflow_not_enabled(environment: Environment) -> None:
             description="Feature state updated successfully (no content returned)"
         )
     },
-    tags=["Experimental - Feature States"],
+    tags=["experimental"],
 )  # type: ignore[misc]
 @api_view(http_method_names=["POST"])
 @permission_classes([IsAuthenticated, EnvironmentUpdateFeatureStatePermission])
@@ -99,16 +98,15 @@ def update_flag_v1(request: Request, environment_key: str) -> Response:
 
     **Feature Identification:**
     - Use `feature.name` OR `feature.id` (mutually exclusive)
-    - Feature must belong to the environment's project
 
     **Value Format:**
-    - Always use `string_value` field (value is always a string)
+    - The `value` field is always a string representation
     - The `type` field tells the server how to parse it
     - Available types: integer, string, boolean
     - Examples:
-      - `{"type": "string", "string_value": "production"}`
-      - `{"type": "integer", "string_value": "100"}`
-      - `{"type": "boolean", "string_value": "false"}`
+      - `{"type": "string", "value": "production"}`
+      - `{"type": "integer", "value": "100"}`
+      - `{"type": "boolean", "value": "false"}`
 
     **Segment Overrides:**
     - Provide array of segment override configurations
@@ -132,7 +130,7 @@ def update_flag_v1(request: Request, environment_key: str) -> Response:
             description="Feature states updated successfully (no content returned)"
         )
     },
-    tags=["Experimental - Feature States"],
+    tags=["experimental"],
 )  # type: ignore[misc]
 @api_view(http_method_names=["POST"])
 @permission_classes([IsAuthenticated, EnvironmentUpdateFeatureStatePermission])

api/tests/unit/features/feature_states/test_serializers.py

@@ -22,7 +22,7 @@ def test_get_feature_raises_error_when_environment_not_in_context(
         data={
             "feature": {"name": feature.name},
             "enabled": True,
-            "value": {"type": "string", "string_value": "test"},
+            "value": {"type": "string", "value": "test"},
         },
         context={},  # No environment
     )
@@ -50,7 +50,7 @@ def test_validate_segment_overrides_returns_empty_list() -> None:
 def test_feature_value_serializer_rejects_invalid_integer() -> None:
     # Given
     serializer = FeatureValueSerializer(
-        data={"type": "integer", "string_value": "not_a_number"}
+        data={"type": "integer", "value": "not_a_number"}
     )
 
     # When
@@ -63,7 +63,7 @@ def test_feature_value_serializer_rejects_invalid_integer() -> None:
 
 def test_feature_value_serializer_rejects_invalid_boolean() -> None:
     # Given
-    serializer = FeatureValueSerializer(data={"type": "boolean", "string_value": "yes"})
+    serializer = FeatureValueSerializer(data={"type": "boolean", "value": "yes"})
 
     # When
     is_valid = serializer.is_valid()
@@ -82,7 +82,7 @@ def test_feature_value_serializer_rejects_invalid_boolean() -> None:
                 "feature": {"name": feature.name},
                 "segment": {"id": segment_id},
                 "enabled": True,
-                "value": {"type": "string", "string_value": "test"},
+                "value": {"type": "string", "value": "test"},
             },
         ),
         (
@@ -91,13 +91,13 @@ def test_feature_value_serializer_rejects_invalid_boolean() -> None:
                 "feature": {"name": feature.name},
                 "environment_default": {
                     "enabled": True,
-                    "value": {"type": "string", "string_value": "default"},
+                    "value": {"type": "string", "value": "default"},
                 },
                 "segment_overrides": [
                     {
                         "segment_id": segment_id,
                         "enabled": True,
-                        "value": {"type": "string", "string_value": "test"},
+                        "value": {"type": "string", "value": "test"},
                     },
                 ],
             },
@@ -133,7 +133,7 @@ def test_serializer_rejects_nonexistent_segment(
                 "feature": {"name": feature.name},
                 "segment": {"id": segment_id},
                 "enabled": True,
-                "value": {"type": "string", "string_value": "test"},
+                "value": {"type": "string", "value": "test"},
             },
         ),
         (
@@ -142,13 +142,13 @@ def test_serializer_rejects_nonexistent_segment(
                 "feature": {"name": feature.name},
                 "environment_default": {
                     "enabled": True,
-                    "value": {"type": "string", "string_value": "default"},
+                    "value": {"type": "string", "value": "default"},
                 },
                 "segment_overrides": [
                     {
                         "segment_id": segment_id,
                         "enabled": True,
-                        "value": {"type": "string", "string_value": "test"},
+                        "value": {"type": "string", "value": "test"},
                     },
                 ],
             },