-
Notifications
You must be signed in to change notification settings - Fork 516
Expand file tree
/
Copy pathversioning_service.py
More file actions
550 lines (460 loc) · 18.5 KB
/
versioning_service.py
File metadata and controls
550 lines (460 loc) · 18.5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
import typing
from common.core.utils import using_database_replica
from django.db.models import Prefetch, Q, QuerySet
from django.utils import timezone
from rest_framework.exceptions import NotFound
from core.dataclasses import AuthorData
from environments.models import Environment
from features.feature_states.models import FeatureValueType
from features.models import Feature, FeatureSegment, FeatureState, FeatureStateValue
from features.versioning.dataclasses import (
FlagChangeSet,
FlagChangeSetV2,
)
from features.versioning.models import EnvironmentFeatureVersion
def get_environment_flags_queryset(
environment: Environment,
feature_name: str = None, # type: ignore[assignment]
) -> QuerySet[FeatureState]:
"""
Get a queryset of the latest live versions of an environments' feature states
"""
feature_states_list = get_environment_flags_list(environment, feature_name)
return FeatureState.objects.filter(id__in=[fs.id for fs in feature_states_list]) # type: ignore[no-any-return]
def get_environment_flags_list(
environment: Environment,
feature_name: str | None = None,
additional_filters: Q = None, # type: ignore[assignment]
additional_select_related_args: typing.Iterable[str] = None, # type: ignore[assignment]
additional_prefetch_related_args: typing.Iterable[
typing.Union[str, Prefetch[typing.Any]]
] = None, # type: ignore[assignment]
from_replica: bool = False,
) -> list[FeatureState]:
"""
Get a list of the latest committed versions of FeatureState objects that are
associated with the given environment. Can be filtered to remove segment /
identity overrides using additional_filters argument.
Note: uses a single query to get all valid versions of a given environment's
feature states. The logic to grab the latest version is then handled in python
by building a dictionary. Returns a list of FeatureState objects.
"""
return list(
get_environment_flags_dict(
environment,
feature_name,
additional_filters,
additional_select_related_args,
additional_prefetch_related_args,
from_replica=from_replica,
).values()
)
def get_environment_flags_dict(
environment: Environment,
feature_name: str | None = None,
additional_filters: Q = None, # type: ignore[assignment]
additional_select_related_args: typing.Iterable[str] = None, # type: ignore[assignment]
additional_prefetch_related_args: typing.Iterable[
typing.Union[str, Prefetch[typing.Any]]
] = None, # type: ignore[assignment]
key_function: typing.Callable[[FeatureState], tuple] = None, # type: ignore[type-arg,assignment]
from_replica: bool = False,
) -> dict[tuple | str | int, FeatureState]: # type: ignore[type-arg]
key_function = key_function or _get_distinct_key # type: ignore[truthy-function]
feature_states = _get_feature_states_queryset(
environment,
feature_name,
additional_filters,
additional_select_related_args,
additional_prefetch_related_args,
from_replica=from_replica,
)
# Build up a dictionary keyed off the relevant unique attributes as defined
# by the provided key function and only keep the highest priority feature state
# for each feature.
feature_states_dict = {} # type: ignore[var-annotated]
for feature_state in feature_states:
key = key_function(feature_state)
current_feature_state = feature_states_dict.get(key)
if not current_feature_state or feature_state > current_feature_state:
feature_states_dict[key] = feature_state
return feature_states_dict # type: ignore[return-value]
def get_current_live_environment_feature_version(
environment_id: int, feature_id: int
) -> EnvironmentFeatureVersion | None:
return ( # type: ignore[no-any-return]
EnvironmentFeatureVersion.objects.filter(
environment_id=environment_id,
feature_id=feature_id,
published_at__isnull=False,
live_from__lte=timezone.now(),
)
.order_by("-live_from")
.first()
)
def update_flag(
environment: Environment, feature: Feature, change_set: FlagChangeSet
) -> FeatureState:
if environment.use_v2_feature_versioning:
return _update_flag_for_versioning_v2(environment, feature, change_set)
else:
return _update_flag_for_versioning_v1(environment, feature, change_set)
def _update_flag_for_versioning_v2(
environment: Environment, feature: Feature, change_set: FlagChangeSet
) -> FeatureState:
from features.models import FeatureSegment, FeatureState
new_version = EnvironmentFeatureVersion.objects.create(
environment=environment,
feature=feature,
created_by=change_set.author.user,
created_by_api_key=change_set.author.api_key,
)
if change_set.segment_id is not None:
# Segment override - may or may not exist
try:
target_feature_state: FeatureState = new_version.feature_states.get(
feature_segment__segment_id=change_set.segment_id,
)
except FeatureState.DoesNotExist:
feature_segment = FeatureSegment.objects.create(
feature=feature,
segment_id=change_set.segment_id,
environment=environment,
environment_feature_version=new_version,
)
target_feature_state = FeatureState.objects.create(
feature=feature,
environment=environment,
feature_segment=feature_segment,
environment_feature_version=new_version,
enabled=change_set.enabled,
)
else:
# Environment default - always exists
target_feature_state = new_version.feature_states.get(
feature_segment__isnull=True,
identity_id=None,
)
target_feature_state.enabled = change_set.enabled
target_feature_state.save()
_update_feature_state_value(
target_feature_state.feature_state_value,
change_set.feature_state_value,
change_set.type_,
)
if change_set.segment_id is not None and change_set.segment_priority is not None:
_update_segment_priority(target_feature_state, change_set.segment_priority)
new_version.publish(
published_by=change_set.author.user,
published_by_api_key=change_set.author.api_key,
)
return target_feature_state
def _update_flag_for_versioning_v1(
environment: Environment, feature: Feature, change_set: FlagChangeSet
) -> FeatureState:
from features.models import FeatureSegment, FeatureState
if change_set.segment_id is not None:
additional_filters = Q(feature_segment__segment_id=change_set.segment_id)
else:
additional_filters = Q(feature_segment__isnull=True, identity_id__isnull=True)
latest_feature_states = get_environment_flags_dict(
environment=environment,
feature_name=feature.name,
additional_filters=additional_filters,
)
if len(latest_feature_states) == 0 and change_set.segment_id is not None:
feature_segment = FeatureSegment.objects.create(
feature=feature,
segment_id=change_set.segment_id,
environment=environment,
)
target_feature_state: FeatureState = FeatureState.objects.create(
feature=feature,
environment=environment,
feature_segment=feature_segment,
enabled=change_set.enabled,
)
else:
assert len(latest_feature_states) == 1
target_feature_state = list(latest_feature_states.values())[0]
target_feature_state.enabled = change_set.enabled
target_feature_state.save()
_update_feature_state_value(
target_feature_state.feature_state_value,
change_set.feature_state_value,
change_set.type_,
)
if change_set.segment_id is not None and change_set.segment_priority is not None:
_update_segment_priority(target_feature_state, change_set.segment_priority)
return target_feature_state
def _update_feature_state_value(
fsv: FeatureStateValue, value: str, type_: FeatureValueType
) -> None:
fsv.set_value(value, type_)
fsv.save()
def _create_segment_override(
feature: Feature,
environment: Environment,
segment_id: int,
enabled: bool,
priority: int | None,
version: EnvironmentFeatureVersion | None = None,
) -> FeatureState:
from features.models import FeatureSegment
feature_segment = FeatureSegment.objects.create(
feature=feature,
segment_id=segment_id,
environment=environment,
environment_feature_version=version,
)
if priority is not None:
feature_segment.to(priority)
segment_state: FeatureState = FeatureState.objects.create(
feature=feature,
environment=environment,
feature_segment=feature_segment,
environment_feature_version=version,
enabled=enabled,
)
return segment_state
def _update_segment_priority(feature_state: FeatureState, priority: int) -> None:
feature_segment = feature_state.feature_segment
if feature_segment:
feature_segment.to(priority)
def update_flag_v2(
environment: Environment, feature: Feature, change_set: FlagChangeSetV2
) -> None:
if environment.use_v2_feature_versioning:
_update_flag_v2_for_versioning_v2(environment, feature, change_set)
else:
_update_flag_v2_for_versioning_v1(environment, feature, change_set)
def _update_flag_v2_for_versioning_v2(
environment: Environment, feature: Feature, change_set: FlagChangeSetV2
) -> None:
new_version = EnvironmentFeatureVersion.objects.create(
environment=environment,
feature=feature,
created_by=change_set.author.user,
created_by_api_key=change_set.author.api_key,
)
env_default_state = new_version.feature_states.get(
feature_segment__isnull=True, identity_id=None
)
env_default_state.enabled = change_set.environment_default_enabled
env_default_state.save()
_update_feature_state_value(
env_default_state.feature_state_value,
change_set.environment_default_value,
change_set.environment_default_type,
)
for override in change_set.segment_overrides:
try:
segment_state = new_version.feature_states.get(
feature_segment__segment_id=override.segment_id
)
segment_state.enabled = override.enabled
segment_state.save()
_update_feature_state_value(
segment_state.feature_state_value,
override.feature_state_value,
override.type_,
)
if override.priority is not None:
_update_segment_priority(segment_state, override.priority)
except FeatureState.DoesNotExist:
segment_state = _create_segment_override(
feature=feature,
environment=environment,
segment_id=override.segment_id,
enabled=override.enabled,
priority=override.priority,
version=new_version,
)
_update_feature_state_value(
segment_state.feature_state_value,
override.feature_state_value,
override.type_,
)
new_version.publish(
published_by=change_set.author.user,
published_by_api_key=change_set.author.api_key,
)
def _update_flag_v2_for_versioning_v1(
environment: Environment, feature: Feature, change_set: FlagChangeSetV2
) -> None:
env_default_states = get_environment_flags_dict(
environment=environment,
feature_name=feature.name,
additional_filters=Q(feature_segment__isnull=True, identity_id__isnull=True),
)
assert len(env_default_states) == 1
env_default_state = list(env_default_states.values())[0]
env_default_state.enabled = change_set.environment_default_enabled
env_default_state.save()
_update_feature_state_value(
env_default_state.feature_state_value,
change_set.environment_default_value,
change_set.environment_default_type,
)
for override in change_set.segment_overrides:
# TODO: optimise this once this is out of the
# experimentation stage
segment_states = get_environment_flags_dict(
environment=environment,
feature_name=feature.name,
additional_filters=Q(feature_segment__segment_id=override.segment_id),
)
if len(segment_states) == 0:
segment_state = _create_segment_override(
feature=feature,
environment=environment,
segment_id=override.segment_id,
enabled=override.enabled,
priority=override.priority,
version=None, # V1 versioning doesn't use versions
)
_update_feature_state_value(
segment_state.feature_state_value,
override.feature_state_value,
override.type_,
)
else:
assert len(segment_states) == 1
segment_state = list(segment_states.values())[0]
segment_state.enabled = override.enabled
segment_state.save()
_update_feature_state_value(
segment_state.feature_state_value,
override.feature_state_value,
override.type_,
)
if override.priority is not None:
_update_segment_priority(segment_state, override.priority)
def delete_segment_override(
environment: "Environment",
feature: "Feature",
segment_id: int,
author: AuthorData,
) -> None:
if environment.use_v2_feature_versioning:
_delete_segment_override_v2(environment, feature, segment_id, author)
else:
_delete_segment_override_v1(environment, feature, segment_id)
def _delete_segment_override_v1(
environment: "Environment",
feature: "Feature",
segment_id: int,
) -> None:
deleted_count, _ = FeatureSegment.objects.filter(
feature=feature,
segment_id=segment_id,
environment=environment,
).delete()
if deleted_count == 0:
raise NotFound(f"Segment override for segment {segment_id} does not exist")
def _delete_segment_override_v2(
environment: "Environment",
feature: "Feature",
segment_id: int,
author: AuthorData,
) -> None:
current_version = get_current_live_environment_feature_version(
environment.id, feature.id
)
if (
not current_version
or not current_version.feature_states.filter(
feature_segment__segment_id=segment_id
).exists()
):
raise NotFound(f"Segment override for segment {segment_id} does not exist")
new_version = EnvironmentFeatureVersion.objects.create(
environment=environment,
feature=feature,
created_by=author.user,
created_by_api_key=author.api_key,
)
segment_feature_state = new_version.feature_states.get(
feature_segment__segment_id=segment_id
)
segment_feature_state.feature_segment.delete()
new_version.publish(published_by=author.user, published_by_api_key=author.api_key)
def get_updated_feature_states_for_version(
version: EnvironmentFeatureVersion,
) -> list[FeatureState]:
"""
Returns feature states that changed compared to the previous version.
"""
def get_match_key(fs: FeatureState) -> tuple[int | None, int | None]:
segment_id = fs.feature_segment.segment_id if fs.feature_segment else None
return (fs.identity_id, segment_id)
def multivariate_values_changed(
fs: FeatureState, previous_fs: FeatureState
) -> bool:
current_mv_values = {
mv.multivariate_feature_option_id: mv.percentage_allocation
for mv in fs.multivariate_feature_state_values.all()
}
previous_mv_values = {
mv.multivariate_feature_option_id: mv.percentage_allocation
for mv in previous_fs.multivariate_feature_state_values.all()
}
return current_mv_values != previous_mv_values
previous_version = version.get_previous_version()
previous_feature_states_map = (
{get_match_key(fs): fs for fs in previous_version.feature_states.all()}
if previous_version
else {}
)
changed_feature_states = []
for feature_state in version.feature_states.all():
previous_fs = previous_feature_states_map.get(get_match_key(feature_state))
if previous_fs is None or (
feature_state.enabled != previous_fs.enabled
or feature_state.get_feature_state_value()
!= previous_fs.get_feature_state_value()
or multivariate_values_changed(feature_state, previous_fs)
):
changed_feature_states.append(feature_state)
return changed_feature_states
def _get_feature_states_queryset(
environment: "Environment",
feature_name: str | None = None,
additional_filters: Q = None, # type: ignore[assignment]
additional_select_related_args: typing.Iterable[str] = None, # type: ignore[assignment]
additional_prefetch_related_args: typing.Iterable[
typing.Union[str, Prefetch[typing.Any]]
] = None, # type: ignore[assignment]
from_replica: bool = False,
) -> QuerySet[FeatureState]:
additional_select_related_args = additional_select_related_args or tuple()
additional_prefetch_related_args = additional_prefetch_related_args or tuple()
feature_state_manager = FeatureState.objects
if from_replica:
feature_state_manager = using_database_replica(FeatureState.objects)
queryset = (
feature_state_manager.get_live_feature_states(
environment=environment,
additional_filters=additional_filters,
)
.select_related(
"environment",
"feature",
"feature_state_value",
"environment_feature_version",
"feature_segment",
*additional_select_related_args,
)
.prefetch_related(*additional_prefetch_related_args)
)
if feature_name:
queryset = queryset.filter(feature__name__iexact=feature_name)
return queryset
def _get_distinct_key(
feature_state: FeatureState,
) -> tuple[int, int | None, int | None]:
return (
feature_state.feature_id,
getattr(feature_state.feature_segment, "segment_id", None),
feature_state.identity_id,
)