Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Contribution: 【Lv2】【Operator Development】argmin #318

Closed
StrongSpoon opened this issue Nov 22, 2024 · 1 comment · Fixed by #346
Closed

Code Contribution: 【Lv2】【Operator Development】argmin #318

StrongSpoon opened this issue Nov 22, 2024 · 1 comment · Fixed by #346
Assignees

Comments

@StrongSpoon
Copy link
Collaborator

StrongSpoon commented Nov 22, 2024

Description 任务介绍

Develop forward function for argmin operator.
开发argmin算子的前向功能。

Requirements 任务要求

Interface 接口
argmin(Tensor self, int? dim=None, bool keepdim=False) -> Tensor
Function reference 功能参考
https://pytorch.org/docs/stable/generated/torch.argmin.html#torch-argmin
Implementation reference 实现参考
https://github.com/FlagOpen/FlagGems/blob/master/src/flag_gems/ops/argmax.py

The operator should support all optional arguments defined in the interface.
算子应支持接口中定义的所有参数选项。

DDL 提交时间

Please submit a Pull Request within 2 weeks after accepting the assignment.
请于接取任务后两周内提交PR。
Please provide both accuracy test and performance test code.
请同时提供实现正确性测试与性能测试代码。

@StrongSpoon StrongSpoon converted this from a draft issue Nov 22, 2024
@wyjoutstanding
Copy link
Contributor

吴扬俊 认领

@wyjoutstanding wyjoutstanding mentioned this issue Dec 7, 2024
3 tasks
@Tango2018cc Tango2018cc moved this from In Progress to Review in Triton China Community Dec 9, 2024
iclementine pushed a commit that referenced this issue Jan 10, 2025
* add argmin

* support int dtype and int64 index

* add test for dim=None

* rebase master

---------

Co-authored-by: wuyangjun <[email protected]>
@github-project-automation github-project-automation bot moved this from Review to Done in Triton China Community Jan 10, 2025
Gxiandy pushed a commit to Gxiandy/FlagGems that referenced this issue Jan 12, 2025
* add argmin

* support int dtype and int64 index

* add test for dim=None

* rebase master

---------

Co-authored-by: wuyangjun <[email protected]>
DuanYaQi pushed a commit that referenced this issue Jan 21, 2025
* add argmin

* support int dtype and int64 index

* add test for dim=None

* rebase master

---------

Co-authored-by: wuyangjun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants