fix unit test errors

Author: gilsonjoanelo

src/FirebirdSql.EntityFrameworkCore.Firebird/Storage/Internal/FbSqlGenerationHelper.cs

@@ -27,19 +27,38 @@ public FbSqlGenerationHelper(RelationalSqlGenerationHelperDependencies dependenc
 		: base(dependencies)
 	{ }
 
-	public virtual string StringLiteralQueryType(string s, bool isUnicode = true, string? storeTypeNameBase = null, int? size = null)
+	public virtual string StringLiteralQueryType(string s, bool isUnicode = true, string storeTypeNameBase = "", int size = 0)
 	{
-		var length = size ?? MinimumStringQueryTypeLength(s);
+		var maxSize = MinimumStringQueryTypeLength(s);
+		string typeName;
+		if (storeTypeNameBase.Equals("BLOB SUB_TYPE TEXT", StringComparison.OrdinalIgnoreCase))
+		{
+			typeName = "VARCHAR";
+		}
+		else
+		{
+			typeName = IsEmpty(storeTypeNameBase) ? "VARCHAR" : storeTypeNameBase;
+		}
+
 		var charset = isUnicode ? " CHARACTER SET UTF8" : string.Empty;
-		var storeTypeName = storeTypeNameBase ?? "VARCHAR";
-		return $"{storeTypeName}({length}){charset}";
+		return $"{typeName}({maxSize}){charset}";
 	}
 
-	public virtual string StringParameterQueryType(bool isUnicode, string? storeTypeNameBase = null, int? size = null)
+	public virtual string StringParameterQueryType(bool isUnicode, string storeTypeNameBase = "", int size = 0)
 	{
-		var maxSize = size ?? (isUnicode ? FbTypeMappingSource.UnicodeVarcharMaxSize : FbTypeMappingSource.VarcharMaxSize);
-		var storeTypeName = storeTypeNameBase ?? "VARCHAR";
-		return $"{storeTypeName}({size})";
+		int maxSize;
+		string typeName;
+		if (storeTypeNameBase.Equals("BLOB SUB_TYPE TEXT", StringComparison.OrdinalIgnoreCase))
+		{
+			maxSize = (isUnicode ? FbTypeMappingSource.UnicodeVarcharMaxSize : FbTypeMappingSource.VarcharMaxSize);
+			typeName = "VARCHAR";
+		}
+		else
+		{
+			maxSize = size > 0 ? size : (isUnicode ? FbTypeMappingSource.UnicodeVarcharMaxSize : FbTypeMappingSource.VarcharMaxSize);
+			typeName = IsEmpty(storeTypeNameBase) ? "VARCHAR" : storeTypeNameBase;
+		}
+		return $"{typeName}({maxSize})";
 	}
 
 	public virtual void GenerateBlockParameterName(StringBuilder builder, string name)
@@ -49,17 +68,16 @@ public virtual void GenerateBlockParameterName(StringBuilder builder, string nam
 
 	public virtual string AlternativeStatementTerminator => "~";
 
-	static int MinimumStringQueryTypeLength(string s)
+	private int MinimumStringQueryTypeLength(string s)
 	{
 		var length = s?.Length ?? 0;
 		if (length == 0)
 			length = 1;
 		return length;
 	}
 
-	static void EnsureStringLiteralQueryTypeLength(int length)
+	private bool IsEmpty(string storeTypeNameBase)
 	{
-		if (length > FbTypeMappingSource.UnicodeVarcharMaxSize)
-			throw new ArgumentOutOfRangeException(nameof(length));
+		return (storeTypeNameBase == null || string.IsNullOrEmpty(storeTypeNameBase) || string.IsNullOrWhiteSpace(storeTypeNameBase));
 	}
 }

src/FirebirdSql.EntityFrameworkCore.Firebird/Storage/Internal/IFbSqlGenerationHelper.cs

@@ -22,8 +22,8 @@ namespace FirebirdSql.EntityFrameworkCore.Firebird.Storage.Internal;
 
 public interface IFbSqlGenerationHelper : ISqlGenerationHelper
 {
-	string StringLiteralQueryType(string s, bool isUnicode, string? storeTypeNameBase = null, int? size = null);
-	string StringParameterQueryType(bool isUnicode, string? storeTypeNameBase = null, int? size = null);
+	string StringLiteralQueryType(string s, bool isUnicode, string storeTypeNameBase = "", int size = 0);
+	string StringParameterQueryType(bool isUnicode, string storeTypeNameBase = "", int size = 0);
 	void GenerateBlockParameterName(StringBuilder builder, string name);
 	string AlternativeStatementTerminator { get; }
 }