Skip to content

Commit 48d52f7

Browse files
committed
[REFACTOR] UserService에서 현재 세션의 사용자정보를 파라미터로 변경
- 테스트 가능한 코드 작성을 위해 로그인된 사용자의 정보를 인자로 받는다.
1 parent 45b4f92 commit 48d52f7

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

src/test/java/com/example/whiplash/delivery/assignment/ArticleAssignerV1Test.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public void should_hasSize_0_when_filtered_everySummary() {
6565
// given
6666
User user = saveUser();
6767
user.updateSummaryLevel(SummaryLevel.SHORT);
68-
registerUserProfile(userEmail, List.of(Category.GOLD));
68+
registerUserProfile(Optional.of(userEmail), List.of(Category.GOLD));
6969
registerKeywords(new UserKeywordCreateRequest("비트코인"));
7070
registerKeywords(new UserKeywordCreateRequest("달러"));
7171

@@ -88,7 +88,7 @@ public void should_hasSize_2_when_filtered_everySummary() {
8888
// given
8989
User user = saveUser();
9090
user.updateSummaryLevel(SummaryLevel.SHORT);
91-
registerUserProfile(userEmail, List.of(Category.GOLD));
91+
registerUserProfile(Optional.of(userEmail), List.of(Category.GOLD));
9292
registerKeywords(new UserKeywordCreateRequest("비트코인"));
9393
registerKeywords(new UserKeywordCreateRequest("달러"));
9494

@@ -122,7 +122,7 @@ private void registerKeywords(UserKeywordCreateRequest keywordCreateRequest) {
122122
userService.createUserKeyword(keywordCreateRequest, Optional.of(userEmail));
123123
}
124124

125-
private User registerUserProfile(String mail, List<Category> interestCategories) {
125+
private User registerUserProfile(Optional<String> mail, List<Category> interestCategories) {
126126
return userService.registerProfile(
127127
ProfileRegisterDTO.builder()
128128
.ageRange(AgeRange.TWENTIES)

src/test/java/com/example/whiplash/user/service/UserServiceTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
import org.junit.jupiter.api.Test;
1212
import org.springframework.beans.factory.annotation.Autowired;
1313

14+
import java.util.Optional;
15+
1416
import static com.example.whiplash.user.domain.profile.AgeRange.TWENTIES;
1517
import static com.example.whiplash.user.domain.profile.InvestmentGoal.EDUCATION_FUND;
1618
import static com.example.whiplash.user.domain.profile.InvestmentLevel.BEGINNER;
@@ -48,7 +50,7 @@ void should_hasSize_1_when_register_user() {
4850
.build();
4951

5052
//when
51-
User registeredUser = userService.registerProfile(profileRegisterDTO, email);
53+
User registeredUser = userService.registerProfile(profileRegisterDTO, Optional.of(email));
5254

5355
//then
5456
assertThat(registeredUser).isNotNull()

0 commit comments

Comments
 (0)