Make `PAYMENT_FEE_BPS` configurable

[SarveshLimaye]

Currently, the PAYMENT_FEE_BPS is defined as a constant here

uint256 public constant PAYMENT_FEE_BPS = 10;

This hardcodes the payment fee at 0.1% (10 basis points), making it inflexible for future updates. If protocol fees ever need to be adjusted (e.g., increased, decreased, or set to 0), this constant would require a contract upgrade.

Suggested Solution:

Add an onlyOwner function to allow secure updates to the fee:

function setPaymentFeeBps(uint256 newFeeBps) external onlyOwner {
    require(newFeeBps <= COMMISSION_MAX_BPS, "Fee too high");
    paymentFeeBps = newFeeBps;
}

If this sounds useful, I’d be happy to contribute a PR for it.

[rjan90]

Hey @SarveshLimaye! Discussed this in sync today, and this seems like a fine addition/enhancement. Are you still up for taking this on?

[SarveshLimaye]

Hey @rjan90 . Sure would love to take this up ! Could you assign this to me ?

[rjan90]

Great! I have assigned the ticket to you now

[SarveshLimaye]

@rjan90 I noticed that PAYMENT_FEE_BPS was removed in this PR and replaced with NETWORK_FEE. Just to confirm NETWORK_FEE should be a configurable variable (e.g., via a setNetworkFee() setter function), similar to what was discussed earlier for PAYMENT_FEE_BPS right?

Please correct me if I’ve misunderstood anything!

[aarshkshah1992]

@SarveshLimaye @rjan90 As pointed out above by Sarvesh, we have replaced the percentage based PAYMENT_FEE_BPS with a flat fee. I don't imagine the flat fee anytime soon as we will most likely move to a percentage model in the next upgrade. We can punt this for now.