Skip to content

LocalTime should generate "time" schema instead of "date-time" #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jaisonpjohn opened this issue Feb 28, 2019 · 4 comments
Closed

LocalTime should generate "time" schema instead of "date-time" #105

jaisonpjohn opened this issue Feb 28, 2019 · 4 comments
Milestone

Comments

@jaisonpjohn
Copy link

When I am generating Swagger spec for a LocalTime Java Object I wanted to get
"format" : "time" instead of "format" : "date-time".
otherwise it was tripping off a codegen-from-swagger on consumer side.

I have submitted a PR for the same #104

@jaisonpjohn jaisonpjohn changed the title for a LocalTime Java Object format : time instead of date-time for a LocalTime Java Object, format : time instead of date-time Mar 1, 2019
@jaisonpjohn
Copy link
Author

@cowtowncoder When you get a chance, could you please take a look. Thanks for your time

@cowtowncoder
Copy link
Member

cowtowncoder commented May 14, 2019

@jaisonpjohn ah sorry for skipping this. Will add to my (somewhat long, arguably... :) ) W-I-P list at https://github.com/FasterXML/jackson-future-ideas/wiki/Jackson-Work-in-Progress

@jaisonpjohn
Copy link
Author

@cowtowncoder No worries, Thank you.

@cowtowncoder cowtowncoder added this to the 2.10.0 milestone May 29, 2019
@cowtowncoder cowtowncoder changed the title for a LocalTime Java Object, format : time instead of date-time LocalTime should generate "time" schema instead of "date-time" May 29, 2019
@cowtowncoder
Copy link
Member

@jaisonpjohn Finally found time to finish this: I ended up doing manual merge to get this in 2.10, and added some baseline unit testing (just for this and couple of other types). Thank you again for submitting this, it'll get in 2.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants