Comment out tests for #68, need to figure out rules wrt empty value to null handling

Author: cowtowncoder

datetime/src/test/java/com/fasterxml/jackson/datatype/jsr310/deser/ZoneIdDeserTest.java

@@ -3,6 +3,7 @@
 import java.time.ZoneId;
 import java.util.Map;
 
+import org.junit.Ignore;
 import org.junit.Test;
 
 import com.fasterxml.jackson.databind.*;
@@ -39,25 +40,6 @@ public void testSimpleZoneIdDeser() throws Exception
                 MAPPER.readValue("\"America/Anchorage\"", ZoneId.class));
     }
 
-    @Test
-    public void testZoneOffsetDeserFromEmpty() throws Exception
-    {
-        // by default, should be fine
-        assertNull(MAPPER.readValue(quote("  "), ZoneId.class));
-        // but fail if coercion illegal
-        try {
-            newMapperBuilder()
-                .disable(MapperFeature.ALLOW_COERCION_OF_SCALARS)
-                .build()
-                .readValue(quote(" "), ZoneId.class);
-            fail("Should not pass");
-        } catch (MismatchedInputException e) {
-            verifyException(e, "Cannot coerce");
-            verifyException(e, ZoneId.class.getName());
-            verifyException(e, "enable `MapperFeature.ALLOW_COERCION_OF_SCALARS`");
-        }
-    }
-    
     @Test
     public void testPolymorphicZoneIdDeser() throws Exception
     {
@@ -131,4 +113,26 @@ public void testStrictDeserializeFromEmptyString() throws Exception {
         String valueFromEmptyStr = mapper.writeValueAsString(asMap(key, ""));
         objectReader.readValue(valueFromEmptyStr);
     }
+
+    // [module-java8#68]: Was to prevent it but... conflicts with [#138]
+    @Ignore
+    @Test
+    public void testZoneOffsetDeserFromEmpty() throws Exception
+    {
+        // by default, should be fine
+        assertNull(MAPPER.readValue(quote("  "), ZoneId.class));
+        // but fail if coercion illegal
+        try {
+            newMapperBuilder()
+                .disable(MapperFeature.ALLOW_COERCION_OF_SCALARS)
+                .build()
+                .readValue(quote(" "), ZoneId.class);
+            fail("Should not pass");
+        } catch (MismatchedInputException e) {
+            verifyException(e, "Cannot coerce");
+            verifyException(e, ZoneId.class.getName());
+            verifyException(e, "enable `MapperFeature.ALLOW_COERCION_OF_SCALARS`");
+        }
+    }
+
 }

datetime/src/test/java/com/fasterxml/jackson/datatype/jsr310/deser/ZoneOffsetDeserTest.java

@@ -36,6 +36,7 @@
 import com.fasterxml.jackson.datatype.jsr310.MockObjectConfiguration;
 import com.fasterxml.jackson.datatype.jsr310.ModuleTestBase;
 
+import org.junit.Ignore;
 import org.junit.Test;
 
 public class ZoneOffsetDeserTest extends ModuleTestBase
@@ -55,26 +56,6 @@ public void testSimpleZoneOffsetDeser() throws Exception
                 READER.readValue("\"-06:30\""));
     }
 
-    @Test
-    public void testZoneOffsetDeserFromEmpty() throws Exception
-    {
-        // by default, should be fine
-        assertNull(MAPPER.readValue(quote("  "), ZoneOffset.class));
-        // but fail if coercion illegal
-        try {
-            newMapperBuilder()
-                .disable(MapperFeature.ALLOW_COERCION_OF_SCALARS)
-                .build()
-                .readerFor(ZoneOffset.class)
-                .readValue(quote(" "));
-            fail("Should not pass");
-        } catch (MismatchedInputException e) {
-            verifyException(e, "Cannot coerce");
-            verifyException(e, ZoneOffset.class.getName());
-            verifyException(e, "enable `MapperFeature.ALLOW_COERCION_OF_SCALARS`");
-        }
-    }
-    
     @Test
     public void testPolymorphicZoneOffsetDeser() throws Exception
     {
@@ -201,4 +182,25 @@ public void testStrictDeserializeFromEmptyString() throws Exception {
         objectReader.readValue(valueFromEmptyStr);
     }
 
+    // [module-java8#68]: Was to prevent it but... conflicts with [#138]
+    @Ignore
+    @Test
+    public void testZoneOffsetDeserFromEmpty() throws Exception
+    {
+        // by default, should be fine
+        assertNull(MAPPER.readValue(quote("  "), ZoneOffset.class));
+        // but fail if coercion illegal
+        try {
+            newMapperBuilder()
+                .disable(MapperFeature.ALLOW_COERCION_OF_SCALARS)
+                .build()
+                .readerFor(ZoneOffset.class)
+                .readValue(quote(" "));
+            fail("Should not pass");
+        } catch (MismatchedInputException e) {
+            verifyException(e, "Cannot coerce");
+            verifyException(e, ZoneOffset.class.getName());
+            verifyException(e, "enable `MapperFeature.ALLOW_COERCION_OF_SCALARS`");
+        }
+    }
 }

release-notes/VERSION

@@ -15,8 +15,6 @@ due to number of types.
 
 3.0.0 (not yet released)
 
-#68: Parsing of `ZoneId` should respect `ALLOW_COERCION_OF_SCALARS`
-  wrt empty String
 - Deprecate "paramater names" and "datatypes" modules as functionality
   now included directly in `jackson-databind`
 - Remove legacy `JSR310Module`