issue when fields have default values (#600)

Author: pjfanning

src/main/scala/com/fasterxml/jackson/module/scala/introspect/ScalaAnnotationIntrospectorModule.scala

@@ -170,23 +170,24 @@ object ScalaAnnotationIntrospector extends NopAnnotationIntrospector with ValueI
               // Locate the constructor param that matches it
               descriptor.properties.find(_.param.exists(_.index == creator.getCreatorIndex)) match {
                 case Some(pd) => {
-                  val mappedCreator = overrides.get(pd.name) match {
-                    case Some(refHolder) => WrappedCreatorProperty(creator, refHolder)
-                    case _ => creator
-                  }
                   if (applyDefaultValues) {
                     pd match {
                       case PropertyDescriptor(_, Some(ConstructorParameter(_, _, Some(defaultValue))), _, _, _, _, _) => {
-                        mappedCreator.withNullProvider(new NullValueProvider {
+                        val updatedCreator = creator.withNullProvider(new NullValueProvider {
                           override def getNullValue(ctxt: DeserializationContext): AnyRef = defaultValue()
-
                           override def getNullAccessPattern: AccessPattern = AccessPattern.DYNAMIC
                         })
+                        updatedCreator match {
+                          case cp: CreatorProperty => applyOverrides(cp, pd.name, overrides)
+                          case cp => cp
+                        }
+                      }
+                      case _ => {
+                        applyOverrides(creator, pd.name, overrides)
                       }
-                      case _ => mappedCreator
                     }
                   } else {
-                    mappedCreator
+                    applyOverrides(creator, pd.name, overrides)
                   }
                 }
                 case _ => creator
@@ -204,6 +205,14 @@ object ScalaAnnotationIntrospector extends NopAnnotationIntrospector with ValueI
     }
   }
 
+  private def applyOverrides(creator: CreatorProperty, propertyName: String,
+                             overrides: Map[String, ClassHolder]): CreatorProperty = {
+    overrides.get(propertyName) match {
+      case Some(refHolder) => WrappedCreatorProperty(creator, refHolder)
+      case _ => creator
+    }
+  }
+
   override def findValueInstantiator(config: DeserializationConfig, beanDesc: BeanDescription,
                                      defaultInstantiator: ValueInstantiator): ValueInstantiator = {
 

src/test/scala/com/fasterxml/jackson/module/scala/deser/OptionWithNumberDeserializerTest.scala

@@ -60,8 +60,8 @@ class OptionWithNumberDeserializerTest extends DeserializerTest with BeforeAndAf
   it should "deserialize OptionLongWithDefault when registerReferencedValueType is used" in {
     ScalaAnnotationIntrospectorModule.registerReferencedValueType(classOf[OptionLongWithDefault], "valueLong", classOf[Long])
     try {
-      val v1 = deserialize("""{"valueLong":151}""", classOf[OptionLong])
-      v1 shouldBe OptionLong(Some(151L))
+      val v1 = deserialize("""{"valueLong":151}""", classOf[OptionLongWithDefault])
+      v1 shouldBe OptionLongWithDefault(Some(151L))
       v1.valueLong.get shouldBe 151L
       //this next call will fail with a Scala unboxing exception unless you call ScalaAnnotationIntrospectorModule.registerReferencedValueType
       //or use one of the equivalent classes in OptionWithNumberDeserializerTest