Skip to content

GradleTest fails alleging an issue with jackson-bom version 2.15.0-rc1 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cowtowncoder opened this issue Mar 22, 2023 · 8 comments
Closed

Comments

@cowtowncoder
Copy link
Member

So, after publishing 2.15.0-rc1, GradleTest started failing with:

[ERROR] Failures: 
[ERROR]   GradleTest.testJacksonBomDependency:36->build:64 FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkMetadata'.
> Missing dependency to 'jackson-bom'. Gradle Metadata publishing is most likely broken:
    - com.fasterxml.jackson.core:jackson-core:2.15.0-rc1

At first I was wondering if that might be due to:

FasterXML/jackson-core#955

but after upgrading (just to be sure), via #17 failure persists. Perhaps that's just due to oddities of handling of (Pre-)Release Candidates, version number. Or maybe I made some mistake in publishing. But would be good to figure out.

@cowtowncoder
Copy link
Member Author

@jjohannes I was wondering if you had an idea of what is the problem here?

@jjohannes
Copy link
Contributor

@cowtowncoder happy to check. The issue is valid. Which shows, at least, that this test is useful to some degree. Maybe we could print a more actionable message though.

Two things to check in such a case:

I am pretty sure it is the same problem as with jackson-module-afterburner. Here the shade plugin was added in core that rewrites the pom and removes the comment:
FasterXML/jackson-core#843

We can do the same fix in the core pom.xml as here:
FasterXML/jackson-modules-base@6df8246#diff-679477445fa9271ed890643e4b1e942bd43356a47c02f6e98e908d1538969787

@cowtowncoder
Copy link
Member Author

cowtowncoder commented Mar 23, 2023

Ah! Yes, that makes sense. Should have remembered... I'll have a look at this tomorrow, hope we can get it fixed for 2.15.0-rc2.

And yes, improved message would always be a nice improvement. Although at least now I have better idea what to look for (which is pretty obvious in hindsight -- I should have been able to figure it out).

@cowtowncoder
Copy link
Member Author

Fixed via FasterXML/jackson-core#966 I hope.
Will leave open until we can publish 2.15.0-rc2

@cowtowncoder
Copy link
Member Author

2.15.0-rc2 was released, no longer failing, closing.

@cowtowncoder
Copy link
Member Author

With Jackson 2.15.1 release (https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.15.1), getting closer to getting GradleTest.testJacksonBomDependency to pass -- mr-bean module the lone problem (due to shading of ASM):

[ERROR] Failures: 
[ERROR]   GradleTest.testJacksonBomDependency:36->build:64 FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkMetadata'.
> Dependencies of com.fasterxml.jackson.module:jackson-module-mrbean:2.15.1 are wrong in Gradle Metadata:
    POM:    com.fasterxml.jackson.core:jackson-core:2.15.1, com.fasterxml.jackson.core:jackson-databind:2.15.1, org.ow2.asm:asm:9.4
    Gradle: com.fasterxml.jackson.core:jackson-core:2.15.1, com.fasterxml.jackson.core:jackson-databind:2.15.1

@jjohannes
Copy link
Contributor

Good to hear that the issue with core is fixed in 2.15.1 👍

Regarding mrbean: was this just some timing issue with the releases and this will be fine in 2.16? Or is it unclear why this problem still exists?

@cowtowncoder
Copy link
Member Author

cowtowncoder commented May 17, 2023

@jjohannes I think it's a real problem, need to fix project definition in pom.xml similar to how Afterburner was changed. I forget what specifically is involved; or why it wasn't included as a failure earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants