Skip to content

Commit 80e442f

Browse files
committed
Issue 6, MultiMap deserializer fix
Moving the testcases to the right test class
1 parent bf329cb commit 80e442f

File tree

2 files changed

+41
-40
lines changed

2 files changed

+41
-40
lines changed

guava/src/test/java/com/fasterxml/jackson/datatype/guava/TestMultimaps.java

+41
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import com.fasterxml.jackson.annotation.*;
44
import com.fasterxml.jackson.core.type.TypeReference;
5+
import com.fasterxml.jackson.databind.DeserializationFeature;
56
import com.fasterxml.jackson.databind.ObjectMapper;
67
import com.fasterxml.jackson.datatype.guava.pojo.AddOp;
78
import com.fasterxml.jackson.datatype.guava.pojo.MathOp;
@@ -309,4 +310,44 @@ public void testPolymorphicValue() throws IOException {
309310
ImmutableMultimapWrapper output = MAPPER.readValue(json, ImmutableMultimapWrapper.class);
310311
assertEquals(input, output);
311312
}
313+
314+
public void testFromSingleValue() throws Exception
315+
{
316+
ObjectMapper mapper = mapperWithModule()
317+
.enable(DeserializationFeature.ACCEPT_SINGLE_VALUE_AS_ARRAY);
318+
SampleMultiMapTest sampleTest = mapper.readValue("{\"map\":{\"test\":\"value\"}}",
319+
new TypeReference<SampleMultiMapTest>() { });
320+
321+
assertEquals(1, sampleTest.map.get("test").size());
322+
}
323+
324+
public void testFromMultiValueWithSingleValueOptionEnabled() throws Exception
325+
{
326+
ObjectMapper mapper = mapperWithModule()
327+
.enable(DeserializationFeature.ACCEPT_SINGLE_VALUE_AS_ARRAY);
328+
329+
SampleMultiMapTest sampleTest = mapper.readValue("{\"map\":{\"test\":\"val\",\"test1\":[\"val1\",\"val2\"]}}",
330+
new TypeReference<SampleMultiMapTest>() { });
331+
332+
assertEquals(1, sampleTest.map.get("test").size());
333+
assertEquals(2, sampleTest.map.get("test1").size());
334+
335+
}
336+
337+
public void testFromMultiValueWithNoSingleValueOptionEnabled() throws Exception
338+
{
339+
ObjectMapper mapper = mapperWithModule();
340+
341+
SampleMultiMapTest sampleTest = mapper.readValue("{\"map\":{\"test\":[\"val\"],\"test1\":[\"val1\",\"val2\"]}}",
342+
new TypeReference<SampleMultiMapTest>() { });
343+
344+
assertEquals(1, sampleTest.map.get("test").size());
345+
assertEquals(2, sampleTest.map.get("test1").size());
346+
347+
}
348+
349+
//Sample class for testing multimaps single value option
350+
static class SampleMultiMapTest {
351+
public HashMultimap<String, String> map;
352+
}
312353
}

guava/src/test/java/com/fasterxml/jackson/datatype/guava/TestMultisets.java

-40
Original file line numberDiff line numberDiff line change
@@ -125,44 +125,4 @@ public void testFromSingle() throws Exception
125125
assertEquals(1, set.size());
126126
assertTrue(set.contains("abc"));
127127
}
128-
129-
public void testFromSingleValue() throws Exception
130-
{
131-
ObjectMapper mapper = mapperWithModule()
132-
.enable(DeserializationFeature.ACCEPT_SINGLE_VALUE_AS_ARRAY);
133-
SampleMultiMapTest sampleTest = mapper.readValue("{\"map\":{\"test\":\"value\"}}",
134-
new TypeReference<SampleMultiMapTest>() { });
135-
136-
assertEquals(1, sampleTest.map.get("test").size());
137-
}
138-
139-
public void testFromMultiValueWithSingleValueOptionEnabled() throws Exception
140-
{
141-
ObjectMapper mapper = mapperWithModule()
142-
.enable(DeserializationFeature.ACCEPT_SINGLE_VALUE_AS_ARRAY);
143-
144-
SampleMultiMapTest sampleTest = mapper.readValue("{\"map\":{\"test\":\"val\",\"test1\":[\"val1\",\"val2\"]}}",
145-
new TypeReference<SampleMultiMapTest>() { });
146-
147-
assertEquals(1, sampleTest.map.get("test").size());
148-
assertEquals(2, sampleTest.map.get("test1").size());
149-
150-
}
151-
152-
public void testFromMultiValueWithNoSingleValueOptionEnabled() throws Exception
153-
{
154-
ObjectMapper mapper = mapperWithModule();
155-
156-
SampleMultiMapTest sampleTest = mapper.readValue("{\"map\":{\"test\":[\"val\"],\"test1\":[\"val1\",\"val2\"]}}",
157-
new TypeReference<SampleMultiMapTest>() { });
158-
159-
assertEquals(1, sampleTest.map.get("test").size());
160-
assertEquals(2, sampleTest.map.get("test1").size());
161-
162-
}
163-
164-
//Sample class for testing multimaps single value option
165-
static class SampleMultiMapTest {
166-
public HashMultimap<String, String> map;
167-
}
168128
}

0 commit comments

Comments
 (0)