Fixed #102 as per suggestions on issue

Author: cowtowncoder

hibernate5/src/main/java/com/fasterxml/jackson/datatype/hibernate5/PersistentCollectionSerializer.java

@@ -310,6 +310,7 @@ protected Object findLazyValue(PersistentCollection coll) {
             return null;
         }
         if (_sessionFactory != null) {
+            // 08-Feb-2017, tatu: and not closing this is not problematic... ?
             Session session = openTemporarySessionForLoading(coll);
             initializeCollection(coll, session);
         }
@@ -423,52 +424,14 @@ private Object convertToSet(Set<?> value) {
     }
 
     protected static class SessionReader {
-        
-        /**
-         *  Return changed from org.hibernate.resource.transaction.TransactionCoordinator
-         *  to org.hibernate.resource.transaction.spi.TransactionCoordinator 
-         */
-        protected static final Method getTransactionCoordinatorMethod;
-        /**
-         *  Return changed from org.hibernate.resource.transaction.TransactionCoordinatorBuilder
-         *  to org.hibernate.resource.transaction.spi.TransactionCoordinatorBuilder 
-         */
-        protected static final Method getTransactionCoordinatorBuilderMethod;
-        /**
-         *  Class changed from org.hibernate.resource.transaction.TransactionCoordinatorBuilder
-         *  to org.hibernate.resource.transaction.spi.TransactionCoordinatorBuilder 
-         */
-        protected static final Method isJtaMethod;
-        
-        static {
-            try {
-                getTransactionCoordinatorMethod = SessionImplementor.class.getMethod("getTransactionCoordinator");
-            } catch (Exception e) {
-                // should never happen: the class and method exists in all versions of hibernate 5
-                throw new RuntimeException(e); 
-            }
-            try{
-                getTransactionCoordinatorBuilderMethod = Hibernate5Version.getTransactionCoordinatorClass().getMethod("getTransactionCoordinatorBuilder");
-            } catch (Exception e) {
-                // should never happen
-                throw new RuntimeException(e); 
-            }
-            try{
-                isJtaMethod = Hibernate5Version.getTransactionCoordinatorClass().getMethod("isJta");
-            } catch (Exception e) {
-                // should never happen
-                throw new RuntimeException(e); 
-            }
-        }
-        
         public static boolean isJTA(Session session) {
             try {
-                Object transactionCoordinator = getTransactionCoordinatorMethod.invoke(session);
-                Object transactionCoordinatorBuilder = getTransactionCoordinatorBuilderMethod.invoke(transactionCoordinator);
-                return (boolean) isJtaMethod.invoke(transactionCoordinatorBuilder);
-            } catch (Exception e) {
-                // Should never happen
-                throw new RuntimeException(e);
+                EntityManager em = (EntityManager) session;
+                em.getTransaction();
+                return false;
+            } catch (IllegalStateException e) {
+                // EntityManager is required to throw an IllegalStateException if it's JTA-managed
+                return true;
             }
         }
     }

hibernate5_2-test/pom.xml

@@ -3,27 +3,27 @@
   <parent>
     <groupId>com.fasterxml.jackson.datatype</groupId>
     <artifactId>jackson-datatype-hibernate-parent</artifactId>
-    <version>2.8.6-SNAPSHOT</version>
+    <version>2.8.7-SNAPSHOT</version>
   </parent>
   <artifactId>jackson-datatype-hibernate5_2-test</artifactId>
   <dependencies>
-  	<dependency>
-  		<groupId>com.fasterxml.jackson.datatype</groupId>
-  		<artifactId>jackson-datatype-hibernate5</artifactId>
-  		<version>2.8.6-SNAPSHOT</version>
-  		<scope>test</scope>
-  	</dependency>
-  	<dependency>
-  		<groupId>com.fasterxml.jackson.datatype</groupId>
-  		<artifactId>jackson-datatype-hibernate5</artifactId>
-  		<version>2.8.6-SNAPSHOT</version>
-  		<type>test-jar</type>
-  		<scope>test</scope>
-  	</dependency>
+    <dependency>
+      <groupId>com.fasterxml.jackson.datatype</groupId>
+      <artifactId>jackson-datatype-hibernate5</artifactId>
+      <version>${project.version}</version>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>com.fasterxml.jackson.datatype</groupId>
+      <artifactId>jackson-datatype-hibernate5</artifactId>
+      <version>${project.version}</version>
+      <type>test-jar</type>
+      <scope>test</scope>
+    </dependency>
     <dependency>
       <groupId>org.hibernate</groupId>
       <artifactId>hibernate-core</artifactId>
-      <version>5.2.0.Final</version>
+      <version>5.2.6.Final</version>
       <scope>provided</scope>
     </dependency>
 

pom.xml

@@ -18,8 +18,8 @@
     <module>hibernate4</module>
     <module>hibernate5</module>
 <!-- temp, to get release out
-    <module>hibernate5_2-test</module>
 -->
+    <module>hibernate5_2-test</module>
   </modules>
 
   <url>https://github.com/FasterXML/jackson-datatype-hibernate</url>

release-notes/VERSION

@@ -4,6 +4,11 @@ Project: jackson-datatype-hibernate
 === Releases ===
 ------------------------------------------------------------------------
 
+2.8.7 (not yet released)
+
+#102: 2.8.6 NoSuchMethodException with Hibernate 5.2
+ (reported by Jordan G)
+
 2.8.6 (12-Jan-2017)
 
 #92: Add support for Hibernate 5.2