Fix #226

Author: cowtowncoder

release-notes/VERSION-2.x

@@ -15,6 +15,8 @@ Modules:
 #222: (csv) `JsonParser.Feature.EMPTY_STRING_AS_NULL` does not work when
   text is parsed as `String[]`
  (reported by wkwkhautbois@github)
+#226: Quote 'y'/'Y'/'n'/'N' as names too (to avoid problems with Boolean keys)
+ (requested by pnepywoda@github)
 - Add Gradle Module Metadata (https://blog.gradle.org/alignment-with-gradle-module-metadata)
 
 2.11.2 (02-Aug-2020)

yaml/src/main/java/com/fasterxml/jackson/dataformat/yaml/YAMLGenerator.java

@@ -178,8 +178,9 @@ private Feature(boolean defaultState) {
      */
     // 02-Apr-2019, tatu: Some names will look funny if escaped: let's leave out
     //    single letter case (esp so 'y' won't get escaped)
+    // 17-Sep-2020, tatu: [dataformats-text#226] No, let's be consistent w/ values
     private final static Set<String> MUST_QUOTE_NAMES = new HashSet<>(Arrays.asList(
-//            "y", "Y", "n", "N",
+            "y", "Y", "n", "N",
             "yes", "Yes", "YES", "no", "No", "NO",
             "true", "True", "TRUE", "false", "False", "FALSE",
             "on", "On", "ON", "off", "Off", "OFF"

yaml/src/test/java/com/fasterxml/jackson/dataformat/yaml/misc/ReservedNamesTest.java

@@ -17,7 +17,7 @@ public void testQuotingOfBooleanKeys() throws Exception
                 "false", "False",
                 "yes", "no",
                 // NOTE: single-letter cases left out on purpose
-//                "y", "Y", "n", "N",
+                "y", "Y", "n", "N",
                 "on", "off",
         }) {
             _testQuotingOfBooleanKeys(value);

yaml/src/test/java/com/fasterxml/jackson/dataformat/yaml/ser/DatabindWriteTest.java

@@ -58,13 +58,14 @@ public void testBasicPOJO() throws Exception
         assertFalse(it.hasNext());
     }
 
-    // Related to [dataformats-test#68], escaping of "reserved" names
+    // Related to [dataformats-text#68], escaping of "reserved" names
     public void testBasicDatabind2() throws Exception
     {
         String yaml = trimDocMarker(MAPPER.writeValueAsString(new Point(1, 2)));
 
         // Just verify 'y' will NOT be escaped
-        assertEquals("x: 1\ny: 2", yaml);
+        // [dataformats-text#226]: ... actually, will be.
+        assertEquals("x: 1\n\"y\": 2", yaml);
 
         // Actually let's try reading back, too
         Point p = MAPPER.readValue(yaml, Point.class);