Skip to content

Commit cd59497

Browse files
committed
Update release notes wrt #352 (follow-up to #285)
1 parent 53cf263 commit cd59497

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

csv/src/main/java/com/fasterxml/jackson/dataformat/csv/CsvParser.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -863,7 +863,7 @@ protected void _readHeaderLine() throws IOException {
863863
}
864864
// [dataformats-text#285]: Are we missing something?
865865
int diff = schemaColumnCount - newColumnCount;
866-
if (Feature.FAIL_ON_MISSING_HEADER_COLUMNS.enabledIn(_formatFeatures) && diff > 0) {
866+
if ((diff > 0) && Feature.FAIL_ON_MISSING_HEADER_COLUMNS.enabledIn(_formatFeatures)) {
867867
Set<String> oldColumnNames = new LinkedHashSet<>();
868868
_schema.getColumnNames(oldColumnNames);
869869
oldColumnNames.removeAll(newSchema.getColumnNames());

release-notes/CREDITS-2.x

+6
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,13 @@ Jim Talbut (Yaytay@github)
214214
Simon Dean (msmsimondean@github)
215215
* Requested #244: (yaml) Add `YAMLGenerator.Feature.ALLOW_LONG_KEYS` to allow writing keys
216216
longer than 128 characters (default)
217+
(2.14.0)
217218

218219
Shauni Arima (ShauniArima@github)
219220
* Contributed #244: (yaml) Add `YAMLGenerator.Feature.ALLOW_LONG_KEYS` to allow writing keys
220221
longer than 128 characters (default)
222+
(2.14.0)
223+
224+
Matteo Giordano (malteo@github)
225+
* Contributed fix for #352: Disabling `CsvParser.Feature.FAIL_ON_MISSING_HEADER_COLUMNS` has no effect
226+
(2.14.1)

release-notes/VERSION-2.x

+5
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@ Active Maintainers:
1414
=== Releases ===
1515
------------------------------------------------------------------------
1616

17+
2.14.1 (not yet released)
18+
19+
#352: Disabling `CsvParser.Feature.FAIL_ON_MISSING_HEADER_COLUMNS` has no effect
20+
(fix contributed by Matteo G)
21+
1722
2.14.0 (05-Nov-2022)
1823

1924
#169: (properties) Need a way to escape dots in property keys (add path separator configuration)

0 commit comments

Comments
 (0)