Skip to content

Commit 12ece23

Browse files
committed
minor test cleanup
1 parent 1779911 commit 12ece23

File tree

1 file changed

+23
-16
lines changed

1 file changed

+23
-16
lines changed

csv/src/test/java/com/fasterxml/jackson/dataformat/csv/deser/EmptyStringAsNullTest.java

Lines changed: 23 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,41 @@
11
package com.fasterxml.jackson.dataformat.csv.deser;
22

33
import com.fasterxml.jackson.annotation.JsonPropertyOrder;
4-
import com.fasterxml.jackson.core.JsonProcessingException;
4+
55
import com.fasterxml.jackson.databind.ObjectReader;
66
import com.fasterxml.jackson.dataformat.csv.CsvMapper;
77
import com.fasterxml.jackson.dataformat.csv.CsvParser;
8-
import org.junit.Test;
8+
import com.fasterxml.jackson.dataformat.csv.ModuleTestBase;
99

1010
import java.io.IOException;
1111

12-
import static org.junit.Assert.*;
13-
1412
/**
15-
* Test for {@link CsvParser.Feature#EMPTY_STRING_AS_NULL}
13+
* Tests for {@link CsvParser.Feature#EMPTY_STRING_AS_NULL}
14+
* ({@code dataformats-text#7}).
1615
*/
17-
public class EmptyStringAsNullTest {
18-
19-
16+
public class EmptyStringAsNullTest
17+
extends ModuleTestBase
18+
{
2019
@JsonPropertyOrder({"firstName", "middleName", "lastName"})
2120
static class TestUser {
2221
public String firstName, middleName, lastName;
2322
}
2423

25-
@Test
26-
public void givenFeatureDisabledByDefault_whenColumnIsEmptyString_thenParseAsEmptyString() throws IOException {
24+
/*
25+
/**********************************************************
26+
/* Test methods
27+
/**********************************************************
28+
*/
29+
30+
private final CsvMapper MAPPER = mapperForCsv();
31+
32+
public void testDefaultParseAsEmptyString() throws IOException {
2733
// setup test data
2834
TestUser expectedTestUser = new TestUser();
2935
expectedTestUser.firstName = "Grace";
3036
expectedTestUser.middleName = "";
3137
expectedTestUser.lastName = "Hopper";
32-
CsvMapper csvMapper = CsvMapper.builder().build();
33-
ObjectReader objectReader = csvMapper.readerFor(TestUser.class).with(csvMapper.schemaFor(TestUser.class));
38+
ObjectReader objectReader = MAPPER.readerFor(TestUser.class).with(MAPPER.schemaFor(TestUser.class));
3439
String csv = "Grace,,Hopper";
3540

3641
// execute
@@ -43,14 +48,16 @@ public void givenFeatureDisabledByDefault_whenColumnIsEmptyString_thenParseAsEmp
4348
assertEquals(expectedTestUser.lastName, actualTestUser.lastName);
4449
}
4550

46-
@Test
47-
public void givenFeatureEnabled_whenColumnIsEmptyString_thenParseAsNull() throws IOException {
51+
public void testSimpleParseEmptyStringAsNull() throws IOException {
4852
// setup test data
4953
TestUser expectedTestUser = new TestUser();
5054
expectedTestUser.firstName = "Grace";
5155
expectedTestUser.lastName = "Hopper";
52-
CsvMapper csvMapper = CsvMapper.builder().enable(CsvParser.Feature.EMPTY_STRING_AS_NULL).build();
53-
ObjectReader objectReader = csvMapper.readerFor(TestUser.class).with(csvMapper.schemaFor(TestUser.class));
56+
57+
ObjectReader objectReader = MAPPER
58+
.readerFor(TestUser.class)
59+
.with(MAPPER.schemaFor(TestUser.class))
60+
.with(CsvParser.Feature.EMPTY_STRING_AS_NULL);
5461
String csv = "Grace,,Hopper";
5562

5663
// execute

0 commit comments

Comments
 (0)