[Avro] Add support for @Stringable annotation#57
Merged
cowtowncoder merged 1 commit intoFasterXML:masterfrom Mar 10, 2017
Merged
[Avro] Add support for @Stringable annotation#57cowtowncoder merged 1 commit intoFasterXML:masterfrom
cowtowncoder merged 1 commit intoFasterXML:masterfrom
Conversation
Member
|
Hmmh. This change seems to have nasty performance downside: serialization 30% slower, deserialization 5-15%... |
Member
|
Ok, was able to make minor changes to get serialization perf back: I do not think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the
@Stringableannotation, and adds support for stringable classes (Those with@Stringable, andURL/URI/File/BigInteger/BigDecimal). This fixes BigInteger/BigDecimal compatibility with the apache implementation.Of particular note,
BigDecimalis no longer aType.DOUBLEin schema generation, nor isBigIntegeraType.LONGin schema generation (since they are "stringable" to avro), but they should continue to serialize/deserialize properly from int/long/float/double scalars in existing avro schemas.I treated
@Stringableon a class as having a creator annotation on the constructor which takes a single string argument. I'm not sure if there is a better way to do this.Rebased onto master as per this comment.