Fix #599: handle skipping of CBOR string refs

Author: cowtowncoder

cbor/src/main/java/com/fasterxml/jackson/dataformat/cbor/CBORParser.java

@@ -3414,6 +3414,50 @@ protected void _skipIncomplete() throws IOException
                 && type != CBORConstants.MAJOR_TYPE_BYTES) {
             _throwInternal();
         }
+
+        // [dataformats-binary#599]: If we are in a stringref namespace, we need to
+        // actually read and store the string/bytes value instead of just skipping it,
+        // so that later string references can find it.
+        if (!_stringRefs.empty()) {
+            final int lowBits = _typeByte & 0x1F;
+            final int len = _decodeExplicitLength(lowBits);
+
+            if (type == CBORConstants.MAJOR_TYPE_TEXT) {
+                // For text, need to read the string to potentially store as reference
+                if (len >= 0) {
+                    // Non-chunked text
+                    if (shouldReferenceString(_stringRefs.peek().stringRefs.size(), len)) {
+                        // Need to actually read and store the string
+                        String str = _finishTextToken(_typeByte);
+                        // _finishTextToken already handles adding to stringRefs
+                        return;
+                    }
+                    // No need to store, can skip
+                } else {
+                    // Chunked text - must read to potentially store
+                    // Note: chunked strings may still need to be stored if large enough
+                    String str = _finishTextToken(_typeByte);
+                    return;
+                }
+            } else {
+                // For bytes, similar logic
+                if (len >= 0) {
+                    if (shouldReferenceString(_stringRefs.peek().stringRefs.size(), len)) {
+                        // Need to actually read and store the bytes
+                        byte[] b = _finishBytes(len);
+                        // _finishBytes already handles adding to stringRefs
+                        return;
+                    }
+                    // No need to store, can skip
+                } else {
+                    // Chunked bytes
+                    byte[] b = _finishChunkedBytes();
+                    return;
+                }
+            }
+        }
+
+        // Standard skip logic when not in stringref namespace
         final int lowBits = _typeByte & 0x1F;
         if (lowBits <= 23) {
             if (lowBits > 0) {

…aformat/cbor/tofix/StringRef599Test.java …on/dataformat/cbor/StringRef599Test.javacbor/src/test/java/com/fasterxml/jackson/dataformat/cbor/tofix/StringRef599Test.java renamed to cbor/src/test/java/com/fasterxml/jackson/dataformat/cbor/StringRef599Test.java cbor/src/test/java/com/fasterxml/jackson/dataformat/cbor/tofix/StringRef599Test.java renamed to cbor/src/test/java/com/fasterxml/jackson/dataformat/cbor/StringRef599Test.java

@@ -1,13 +1,10 @@
-package com.fasterxml.jackson.dataformat.cbor.tofix;
+package com.fasterxml.jackson.dataformat.cbor;
 
 import java.util.Arrays;
 
 import com.fasterxml.jackson.core.JsonToken;
 import com.fasterxml.jackson.databind.ObjectMapper;
 
-import com.fasterxml.jackson.dataformat.cbor.*;
-import com.fasterxml.jackson.dataformat.cbor.testutil.failure.JacksonTestFailureExpected;
-
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
 import org.junit.jupiter.api.Test;
@@ -27,7 +24,6 @@ public void testDupsNoStringRef() throws Exception
     }
 
     // [dataformats-binary#599]
-    @JacksonTestFailureExpected
     @Test
     public void testDupsWithStringRef() throws Exception
     {

release-notes/CREDITS-2.x

@@ -422,3 +422,7 @@ Vincent Eigenberger (@beseder1)
  * Contributed fix for #601: Jackson subtype Avro schema unions are non-deterministic
    and therefore incompatible with each other
   (2.20.1)
+
+Yohei Kishimoto (@morokosi)
+ * Reported #599: (cbor) Unable to deserialize stringref-enabled CBOR with ignored properties
+  (2.21.0)

release-notes/VERSION-2.x

@@ -16,6 +16,8 @@ Active maintainers:
 
 2.21.0 (not yet released)
 
+#599: (cbor) Unable to deserialize stringref-enabled CBOR with ignored properties
+ (reported by Yohei K)
 #623: (ion) Upgrade `ion-java` dep to 1.11.11 (from 1.11.10)
  (requested by @Shaurya0108)