Skip to content

Commit 3d0e5ec

Browse files
committed
Merge branch '2.8' into 2.9
2 parents 372fb4b + 873a9de commit 3d0e5ec

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

protobuf/src/main/java/com/fasterxml/jackson/dataformat/protobuf/ProtobufParser.java

+5-3
Original file line numberDiff line numberDiff line change
@@ -924,10 +924,12 @@ private JsonToken _skipUnknownField(int tag, int wireType) throws IOException
924924
}
925925
while (true) {
926926
_skipUnknownValue(wireType);
927+
// 05-Dec-2017, tatu: as per [#126] seems like we need to check this not just for
928+
// STATE_NESTED_KEY but for arrays too at least?
929+
if (_checkEnd()) {
930+
return (_currToken = JsonToken.END_OBJECT);
931+
}
927932
if (_state == STATE_NESTED_KEY) {
928-
if (_checkEnd()) {
929-
return (_currToken = JsonToken.END_OBJECT);
930-
}
931933
if (_inputPtr >= _inputEnd) {
932934
loadMoreGuaranteed();
933935
}

release-notes/CREDITS

+2
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ marsqing@github
3131
* Reported #116 (protobuf), contributed fix for: Should skip the positive byte
3232
which is the last byte of an varint
3333
(2.9.3)
34+
* Reported #126, contributed fix for: always call checkEnd() when skip unknown field
35+
(2.8.11 / 2.9.3)
3436

3537
baharclerode@github:
3638

release-notes/VERSION

+1
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ Modules:
5959
#106: (protobuf) fix calling _skipUnknownValue() twice
6060
(reported, contributed fix for by marsqing@github@github)
6161
#108: (protobuf) fix NPE in skip unknown nested key
62+
#126: (protobuf) always call checkEnd() when skip unknown field
6263

6364
2.8.10 (24-Aug-2017)
6465

0 commit comments

Comments
 (0)