From 85c341ca2252c31c41c986f75330aa086669b369 Mon Sep 17 00:00:00 2001 From: joohyukkim Date: Tue, 3 Dec 2024 23:29:28 +0900 Subject: [PATCH 1/2] doc : explain more on `ObjectMapper.canDeserialize()`/`ObjectMapper.canSerialize()` deprecation --- .../java/com/fasterxml/jackson/databind/ObjectMapper.java | 8 ++++++++ .../java/com/fasterxml/jackson/databind/ObjectWriter.java | 4 ++++ 2 files changed, 12 insertions(+) diff --git a/src/main/java/com/fasterxml/jackson/databind/ObjectMapper.java b/src/main/java/com/fasterxml/jackson/databind/ObjectMapper.java index c06999da2a..c1539932fa 100644 --- a/src/main/java/com/fasterxml/jackson/databind/ObjectMapper.java +++ b/src/main/java/com/fasterxml/jackson/databind/ObjectMapper.java @@ -3637,6 +3637,8 @@ public T valueToTree(Object fromValue) * serializable) * * @deprecated Since 2.18 use discouraged; method to be removed from Jackson 3.0 + * It is recommended to try directly testing de/serialization using actual JSON inputs and outputs + * in test cases to ensure correctness and compatibility with real-world use cases. */ @Deprecated // @since 2.18 public boolean canSerialize(Class type) { @@ -3651,6 +3653,8 @@ public boolean canSerialize(Class type) { * @since 2.3 * * @deprecated Since 2.18 use discouraged; method to be removed from Jackson 3.0 + * It is recommended to try directly testing de/serialization using actual JSON inputs and outputs + * in test cases to ensure correctness and compatibility with real-world use cases. */ @Deprecated // @since 2.18 public boolean canSerialize(Class type, AtomicReference cause) { @@ -3675,6 +3679,8 @@ public boolean canSerialize(Class type, AtomicReference cause) { * serializable) * * @deprecated Since 2.18 use discouraged; method to be removed from Jackson 3.0 + * It is recommended to try directly testing de/serialization using actual JSON inputs and outputs + * in test cases to ensure correctness and compatibility with real-world use cases. */ @Deprecated // @since 2.18 public boolean canDeserialize(JavaType type) @@ -3691,6 +3697,8 @@ public boolean canDeserialize(JavaType type) * @since 2.3 * * @deprecated Since 2.18 use discouraged; method to be removed from Jackson 3.0 + * It is recommended to try directly testing de/serialization using actual JSON inputs and outputs + * in test cases to ensure correctness and compatibility with real-world use cases. */ @Deprecated // @since 2.18 public boolean canDeserialize(JavaType type, AtomicReference cause) diff --git a/src/main/java/com/fasterxml/jackson/databind/ObjectWriter.java b/src/main/java/com/fasterxml/jackson/databind/ObjectWriter.java index ed4fe845fd..4b8d3fae83 100644 --- a/src/main/java/com/fasterxml/jackson/databind/ObjectWriter.java +++ b/src/main/java/com/fasterxml/jackson/databind/ObjectWriter.java @@ -1215,6 +1215,8 @@ public void acceptJsonFormatVisitor(Class type, JsonFormatVisitorWrapper visi * it could serialize an instance of given Class. * * @deprecated Since 2.18 use discouraged; method to be removed from Jackson 3.0 + * It is recommended to try directly testing de/serialization using actual JSON inputs and outputs + * in test cases to ensure correctness and compatibility with real-world use cases. */ @Deprecated // @since 2.18 public boolean canSerialize(Class type) { @@ -1229,6 +1231,8 @@ public boolean canSerialize(Class type) { * @since 2.3 * * @deprecated Since 2.18 use discouraged; method to be removed from Jackson 3.0 + * It is recommended to try directly testing de/serialization using actual JSON inputs and outputs + * in test cases to ensure correctness and compatibility with real-world use cases. */ @Deprecated // @since 2.18 public boolean canSerialize(Class type, AtomicReference cause) { From 9bb07994be4d5d06514e93b6cfed831892e60017 Mon Sep 17 00:00:00 2001 From: joohyukkim Date: Wed, 4 Dec 2024 09:26:08 +0900 Subject: [PATCH 2/2] Remove sign of lazy-ness in JavaDoc. Spell things out correctly! --- .../java/com/fasterxml/jackson/databind/ObjectMapper.java | 8 ++++---- .../java/com/fasterxml/jackson/databind/ObjectWriter.java | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main/java/com/fasterxml/jackson/databind/ObjectMapper.java b/src/main/java/com/fasterxml/jackson/databind/ObjectMapper.java index c1539932fa..adc56b8620 100644 --- a/src/main/java/com/fasterxml/jackson/databind/ObjectMapper.java +++ b/src/main/java/com/fasterxml/jackson/databind/ObjectMapper.java @@ -3637,7 +3637,7 @@ public T valueToTree(Object fromValue) * serializable) * * @deprecated Since 2.18 use discouraged; method to be removed from Jackson 3.0 - * It is recommended to try directly testing de/serialization using actual JSON inputs and outputs + * It is recommended to try directly testing serialization using actual JSON inputs and outputs * in test cases to ensure correctness and compatibility with real-world use cases. */ @Deprecated // @since 2.18 @@ -3653,7 +3653,7 @@ public boolean canSerialize(Class type) { * @since 2.3 * * @deprecated Since 2.18 use discouraged; method to be removed from Jackson 3.0 - * It is recommended to try directly testing de/serialization using actual JSON inputs and outputs + * It is recommended to try directly testing serialization using actual JSON inputs and outputs * in test cases to ensure correctness and compatibility with real-world use cases. */ @Deprecated // @since 2.18 @@ -3679,7 +3679,7 @@ public boolean canSerialize(Class type, AtomicReference cause) { * serializable) * * @deprecated Since 2.18 use discouraged; method to be removed from Jackson 3.0 - * It is recommended to try directly testing de/serialization using actual JSON inputs and outputs + * It is recommended to try directly testing deserialization using actual JSON inputs and outputs * in test cases to ensure correctness and compatibility with real-world use cases. */ @Deprecated // @since 2.18 @@ -3697,7 +3697,7 @@ public boolean canDeserialize(JavaType type) * @since 2.3 * * @deprecated Since 2.18 use discouraged; method to be removed from Jackson 3.0 - * It is recommended to try directly testing de/serialization using actual JSON inputs and outputs + * It is recommended to try directly testing deserialization using actual JSON inputs and outputs * in test cases to ensure correctness and compatibility with real-world use cases. */ @Deprecated // @since 2.18 diff --git a/src/main/java/com/fasterxml/jackson/databind/ObjectWriter.java b/src/main/java/com/fasterxml/jackson/databind/ObjectWriter.java index 4b8d3fae83..9140ecdf1b 100644 --- a/src/main/java/com/fasterxml/jackson/databind/ObjectWriter.java +++ b/src/main/java/com/fasterxml/jackson/databind/ObjectWriter.java @@ -1215,7 +1215,7 @@ public void acceptJsonFormatVisitor(Class type, JsonFormatVisitorWrapper visi * it could serialize an instance of given Class. * * @deprecated Since 2.18 use discouraged; method to be removed from Jackson 3.0 - * It is recommended to try directly testing de/serialization using actual JSON inputs and outputs + * It is recommended to try directly testing serialization using actual JSON inputs and outputs * in test cases to ensure correctness and compatibility with real-world use cases. */ @Deprecated // @since 2.18 @@ -1231,7 +1231,7 @@ public boolean canSerialize(Class type) { * @since 2.3 * * @deprecated Since 2.18 use discouraged; method to be removed from Jackson 3.0 - * It is recommended to try directly testing de/serialization using actual JSON inputs and outputs + * It is recommended to try directly testing serialization using actual JSON inputs and outputs * in test cases to ensure correctness and compatibility with real-world use cases. */ @Deprecated // @since 2.18