Replies: 10 comments 13 replies
-
|
@gsviteri Could you also provide a minimal testcase to reproduce the issue? My version doesn't seem to work. |
Beta Was this translation helpful? Give feedback.
-
|
Using 2.15.1-SNAPSHOT import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonSubTypes;
import com.fasterxml.jackson.annotation.JsonTypeInfo;
import com.fasterxml.jackson.annotation.JsonTypeName;
import com.fasterxml.jackson.databind.BaseMapTest;
import com.fasterxml.jackson.databind.ObjectMapper;
public class S extends BaseMapTest {
@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type", include = JsonTypeInfo.As.EXISTING_PROPERTY)
@JsonSubTypes({
@JsonSubTypes.Type(value = ContinuousMultiSessionMetric.class, name = "continuous"),
@JsonSubTypes.Type(value = DiscreteMultiSessionMetric.class, name = "discrete")
})
static abstract class MultiSessionMetricDTO {
@JsonProperty
public final String name;
@JsonProperty
public final String desc;
@JsonProperty
public final String type;
@JsonProperty
public double normalisedValue;
public MultiSessionMetricDTO(String name, String desc, String type, double normalisedValue) {
this.name = name;
this.desc = desc;
this.type = type;
this.normalisedValue = normalisedValue;
}
}
@JsonTypeName("continuous")
static class ContinuousMultiSessionMetric extends MultiSessionMetricDTO {
@JsonProperty
public final double value;
@JsonProperty
public final double mean;
@JsonProperty
public final double standardDeviation;
@JsonCreator
ContinuousMultiSessionMetric(
@JsonProperty("value") double value,
@JsonProperty("mean") double mean,
@JsonProperty("standardDeviation") double standardDeviation,
@JsonProperty("name") String name,
@JsonProperty("desc") String desc,
@JsonProperty("normalisedValue") double normalisedValue
) {
super(name, desc, "continuous", normalisedValue);
this.value = value;
this.mean = mean;
this.standardDeviation = standardDeviation;
}
}
@JsonTypeName("discrete")
static class DiscreteMultiSessionMetric extends MultiSessionMetricDTO {
@JsonProperty("value")
public final String value;
@JsonProperty("mode")
public final String mode;
@JsonCreator
public DiscreteMultiSessionMetric(
@JsonProperty("value") String value,
@JsonProperty("mode") String mode,
@JsonProperty("name") String name,
@JsonProperty("desc") String desc,
@JsonProperty("normalisedValue") double normalisedValue
) {
super(name, desc, "discrete", normalisedValue);
this.mode = mode;
this.value = value;
}
}
private final ObjectMapper MAPPER = newJsonMapper();
public void testSerialization() throws Exception {
String jsonStr = MAPPER.writeValueAsString(new DiscreteMultiSessionMetric("value", "mode", "name", "desc", 0.0));
DiscreteMultiSessionMetric metric = MAPPER.readValue(jsonStr, DiscreteMultiSessionMetric.class);
assertNotNull(metric);
}
public void testSerializationContinunous() throws Exception {
String jsonStr = MAPPER.writeValueAsString(new ContinuousMultiSessionMetric(1.0, 2.0, 3.0, "name", "desc", 0.0));
ContinuousMultiSessionMetric metric = MAPPER.readValue(jsonStr, ContinuousMultiSessionMetric.class);
assertNotNull(metric);
}
} |
Beta Was this translation helpful? Give feedback.
-
|
Edited: adding the json that comes from MongoDB |
Beta Was this translation helpful? Give feedback.
-
|
Thanks @JooHyukKim. Same error using snapshot version. My test is MockMVC using embedded Mongo. The full test scenario is going to be hard to publish. I will see if I can isolate. ANy more help will be appreciated ! |
Beta Was this translation helpful? Give feedback.
-
|
Np! 🙏🏼 @gsviteri atm I am trying minimize the json example you provided. Soon I will leave update. |
Beta Was this translation helpful? Give feedback.
-
Oh hold on, let me provide an example. It shouldn't be that hard to isolate. Basically what you need is [1. cofingured mapper + 2. input JSON string + 3. expected output.] @Test
public void testDeserFromMongo() throws Exception {
// Provide your configured mapper
ObjectMapper mapper = JsonMapper.builder().build();
// your input JSON string
String jsonStr =
"{"
+ "\"value\": 8888.8,"
+ "\"mean\": 8888.8,"
+ "\"standardDeviation\": 0.0,"
+ "\"name\": \"Idle Time Percentage\","
+ "\"desc\": \"The percentage of time with no click or keyboard input\","
+ "\"normalisedValue\": 0.0,"
+ "\"type\": \"continuous\""
+ "}";
// deserialization
MultiSessionMetricDTO metric = mapper.readValue(jsonStr, MultiSessionMetricDTO.class);
// expected values... assertions
assertNotNull(metric);
} |
Beta Was this translation helpful? Give feedback.
-
|
This specific test case works. Still works when I added the other POJOs. :( |
Beta Was this translation helpful? Give feedback.
-
|
Instead of discussion this probably would have made sense as an issue. But that's fine. Just one quick question to make sure I understand this:
If so, yes, that's a bug and hopefully easy enough to test. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks @cowtowncoder for getting back to me so quickly. I opened as discussion, as I thought I'd be missing something simple on the latest version. Happy to open a bug if needed.
Please, let me know and I can open a bug. |
Beta Was this translation helpful? Give feedback.
-
|
It's actually ok for now; I can use discussion id for now. Just need to figure out a simple reproduction: it might be as simple as just having type like and reading JSON like so: and perhaps this case of Coercion fails -- there were changes in 2.15 to allow preventing various coercions; this could be regression. |
Beta Was this translation helpful? Give feedback.
-
|
I will try to look also. Later today ✌🏻 |
Beta Was this translation helpful? Give feedback.
-
|
Was not able to reproduce using that approach, with default Next guess: has to do with value buffering via At this point a simplified version would be needed. |
Beta Was this translation helpful? Give feedback.
-
|
Might be something fiddly before Mongo tries to decode it Here are all the classes from the moment i
... this is how data look like in Mongo. |
Beta Was this translation helpful? Give feedback.
-
|
Ok, so could also be due to how MongoJack uses Jackson. |
Beta Was this translation helpful? Give feedback.
-
|
From the screenshot, I highlighted the decode statement and the following statement is |
Beta Was this translation helpful? Give feedback.
-
|
just updated the original post with the previous version we were using |
Beta Was this translation helpful? Give feedback.
-
|
the thing is - the issue could be in Jackson but noone on Jackson team is likely to use Mongo or have time to install Mongo and debug this for you Maybe you should bring this to mongojack users/developers and they might be in a better position to help |
Beta Was this translation helpful? Give feedback.
-
|
https://github.com/mongojack/mongojack has not yet released a version of their lib that is built and/or tested with jackson 2.15 |
Beta Was this translation helpful? Give feedback.
-
|
I agree -- Mongojack devs are mostly likely to be able to help. My guess is that there may be change to behavior of one of It might be interesting to know which Jackson versions Mongojack does work with, although ultimately that won't help fix the thing unless it suggests related change. |
Beta Was this translation helpful? Give feedback.
-
|
Sound good. Will give the guys a poke and perhaps update here as well once I hear from them. |
Beta Was this translation helpful? Give feedback.
-
|
Good luck @gsviteri and let us know how it goes. |
Beta Was this translation helpful? Give feedback.
-
|
@gsviteri @cowtowncoder FYI: I opened a PR for mongojack that fixes the issue. https://github.com/mongojack/mongojack/pull/241/files#diff-f14e52179b3d88fba38d6828d8fa3f6210c5bc1d41dc27937402e720b5846b52 I had to add a custom implementation for |
Beta Was this translation helpful? Give feedback.
-
Hi All,
After upgrading from
2.11.3to2.15.0, we are now having issues on the deserialisation where double values are deliberately marshalled as empty string.Few areas that we already covered:
[Source: (String); byte offset: #UNKNOWN](version that works is[Source: (String)"type"; line: -1, column: -1])VALUE_NUMBER_FLOATMapperFeature.ALLOW_COERCION_OF_SCALARS, same error I'm afraidobjectMapper.setSerializationInclusion(JsonInclude.Include.NON_NULL), no difference at allError Log
.ContinuousMultiSessionMetric class is a subtype of MultiSessionMetric. Here's how they are declared
{ "_id" : ObjectId("6455799cc5631e7c84edf0a9"), "lastSystemEventId" : "EventID1", "sessionId" : "session1", "biometric" : { "metrics" : [ { "metrics" : [ { "value" : 2299.9, "mean" : 2299.9, "standardDeviation" : 0.0, "name" : "Event/Received Time Difference", "desc" : "The time difference between events happening and processing them for this session", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : "Chrome", "mode" : "Chrome", "name" : "Browser", "desc" : "Browser used for this session", "normalisedValue" : 0.0, "type" : "discrete" }, { "value" : "MacOS", "mode" : "MacOS", "name" : "OS", "desc" : "OS used for this session", "normalisedValue" : 0.0, "type" : "discrete" }, { "name" : "Country", "desc" : "Country in which this session took place", "normalisedValue" : 0.0, "type" : "discrete" }, { "value" : "en-GB", "mode" : "en-GB", "name" : "Localisation", "desc" : "Locale setting of the computer used for this session, which is a set of parameters defining language, region, etc", "normalisedValue" : 0.0, "type" : "discrete" }, { "value" : "1440x900", "mode" : "1440x900", "name" : "Screen Resolution", "desc" : "Screen resolution of the computer used for this session", "normalisedValue" : 0.0, "type" : "discrete" } ], "name" : "System Features", "desc" : "These features relate to the computer used for the session." }, { "metrics" : [ { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Average Click Duration", "desc" : "Average time duration of a mouse click", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Average Double Click Latency", "desc" : "Average time interval between double left clicks", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Left Clicks", "desc" : "Total number of left clicks", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Right Clicks", "desc" : "Total number of right clicks", "normalisedValue" : 0.0, "type" : "continuous" } ], "name" : "Mouse Features", "desc" : "These features relate to the mouse use of the user during the session." }, { "metrics" : [ { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Typing Speed", "desc" : "Average typing speed", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Average Key Press Duration", "desc" : "Average time duration when a key is pressed down", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Average Key Latency", "desc" : "Average time gap between the release of the last key and press of the next key", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Key Overlap Time", "desc" : "Total duration of the time when the next key or keys are pressed down while the previous key has not been released", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Average Double Key Press Latency", "desc" : "Average time interval between the same key being double pressed", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Keyboard Idle Time Percentage", "desc" : "The percentage of time with no keyboard input", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Tab Presses", "desc" : "Total number of Tab presses", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Left Shift Presses", "desc" : "Total number of left shift presses", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Right Shift Presses", "desc" : "Total number of right shift presses", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Caps Lock Presses", "desc" : "Total number of Caps Lock presses", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Digits", "desc" : "Total number of presses of the digit keys at the top of the alphanumeric section in keyboard", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Numberpad", "desc" : "Total number of numpad key presses", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Delete Presses", "desc" : "Total number of Delete key presses", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Backspaces", "desc" : "Total number of Backspace key presses", "normalisedValue" : 0.0, "type" : "continuous" } ], "name" : "Keyboard Features", "desc" : "These features relate to the keyboard use of the user during the session." }, { "metrics" : [ { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Idle Time Percentage", "desc" : "The percentage of time with no click or keyboard input", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Average Time Between Text Fields", "desc" : "Average time interval between the last keyboard input in a text field and the first one in the next text field", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Autofill Uses", "desc" : "The number times Autofill has been used to fill out a form", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Autofill Cancels", "desc" : "The number times Autofill has been canceled", "normalisedValue" : 0.0, "type" : "continuous" } ], "name" : "Miscellaneous Features", "desc" : "Miscellaneous other features of the user." } ], "contexts" : [ { "name" : "checkout", "alias" : "checkout" } ] }, "context" : "checkout", "tenantId" : "TENANT", "entityId" : "consumer1", "entityType" : "consumer", "channel" : "JSC", "isGlobal" : false, "global" : false } { "_id" : ObjectId("6455799fc5631e7c84edf0aa"), "lastSystemEventId" : "EventID2", "sessionId" : "session2", "biometric" : { "metrics" : [ { "metrics" : [ { "value" : "UNKNOWN", "mode" : "UNKNOWN", "name" : "Charging", "desc" : "The charging status during the session", "normalisedValue" : 0.0, "type" : "discrete" } ], "name" : "Device Features", "desc" : "These features relate to the mobile device used for the session" }, { "metrics" : [ { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Keystroke Distribution", "desc" : "The distribution of times between individual keystrokes", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Fraction of Time Typing", "desc" : "The fraction of the total session time which was spent typing", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Typing Speed", "desc" : "Average typing speed", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Time in Text Fields", "desc" : "The total time spent typing in text fields", "normalisedValue" : 0.0, "type" : "continuous" }, { "value" : 8888.8, "mean" : 8888.8, "standardDeviation" : 0.0, "name" : "Backspaces", "desc" : "Total number of Backspace key presses", "normalisedValue" : 0.0, "type" : "continuous" } ], "name" : "Typing Features", "desc" : "These features relate to the typing behaviour of the user" }, { "metrics" : [ { "value" : "-0.0", "mode" : "0.0", "name" : "Field Filling Sequence", "desc" : "The sequence in which the user interacted with text fields", "normalisedValue" : -0.0, "type" : "discrete" }, { "value" : "-0.0", "mode" : "0.0", "name" : "View Sequence", "desc" : "The sequence in which the user visited views within the app", "normalisedValue" : -0.0, "type" : "discrete" } ], "name" : "Navigation Features", "desc" : "These features relate to the sequence in which the user navigates elements of the app" } ], "contexts" : [ { "name" : "checkout", "alias" : "checkout" } ] }, "context" : "checkout", "tenantId" : "TENANT", "entityId" : "consumer1", "entityType" : "consumer", "channel" : "IOS", "isGlobal" : false, "global" : false }So, this is how data are displayed when using Jackson:2.10.0
... And this is how it is displayed after upgrading
Any help will be massively appreciate here.
Cheers
Beta Was this translation helpful? Give feedback.
All reactions