Add a failing test for #806

Author: cowtowncoder

src/main/java/com/fasterxml/jackson/databind/ObjectMapper.java

@@ -1213,8 +1213,14 @@ public ObjectMapper setSubtypeResolver(SubtypeResolver str) {
     }
 
     /**
-     * Method for changing {@link AnnotationIntrospector} used by this
-     * mapper instance for both serialization and deserialization
+     * Method for setting {@link AnnotationIntrospector} used by this
+     * mapper instance for both serialization and deserialization.
+     * Note that doing this will replace the current introspector, which
+     * may lead to unavailability of core Jackson annotations.
+     * If you want to combine handling of multiple introspectors,
+     * have a look at {@link com.fasterxml.jackson.databind.introspect.AnnotationIntrospectorPair}.
+     * 
+     * @see com.fasterxml.jackson.databind.introspect.AnnotationIntrospectorPair
      */
     public ObjectMapper setAnnotationIntrospector(AnnotationIntrospector ai) {
         _serializationConfig = _serializationConfig.with(ai);
@@ -1234,6 +1240,8 @@ public ObjectMapper setAnnotationIntrospector(AnnotationIntrospector ai) {
      *    serialization
      * @param deserializerAI {@link AnnotationIntrospector} to use for configuring
      *    deserialization
+     * 
+     * @see com.fasterxml.jackson.databind.introspect.AnnotationIntrospectorPair
      */
     public ObjectMapper setAnnotationIntrospectors(AnnotationIntrospector serializerAI,
             AnnotationIntrospector deserializerAI) {

src/test/java/com/fasterxml/jackson/databind/creators/ImplicitParamsForCreatorTest.java

@@ -1,7 +1,5 @@
 package com.fasterxml.jackson.databind.creators;
 
-import com.fasterxml.jackson.annotation.JsonCreator;
-
 import com.fasterxml.jackson.databind.*;
 import com.fasterxml.jackson.databind.introspect.AnnotatedMember;
 import com.fasterxml.jackson.databind.introspect.AnnotatedParameter;
@@ -16,7 +14,7 @@ static class MyParamIntrospector extends JacksonAnnotationIntrospector
         public String findImplicitPropertyName(AnnotatedMember param) {
             if (param instanceof AnnotatedParameter) {
                 AnnotatedParameter ap = (AnnotatedParameter) param;
-                return "param"+ap.getIndex();
+                return "paramName"+ap.getIndex();
             }
             return super.findImplicitPropertyName(param);
         }
@@ -25,7 +23,8 @@ public String findImplicitPropertyName(AnnotatedMember param) {
     static class XY {
         protected int x, y;
 
-        @JsonCreator
+        // annotation should NOT be needed with 2.6 any more (except for single-arg case)
+        //@com.fasterxml.jackson.annotation.JsonCreator
         public XY(int x, int y) {
             this.x = x;
             this.y = y;
@@ -42,7 +41,7 @@ public void testNonSingleArgCreator() throws Exception
     {
         ObjectMapper mapper = new ObjectMapper();
         mapper.setAnnotationIntrospector(new MyParamIntrospector());
-        XY value = mapper.readValue(aposToQuotes("{'param0':1,'param1':2}"), XY.class);
+        XY value = mapper.readValue(aposToQuotes("{'paramName0':1,'paramName1':2}"), XY.class);
         assertNotNull(value);
         assertEquals(1, value.x);
         assertEquals(2, value.y);

src/test/java/com/fasterxml/jackson/failing/ImplicitParamsForCreator806Test.java

@@ -0,0 +1,52 @@
+package com.fasterxml.jackson.failing;
+
+import com.fasterxml.jackson.databind.*;
+import com.fasterxml.jackson.databind.introspect.AnnotatedMember;
+import com.fasterxml.jackson.databind.introspect.AnnotatedParameter;
+import com.fasterxml.jackson.databind.introspect.JacksonAnnotationIntrospector;
+
+public class ImplicitParamsForCreator806Test extends BaseMapTest
+{
+    @SuppressWarnings("serial")
+    static class MyParamIntrospector extends JacksonAnnotationIntrospector
+    {
+        @Override
+        public String findImplicitPropertyName(AnnotatedMember param) {
+            if (param instanceof AnnotatedParameter) {
+                AnnotatedParameter ap = (AnnotatedParameter) param;
+                return "paramName"+ap.getIndex();
+            }
+            return super.findImplicitPropertyName(param);
+        }
+    }
+
+    static class XY {
+        protected int x, y;
+
+        // annotation should NOT be needed with 2.6 any more (except for single-arg case)
+        //@com.fasterxml.jackson.annotation.JsonCreator
+        public XY(int x, int y) {
+            this.x = x;
+            this.y = y;
+        }
+    }
+    
+    /*
+    /**********************************************************
+    /* Test methods
+    /**********************************************************
+     */
+
+    // for [databind#806]
+    public void testImplicitNameWithNamingStrategy() throws Exception
+    {
+        ObjectMapper mapper = new ObjectMapper()
+            .setAnnotationIntrospector(new MyParamIntrospector())
+            .setPropertyNamingStrategy(PropertyNamingStrategy.CAMEL_CASE_TO_LOWER_CASE_WITH_UNDERSCORES)
+            ;
+        XY value = mapper.readValue(aposToQuotes("{'param_name0':1,'param_name1':2}"), XY.class);
+        assertNotNull(value);
+        assertEquals(1, value.x);
+        assertEquals(2, value.y);
+    }
+}