Update release notes wrt #2719 (and minor optimization wrt fix)

Author: cowtowncoder

release-notes/CREDITS-2.x

@@ -1114,3 +1114,8 @@ Mike Gilbode (gilbode@github)
 Nate Bauernfeind (nbauernfeind@github)
   * Reported #2091: `ReferenceType` does not expose valid containedType
   (2.12.0)
+
+David Bidorff (bidorffOL@github)
+  * Reported, contributed fix for #2719: `FAIL_ON_IGNORED_PROPERTIES` does not throw
+    on `READONLY` properties with an explicit name
+  (2.12.0)

release-notes/VERSION-2.x

@@ -19,6 +19,9 @@ Project: jackson-databind
 #2683: Explicitly fail (de)serialization of `java.time.*` types in absence of
   registered custom (de)serializers
 #2707: Improve description included in by `DeserializationContext.handleUnexpectedToken()`
+#2719: `FAIL_ON_IGNORED_PROPERTIES` does not throw on `READONLY` properties with
+  an explicit name
+ (reported, fix contributed by David B)
 - Add `BeanDeserializerBase.isCaseInsensitive()`
 - Some refactoring of `CollectionDeserializer` to solve CSV array handling issues
 

src/main/java/com/fasterxml/jackson/databind/introspect/POJOPropertiesCollector.java

@@ -792,18 +792,10 @@ protected void _removeUnwantedAccessor(Map<String, POJOPropertyBuilder> props)
 
         while (it.hasNext()) {
             POJOPropertyBuilder prop = it.next();
-            // [databind#2719]: ignore the explicit names when they are available
-            Collection<PropertyName> names = prop.findExplicitNames();
-            if (names.isEmpty()) {
-                names = Collections.singleton(prop.getFullName());
-            }
             // 26-Jan-2017, tatu: [databind#935]: need to denote removal of
-            JsonProperty.Access acc = prop.removeNonVisible(inferMutators);
-            if (acc == JsonProperty.Access.READ_ONLY) {
-                for (PropertyName explicitName : names) {
-                    _collectIgnorals(explicitName.getSimpleName());
-                }
-            }
+            // 16-May-2020, tatu: [databind#2719]: need to pass `this` to allow
+            //    addition of ignorals wrt explicit name
+            prop.removeNonVisible(inferMutators, _forSerialization ? null : this);
         }
     }
 
@@ -812,9 +804,9 @@ protected void _removeUnwantedAccessor(Map<String, POJOPropertyBuilder> props)
      * of known ignored properties; this helps in proper reporting of
      * errors.
      */
-    private void _collectIgnorals(String name)
+    protected void _collectIgnorals(String name)
     {
-        if (!_forSerialization) {
+        if (!_forSerialization && (name != null)) {
             if (_ignoredPropertyNames == null) {
                 _ignoredPropertyNames = new HashSet<String>();
             }

src/main/java/com/fasterxml/jackson/databind/introspect/POJOPropertyBuilder.java

@@ -783,11 +783,19 @@ public void removeIgnored()
         _ctorParameters = _removeIgnored(_ctorParameters);
     }
 
+    @Deprecated // since 2.12
+    public JsonProperty.Access removeNonVisible(boolean inferMutators) {
+        return removeNonVisible(inferMutators, null);
+    }
+    
     /**
      * @param inferMutators Whether mutators can be "pulled in" by visible
      *    accessors or not. 
+     *
+     * @since 2.12 (earlier had different signature)
      */
-    public JsonProperty.Access removeNonVisible(boolean inferMutators)
+    public JsonProperty.Access removeNonVisible(boolean inferMutators,
+            POJOPropertiesCollector parent)
     {
         /* 07-Jun-2015, tatu: With 2.6, we will allow optional definition
          *  of explicit access type for property; if not "AUTO", it will
@@ -799,6 +807,15 @@ public JsonProperty.Access removeNonVisible(boolean inferMutators)
         }
         switch (acc) {
         case READ_ONLY:
+            // [databind#2719]: Need to add ignorals, first, keeping in mind
+            // we have not yet resolved explicit names, so include implicit
+            // and possible explicit names
+            if (parent != null) {
+                parent._collectIgnorals(getName());
+                for (PropertyName pn : findExplicitNames()) {
+                    parent._collectIgnorals(pn.getSimpleName());
+                }
+            }
             // Remove setters, creators for sure, but fields too if deserializing
             _setters = null;
             _ctorParameters = null;