Add a (passing) test for #2992

Author: cowtowncoder

src/test-jdk14/java/com/fasterxml/jackson/databind/RecordBasicsTest.java

@@ -1,7 +1,7 @@
 package com.fasterxml.jackson.databind;
 
 import com.fasterxml.jackson.annotation.*;
-
+import com.fasterxml.jackson.databind.annotation.JsonNaming;
 import com.fasterxml.jackson.databind.json.JsonMapper;
 import com.fasterxml.jackson.databind.util.ClassUtil;
 
@@ -11,6 +11,8 @@
 
 public class RecordBasicsTest extends BaseMapTest
 {
+    record EmptyRecord() { }
+
     record SimpleRecord(int id, String name) { }
 
     record RecordOfRecord(SimpleRecord record) { }
@@ -19,7 +21,9 @@ record RecordWithIgnore(int id, @JsonIgnore String name) { }
 
     record RecordWithRename(int id, @JsonProperty("rename")String name) { }
 
-    record EmptyRecord() { }
+    // [databind#2992]
+    @JsonNaming(PropertyNamingStrategies.SnakeCaseStrategy.class)
+    record SnakeRecord(String myId, String myValue){}
 
     private final ObjectMapper MAPPER = newJsonMapper();
 
@@ -130,6 +134,21 @@ public void testDeserializeJsonRename() throws Exception {
         assertEquals(new RecordWithRename(123, "Bob"), value);
     }
 
+    /*
+    /**********************************************************************
+    /* Test methods, naming strategy
+    /**********************************************************************
+     */
+
+    // [databind#2992]
+    public void testNamingStrategy() throws Exception
+    {
+        SnakeRecord input = new SnakeRecord("123", "value");
+        String json = MAPPER.writeValueAsString(input);
+        SnakeRecord output = MAPPER.readValue(json, SnakeRecord.class);
+        assertEquals(input, output);
+    }
+
     /*
     /**********************************************************************
     /* Internal helper methods

src/test-jdk14/java/com/fasterxml/jackson/databind/Java9ListsTest.java renamed to src/test-jdk14/java/com/fasterxml/jackson/databind/failing/Java9ListsTest.java

@@ -1,8 +1,11 @@
-package com.fasterxml.jackson.databind;
+package com.fasterxml.jackson.databind.failing;
 
 import java.util.Collections;
 import java.util.List;
 
+import com.fasterxml.jackson.databind.BaseMapTest;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.ObjectMapper.DefaultTyping;
 import com.fasterxml.jackson.databind.json.JsonMapper;
 import com.fasterxml.jackson.databind.testutil.NoCheckSubTypeValidator;
 

src/test-jdk14/java/com/fasterxml/jackson/databind/RecordWithJsonSetter2974Test.java renamed to src/test-jdk14/java/com/fasterxml/jackson/databind/failing/RecordWithJsonSetter2974Test.java

@@ -1,11 +1,13 @@
-package com.fasterxml.jackson.databind;
+package com.fasterxml.jackson.databind.failing;
 
 import java.util.List;
 import java.util.Map;
 
 import com.fasterxml.jackson.annotation.JsonSetter;
 import com.fasterxml.jackson.annotation.Nulls;
-import com.fasterxml.jackson.databind.RecordBasicsTest.RecordWithRename;
+import com.fasterxml.jackson.databind.BaseMapTest;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.ObjectReader;
 import com.fasterxml.jackson.databind.exc.InvalidNullException;
 
 public class RecordWithJsonSetter2974Test extends BaseMapTest
@@ -41,8 +43,6 @@ public void testDeserializeWithNullAsEmpty() throws Exception
         assertNotNull(value.agesByNames());
         assertEquals(1, value.agesByNames().size());
         assertEquals(Integer.valueOf(42), value.agesByNames().get("bob"));
-        
-        assertEquals(new RecordWithRename(123, "Bob"), value);
     }
 
     // [databind#2974]

src/test/java/com/fasterxml/jackson/databind/deser/filter/NullConversionsPojoTest.java

@@ -17,6 +17,17 @@ static class NullFail {
         public String noNulls = "b";
     }
 
+    static class NullFailCtor {
+        String value;
+
+        @JsonCreator
+        public NullFailCtor(@JsonSetter(nulls=Nulls.FAIL)
+            @JsonProperty("noNulls") String v)
+        {
+            value = v;
+        }
+    }
+
     static class NullAsEmpty {
         public String nullsOk = "a";
 
@@ -71,6 +82,23 @@ public void testFailOnNull() throws Exception
         } catch (InvalidNullException e) {
             verifyException(e, "property \"noNulls\"");
         }
+
+        // Ditto via constructor; first explicit
+        try {
+            /* NullFailCtor r =*/ MAPPER.readValue(aposToQuotes("{'noNulls':null}"),
+                    NullFailCtor.class);
+            fail("Should not pass");
+        } catch (InvalidNullException e) {
+            verifyException(e, "property \"noNulls\"");
+        }
+
+        // and then implicit (missing -> null)
+        try {
+            /* NullFailCtor r =*/ MAPPER.readValue("{ }", NullFailCtor.class);
+            fail("Should not pass");
+        } catch (InvalidNullException e) {
+            verifyException(e, "property \"noNulls\"");
+        }
     }
 
     public void testFailOnNullWithDefaults() throws Exception
@@ -126,5 +154,9 @@ public void testNullsToEmptyViaCtor() throws Exception
         result = MAPPER.readValue(aposToQuotes("{'nullAsEmpty':null}"),
                 NullAsEmptyCtor.class);
         assertEquals("", result._nullAsEmpty);
+
+        // and get coerced from "missing", as well
+        result = MAPPER.readValue(aposToQuotes("{}"), NullAsEmptyCtor.class);
+        assertEquals("", result._nullAsEmpty);
     }
 }