Migrate legacy reflection properties to use MethodHandles, take 2 (#5090)

Author: stevenschlansker

src/main/java/tools/jackson/databind/deser/BeanDeserializerFactory.java

@@ -1,5 +1,6 @@
 package tools.jackson.databind.deser;
 
+import java.lang.reflect.Modifier;
 import java.util.*;
 
 import com.fasterxml.jackson.annotation.*;
@@ -938,19 +939,16 @@ protected SettableBeanProperty constructSettableProperty(DeserializationContext
         JavaType type = resolveMemberAndTypeAnnotations(ctxt, mutator, propType0);
         // Does the Method specify the deserializer to use? If so, let's use it.
         TypeDeserializer typeDeser = (TypeDeserializer) type.getTypeHandler();
-        SettableBeanProperty prop;
-        if (mutator instanceof AnnotatedMethod) {
-            prop = new MethodProperty(propDef, type, typeDeser,
-                    beanDescRef.getClassAnnotations(), (AnnotatedMethod) mutator);
-        } else {
-            // 08-Sep-2016, tatu: wonder if we should verify it is `AnnotatedField` to be safe?
-            prop = new FieldProperty(propDef, type, typeDeser,
-                    beanDescRef.getClassAnnotations(), (AnnotatedField) mutator);
+        // 05-May-2025, tatu: [databind#5090]/[databind#2083] Need to skip these for some reason
+        if (isFinalField(mutator)) {
+            return null;
         }
         ValueDeserializer<?> deser = findDeserializerFromAnnotation(ctxt, mutator);
         if (deser == null) {
             deser = (ValueDeserializer<?>) type.getValueHandler();
         }
+        SettableBeanProperty prop = new MethodProperty(propDef, type, typeDeser,
+                beanDescRef.getClassAnnotations(), mutator);
         if (deser != null) {
             deser = ctxt.handlePrimaryContextualization(deser, prop, type);
             prop = prop.withValueDeserializer(deser);
@@ -967,6 +965,11 @@ protected SettableBeanProperty constructSettableProperty(DeserializationContext
         return prop;
     }
 
+    private boolean isFinalField(AnnotatedMember am) {
+        return am instanceof AnnotatedField
+                && Modifier.isFinal(am.getMember().getModifiers());
+    }
+
     /**
      * Method that will construct a regular bean property setter using
      * the given setter method.

src/main/java/tools/jackson/databind/deser/SettableBeanProperty.java

@@ -633,6 +633,7 @@ protected void _throwAsJacksonE(JsonParser p, Throwable e, Object value)
 
     protected void _throwAsJacksonE(JsonParser p, Throwable e) throws JacksonException
     {
+        ClassUtil.throwIfError(e);
         ClassUtil.throwIfRTE(e);
         ClassUtil.throwIfJacksonE(e);